bug#25749: grep 3.0 skips "binary" lines in ssconvert output

2017-02-15 Thread Paul Eggert
Alexey Shipunov wrote: it does not explain why grep 2.5.4 has no problem with this file Your test case relies on undefined behavior. In such cases, the behavior might be want you want, and it might not. Although 2.5.4 happened to work the way you wanted, its behavior was not guaranteed and ha

bug#25749: grep 3.0 skips "binary" lines in ssconvert output

2017-02-15 Thread Alexey Shipunov
Hi, Thanks for explanation. However, it does not explain why grep 2.5.4 has no problem with this file. With best wishes, Alexey 2017-02-16 1:11 GMT-06:00 Paul Eggert : > When I tried to read that attachment, gedit complained "There was a problem > opening" it, and then "The file you opened has

bug#25749: grep 3.0 skips "binary" lines in ssconvert output

2017-02-15 Thread Alexey Shipunov
P.S. That problem does not exists in 2.5.4. AS 2017-02-15 22:36 GMT-06:00 Alexey Shipunov : > Dear Madam or Sir, > > That problem almost ruined my work today. > > I made the following note to myself but you might be also interested: > > === > current grep (2.25) is much faster than 2.5.4 from Lu

bug#25749: grep 3.0 skips "binary" lines in ssconvert output

2017-02-15 Thread Alexey Shipunov
P.P.S. Attached are three diff files for grep 2.5.4, grep 2.25 and grep 3.0 AS 2017-02-15 22:47 GMT-06:00 Alexey Shipunov : > P.S. > > That problem does not exists in 2.5.4. > > AS > > 2017-02-15 22:36 GMT-06:00 Alexey Shipunov : >> Dear Madam or Sir, >> >> That problem almost ruined my work tod

bug#25749: grep 3.0 skips "binary" lines in ssconvert output

2017-02-15 Thread Paul Eggert
When I tried to read that attachment, gedit complained "There was a problem opening" it, and then "The file you opened has some invalid characters. If you continue editing this file you could corrupt this document. You can also choose another character encoding and try again." So it is not only

bug#25707: [PATCH] grep: don't forcefully strip carriage returns

2017-02-15 Thread Eric Blake
On 02/14/2017 05:08 PM, Paul Eggert wrote: > On 02/13/2017 12:20 PM, Eric Blake wrote: >> undossify_input causes more problems than it >> solves. We should trust fopen("r") to do the right thing, rather than >> reinventing it ourselves. > > Yes, that makes sense. Attached is a proposed patch to i

bug#25707: [PATCH] grep: don't forcefully strip carriage returns

2017-02-15 Thread Eric Blake
On 02/14/2017 05:08 PM, Paul Eggert wrote: > On 02/13/2017 12:20 PM, Eric Blake wrote: >> undossify_input causes more problems than it >> solves. We should trust fopen("r") to do the right thing, rather than >> reinventing it ourselves. > > Yes, that makes sense. Attached is a proposed patch to i