bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Zev Weiss
On Sat, Aug 20, 2016 at 07:34:20AM +0900, Norihiro Tanaka wrote: On Sat, 20 Aug 2016 07:25:06 +0900 Norihiro Tanaka wrote: Hi Zev, Thanks for replying. I say a reverse thing. I believe that there is no problem if only dfaexec() is thread safe. In other words, I think that variables that we

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Jim Meyering
On Fri, Aug 19, 2016 at 2:54 PM, Zev Weiss wrote: ... > The amended version of the patch looks fine to me, thanks for checking. Pushed.

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Norihiro Tanaka
On Sat, 20 Aug 2016 07:25:06 +0900 Norihiro Tanaka wrote: > Hi Zev, > > Thanks for replying. I say a reverse thing. > > I believe that there is no problem if only dfaexec() is thread safe. In > other words, I think that variables that we must really move to support > multipthread are eolbyte,

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Norihiro Tanaka
On Fri, 19 Aug 2016 16:46:16 -0500 Zev Weiss wrote: > I'm not sure I understand -- the first patch in my series just removes the > global dfa variable and instead passes it as a parameter. This alone doesn't > make the whole thing thread-safe, it's just a first step along the way. With > th

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Zev Weiss
On Fri, Aug 19, 2016 at 09:37:54AM -0700, Jim Meyering wrote: On Thu, Aug 18, 2016 at 7:46 AM, Jim Meyering wrote: On Thu, Aug 18, 2016 at 3:50 AM, Zev Weiss wrote: * src/dfa.c: remove global dfa struct. A pointer to a struct dfa is instead added as a parameter to the functions that had been

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Zev Weiss
On Sat, Aug 20, 2016 at 01:09:20AM +0900, Norihiro Tanaka wrote: On Thu, 18 Aug 2016 05:50:14 -0500 Zev Weiss wrote: * src/dfa.c: remove global dfa struct. A pointer to a struct dfa is instead added as a parameter to the functions that had been using the global. Hi, Why we move global var

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Jim Meyering
On Thu, Aug 18, 2016 at 7:46 AM, Jim Meyering wrote: > On Thu, Aug 18, 2016 at 3:50 AM, Zev Weiss wrote: >> * src/dfa.c: remove global dfa struct. A pointer to a struct dfa is >> instead added as a parameter to the functions that had been using the >> global. > > Thank you. > At first glance, I

bug#24260: [PATCH 1/6] dfa: thread-safety: remove 'dfa' global in dfa.c

2016-08-19 Thread Norihiro Tanaka
On Thu, 18 Aug 2016 05:50:14 -0500 Zev Weiss wrote: > * src/dfa.c: remove global dfa struct. A pointer to a struct dfa is > instead added as a parameter to the functions that had been using the > global. Hi, Why we move global variable DFA into struct dfa, Although only used in dfacomp() whic

bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex

2016-08-19 Thread Norihiro Tanaka
On Thu, 18 Aug 2016 09:21:56 -0600 arn...@skeeve.com wrote: > Norihiro Tanaka wrote: > > > The patch introduces not newline_anchor option of regex to dfa. grep is > > always newline_anchor, so newer codes is not used. I expect it is used > > by sed and gawk. > > > > However, the patch adds an

bug#24262: [PATCH 2/2] dfa: support not newline_anchor of regex

2016-08-19 Thread Norihiro Tanaka
On Thu, 18 Aug 2016 23:57:27 +0900 Norihiro Tanaka wrote: > The patch introduces not newline_anchor option of regex to dfa. grep is > always newline_anchor, so newer codes is not used. I expect it is used > by sed and gawk. > > However, the patch adds an argument to dfasyntax(). To synchroni

bug#24254: issue with configure script in git

2016-08-19 Thread Rishabh Dave
On Thu, Aug 18, 2016 at 2:38 AM, Paul Eggert wrote: > Rishabh Dave wrote: > >> ./configure: line 7227: syntax error near unexpected token `0.9.0' >> ./configure: line 7227: `PKG_PROG_PKG_CONFIG(0.9.0)' > > > My guess is your version of pkg-config is too old. There was and old version at usr/l