Eric Blake wrote:
> Jim Meyering meyering.net> writes:
>> At Karl's request, I reluctantly relaxed the server-side hook that
>> prohibits pushing changes containing added trailing blanks by doing
>> this in savannah's cvs "vserver":
>>
>>
Mike Frysinger wrote:
> On Monday 01 June 2009 20:04:22 Bruno Haible wrote:
>> Mike Frysinger wrote:
>> > actually i just tried this and it didnt work. config.h ended up with:
>> > /* Packager info for bug reports (URL/e-mail/...) */
>> > #undef AS_TR_CPP
>>
>> Oops, you're right. Sorry. I had loo
Mike Frysinger wrote:
> On Monday 01 June 2009 20:04:22 Bruno Haible wrote:
>> Mike Frysinger wrote:
>> > actually i just tried this and it didnt work. config.h ended up with:
>> > /* Packager info for bug reports (URL/e-mail/...) */
>> > #undef AS_TR_CPP
>>
>> Oops, you're right. Sorry. I had loo
email = transa...@gmail.com
> signingkey = 13794A82
>
> [color]
> branch = true
> diff = true
> status = true
> ui = auto
>
> [i18n]
> commitEncoding = utf-8
> logOutputEncoding = utf-8
>
> 2009/5/28 Jim Meyering :
>> Boris Petersen wrote:
>>>
A few of the function declarations in hash.h could benefit from
gcc's warn_unused_result attribute, so I'm adding it:
>From 28e62601bcb5c76e7d4a24ef7d2faaf281503353 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 6 Jun 2009 22:39:23 +0200
Subject: [PATCH] hash: declare some f
Eric Blake wrote:
> According to Eric Blake on 6/7/2009 9:51 PM:
>> According to Jim Meyering on 6/6/2009 2:41 PM:
>>> A few of the function declarations in hash.h could benefit from
>>> gcc's warn_unused_result attribute, so I'm adding it:
>>
>>
FYP, just pushed:
>From a933e8ee26612cb6857993cc921cc8e86161f488 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 14 Jun 2009 17:58:39 +0200
Subject: [PATCH] link-follow: fix the "checking..." message to not mention
trailing slash
* m4/link-follow.m4 (gl_AC_FUNC_LINK_FO
Eric Blake wrote:
> Eric Blake byu.net> writes:
>> Subject: [PATCH] hash: improve memory management
>>
>> * lib/hash.c (hash_delete): Free entries if resize failed.
>> (hash_insert): Don't leave entry on table when returning failure.
>> (hash_rehash): Avoid memory leak, by guaranteeing that we won
Eric Blake wrote:
> Jim Meyering meyering.net> writes:
...
> My code inspection didn't turn up obvious problems, but I have not yet tested
> with USE_OBSTACK either, so I wouldn't be surprised to find bit rot. If we do
> get it working, would it be worth making the
Eric Blake wrote:
> Eric Blake byu.net> writes:
>> I got bored and attempted this. This implementation still passes the m4
>> testsuite, although there might be corner cases not exercised by m4 (such as
>> shrinking the table on hash_delete) that I got wrong, so I'm posting it for
>> review now.
Eric Blake wrote:
> + /* Guarantee that once we start moving entries into the new table,
> + we will not need any further memory allocations. We only need
> + new allocations if the hasher consolidates multiple buckets from
> + the old size into one bucket with the new size (a sign of
Eric Blake wrote:
...
> the table is certainly exceeding the requested threshold of 20% empty buckets.
> Ouch.
Ouch, indeed!
> In other words, this statement in hash_rehash:
>
> /* If the growth threshold of the buckets in use has been reached, increase
> the table size and rehash. There'
Eric Blake wrote:
> According to Eric Blake on 6/17/2009 12:21 PM:
>> Before the rehash, about 20% of the buckets were empty. But after changing
>> the
>> prime factor, the hasher function scatters better, and _every single bucket_
>> is
>> occupied. Which means ALL subsequent calls to hash_in
Slight improvement.
This adds a key assertion at the end of the loop.
>From 59ebc6425b73267ab588cfc1856891736fe3e062 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 8 Jun 2009 16:11:44 +0200
Subject: [PATCH] hash-tests: new module.
* modules/hash-tests: New file.
* tests/test-hash.c:
Eric Blake wrote:
> According to Eric Blake on 6/17/2009 12:21 PM:
>> Before the rehash, about 20% of the buckets were empty. But after changing
>> the
>> prime factor, the hasher function scatters better, and _every single bucket_
>> is
>> occupied. Which means ALL subsequent calls to hash_ins
Eric Blake wrote:
> Jim Meyering meyering.net> writes:
>> Eric Blake wrote:
>> > + /* Guarantee that once we start moving entries into the new table,
>> > + we will not need any further memory allocations. We only need
>> > + new allocations if t
Eric Blake wrote:
> Jim Meyering meyering.net> writes:
>
>> >/* If the growth threshold of the buckets in use has been reached,
> increase
>> > the table size and rehash. There's no point in checking the number
>> > of
>> >
Eric Blake wrote:
> According to Jim Meyering on 6/17/2009 1:21 PM:
>>> is not quite right. A hashing function may be somewhat ill-conditioned for
>>> one
>>> bucket size, but much better conditioned for another size. At any rate, it
>>> looks like th
Eric Blake wrote:
...
> + hash: minor optimization
> + * lib/hash.c (hash_lookup, hash_find_entry): Avoid function call
> + when possible.
> + (hash_initialize): Document this promise.
> + (hash_do_for_each, hash_clear, hash_free): Use C89 syntax.
> + * tests/test-hash.c (ha
Eric Blake wrote:
> I haven't pushed the second one to savannah yet; what do you think of it?
> Sometimes it is desirable to hash distinct pointers, in which case
> allowing a NULL user function to request this seems to make sense. My
> design choice was to provide trivial functions at initializa
Eric Blake wrote:
...
> That discards bits, in the case where non-malloced values are being used. The
> assertion is nice when you know that all values are malloc'd, but is harsh for
> a default. So, how about I squash this slight modification into my patch
> before pushing this commit?
>
> diff
Eric Blake wrote:
> According to Jim Meyering on 6/18/2009 11:37 AM:
>>> + size_t val = data;
>>> + val = (val >> 3) | (val << (CHAR_BIT * sizeof val - 3));
>>> + return val % n;
>>
>> That looks fine.
>
> Added as:
>
> s
Eric Blake wrote:
> How about this simple patch - since the user can request hash_rehash with
> any size, it is possible to call hash_rehash when it is otherwise a no-op.
> This could also happen, for example, with custom tuning parameters that
> shrink the table; eventually, the shrink will pick
lib/bitrotate.h (rotl_sz, rotr_sz): New functions.
> * lib/hash.c (headers): Drop limits.h. Add stdint.h.
> (SIZE_MAX): Rely on headers for definition.
> (hash_string) [USE_DIFF_HASH]: Use rotl_sz.
> (raw_hasher): Use rotr_sz.
> Suggested by Jim Meyering.
...
> diff --git a/lib/ha
Eric Blake wrote:
> Jim Meyering meyering.net> writes:
>
>> >if (new_table == NULL)
>> > return false;
>> > + if (new_table->n_buckets == table->n_buckets)
>> > +return true;
>
> Aargh. Ten minutes after I push, I finally
Eric Blake wrote:
> Jim Meyering meyering.net> writes:
>
>> > Aargh. Ten minutes after I push, I finally see my memory leak.
>> >
>> > Obviously, new_table needs to be freed before returning true.
>>
>> Hah! I should have looked at more than the
Eric Blake wrote:
> According to Jim Meyering on 6/19/2009 1:19 AM:
>> However, I have a slight preference for this, since it leaves us
>> with less duplication of implementation-specific details:
>>
>> if (new_table->n_buckets == table->n_buckets)
>&
Exit,
e.g., via grep -E '^Exit ?\(\)$'. But that might get a false positive,
and this seems like enough for now:
>From 9663cdb7f4531ecb5f35bf7cf45440d6898749d2 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 19 Jun 2009 14:25:37 +0200
Subject: [PATCH] tests: make sc_requi
Eric Blake wrote:
> According to Jim Meyering on 6/19/2009 6:02 AM:
>>> But, come to think of it, why are we even malloc'ing the new_table at all
>>> in this code path? Maybe the better technical approach would be factoring
>>> out the table size computation
Eric Blake wrote:
> According to Jim Meyering on 6/19/2009 7:06 AM:
>> Looks good, but I haven't tested.
>> Ok, presuming you have.
>
> Yes, I reran test-hash.c, as well as the m4 testsuite, using this version.
>
>>
>> One minor suggested change:
>>
&
Eric Blake wrote:
...
> Done. And with that on master, I've rebased my hash_rehash memory leak plug:
>
> http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/hash
> $ git pull git://repo.or.cz/gnulib/ericb.git hash
Thanks. I've just started looking, and one thing struck me:
+static
FYI, just pushed:
>From 8b7595fca68a6f6514fe0e29bbe646ccab3ffd77 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 19 Jun 2009 16:56:48 +0200
Subject: [PATCH] tests: test-hash: allow seed selection via a command line
argument
* tests/test-hash.c (get_seed): New function.
(main): Use
FYI, I've just pushed this no-semantic-change patch:
diff --git a/ChangeLog b/ChangeLog
index 876467c..16cbdbc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2009-06-19 Jim Meyering
+ tests: test-hash: avoid wholesale duplication
+ * tests/test-hash.c (main): Don&#
Jim Meyering wrote:
> Eric Blake wrote:
> ...
>> Done. And with that on master, I've rebased my hash_rehash memory leak plug:
>>
>> http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/hash
>> $ git pull git://repo.or.cz/gnulib/ericb.git hash
>
>
No semantic change:
>From 5082839d34680c5dea88d3b65f021805b963c04d Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 19 Jun 2009 18:49:24 +0200
Subject: [PATCH] hash: reverse order of src/dst parameters in an internal
interface
* lib/hash.c (transfer_entries): Reverse order of paramet
Simon Josefsson wrote:
> hash-test uses xalloc which uses xalloc-die which uses gettext, so
> hash-test needs to link with gettext. See:
>
> http://autobuild.josefsson.org/gnulib/log-200906221702703484000.txt
>
> How about this? Not tested, but seems right.
Looks ok to me.
Thanks.
Sergey Poznyakoff wrote:
> Bruno Haible ha escrit:
...
>> +/* Like version_etc, below, but with the NULL-terminated author list
>> + provided via a variable of type va_list. */
>>
>> Ouch! Not only you expect the user to look up the documentation of the
>> API inside a long source file,
Sergey Poznyakoff wrote:
> Hi Jim,
>
>> Another issue: consistency. With Bruno's approach, a public function must
>> have *no* spec just before its definition, while each private one does.
>> I think we all agree that duplicating the spec (before definition and in
>> the .h file) is not maintainab
Paolo Bonzini wrote:
> "Despite being doucmented, I can't find any sign that it was ever used."
> (git commit dc87183). Doh.
>
> Bison should be updated, for the other projects I know the maintainers
> are listening on bug-gnulib. :-)
>
> Paolo
>
> 2009-06-26 Paolo Bonzini
>
> * autoboo
Eric Blake wrote:
...
> I will be checking in this patch, if no one else beats me to it.
Thanks!
Next time I'll build with coreutils before saying "ok".
Paolo Bonzini wrote:
> Compiling a package without SELinux support can be a security
> problem. On some distributions devel packages for libselinux have to
> be downloaded separately, and it can go unnoticed that packages have
> been configured without SELinux support.
>
> The attached patch will w
Paolo Bonzini wrote:
...
>>> Ok? Should I test /selinux instead of /selinux/enforce?
>>
>> That would be better, since a system for which $(getenforce) reports
>> "Permissive", that /selinux/enforce won't exist.
>> It might be better still simply to see if getenforce can be run.
>
> getenforce is
I've pushed a few changes to bootstrap:
boostrap: indent only with spaces
* build-aux/bootstrap: Indent only with spaces, never TABs.
bootstrap: split long lines
* build-aux/bootstrap: Keep line length < 80.
bootstrap: sync from coreutils
* build-a
Eric Blake wrote:
> git recently started using mkstemps on systems that provide it (new enough
> Solaris has it in , some BSD have it in even though
> it is not standardized, I've just proposed adding it to Cygwin via
> newlib). The general idea of creating temporary files with a known suffix
> i
00:00:00 2001
From: Jim Meyering
Date: Sat, 4 Jul 2009 16:44:19 +0200
Subject: [PATCH] argv-iter: new module
* MODULES.html.sh: Add argv-iter.
* lib/argv-iter.c, lib/argv-iter.h: New files.
* modules/argv-iter: New file.
* modules/argv-iter-tests: New file.
* tests/test-argv-iter.c: Test it.
-
tests/test-argv-iter.c |2 +-
4 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 1dc20c0..1ada00b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-07-05 Jim Meyering
+
+ remove superfluous parentheses in STREQ definition
+ *
FYI, I needed this to avoid false positives, one from cfg.mk
and another from an .m4 file, both in libvirt.
>From b653eda3ac4864de205419d9f41eec267cb89eeb Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 7 Jul 2009 18:35:23 +0200
Subject: [PATCH] maint.mk: don't look for tran
The bug-gnulib and bug-coreutils mailing lists are now
mirrored (including all archives) also at MARC:
http://marc.info/?l=gnulib-bug
http://marc.info/?l=coreutils-bug
Thanks to Hank Leininger for setting that up,
Jim
Eric Blake wrote:
> But even if cygwin is improved to not trigger an internal fault, and/or
> libsigsegv changed to not interfere with cygwin's detection of internal
> faults,
> it seems that the real root cause is that gnulib has caused the application to
> perform undefined behavior during the a
Eric Blake wrote:
> According to Jim Meyering on 7/18/2009 2:42 AM:
>> How about fixing gnulib's lib/error.c to do the right thing?
>> Then if you teach m4/error.m4 to detect when glibc's error function
>> is defective (currently always) it can use the improved repla
hard, either.
>From a90d85f9e7ca8329d05bb7dd02cf807b9086b71e Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 19 Jul 2009 22:33:09 +0200
Subject: [PATCH] fts: avoid false-positive cycle-detection
* lib/fts.c (fts_read): Reinitialize cycle-detection data structures
for each new command line a
Bruno Haible wrote:
> Hi Jim,
>
> The git server at savannah now rejects the normal form of module
> descriptions. I got this error message:
>
> modules/pipe-filter:34: ends with blank lines.
> error: hooks/update exited with error code 2
> error: hook declined to update refs/heads/master
>
>
Bruno Haible wrote:
> Hi Jim,
>
>> Actually, I see trailing blank lines in any text file
>> as an opportunity for unexpected merge conflicts, as
>> one person adds or removes one of those oft-unnoticed lines,
>> and someone else makes a conflicting change.
>
> Conflicts generally occur at spots th
Bruno Haible wrote:
> # "git diff --check" should not reject modules files which end in a blank
> line.
> * whitespace=-trail
> ===
>
> But "git push" is now still rejected:
>
> modules/pipe-filter:34: ends with blank li
Peter Simons wrote:
>>From 640f2ed9570eef3189e43ec7550b32776fdebd0f Mon Sep 17 00:00:00 2001
> From: Peter Simons
> Date: Sun, 19 Jul 2009 18:25:44 +0200
> Subject: [PATCH] lib/sha1.h: wrap declarations in extern "C" scope when
> included from C++
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
I've just pushed the following.
It fixes a nasty little portability problem:
>From 7c385af22c99df5eceda1e82d7aa595e6d5cb796 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 21 Jul 2009 18:24:22 +0200
Subject: [PATCH] vc-list-files: avoid failure when /bin/sh is dash
* build-aux
Peter Simons wrote:
> Hi Jim,
>
> > Would you please adjust that patch to do the same for all lib/sha*.h
> > files as well as lib/md5.h, and (if Simon agrees) lib/md[24].h?
>
> sure, the updated patch is attached below.
Thanks.
I've pushed them, after adding a ChangeLog entry to each.
>From abc
sertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ace4236..55828ed 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-07-23 Jim Meyering
+
+ maint.mk: invoke "make dist" with a working value of XZ_OPT
+ * top/maint.mk (vc-dist): Use no "-&qu
> Unless there are objections to fixing these problems, I can try to come
> up with two patches for them.
Good ideas both.
I've been annoyed at least by the .prev-version one
so propose this change to avoid the diagnostics:
>From 2cf93ffe2a4a3b47c5be31b84592e4e6bfa3b590 Mon Sep 17 0
Jim Meyering wrote:
...
> Good ideas both.
> I've been annoyed at least by the .prev-version one
> so propose this change to avoid the diagnostics:
I've corrected the spelling of Simon's last name (thanks for
spotting those, Ralf!) and pu
James Youngman wrote:
> On Sun, Jul 19, 2009 at 9:35 PM, Jim Meyering wrote:
>> I'm considering a rewrite of rm that uses fts.c,
>> and see that the resulting rm fails coreutils' rm/cycle test
>> because it incorrectly reports a cycle for that unusual case.
>>
Bruno Haible wrote:
...
> Thanks. Even more minimally:
>
> $ ./gnulib-tool --create-testdir --dir=/tmp/testdir mktime
> $ cat > foo.cc < #include
> #include
> EOF
> $ (cd /tmp/testdir && ac_cv_func_working_mktime=no ./configure && make)
> $ gcc -I/tmp/testdir -I/tmp/testdir/gllib -c
Bruno Haible wrote:
>> >> Since I prefer that the hook continue to apply to all files
>> >> for which I have a say, perhaps you'd like to itemize the files
>> >> for which you want to allow trailing blank lines?
>> >
>> > Yes. These should be: modules/**/* and **/ChangeLog*. I believe it
>>
>> My p
mkr...@beckman.com wrote:
> getloadavg.c fails to build on QNX 6.4.1. /usr/include/nlist.h exists, so
> configure defines HAVE_NLIST_H. This makes getloadavg.c define
> NLIST_STRUCT. Since NLIST_STRUCT is defined, getloadavg.c assumes that
> n_name is a pointer, but /usr/include/nlist.h makes it
Joel E. Denny wrote:
> On Wed, 29 Jul 2009, Jim Meyering wrote:
>
>> Joel E. Denny wrote:
>
>> > I'd like to use this in Bison. Would you consider contributing
>> > build-aux/update-copyright to gnulib so we don't maintain separate copies?
>>
&
Without this change, updating coreutils to use latest gnulib
resulted in link errors due to lack of definition of rpl_mktime
on systems like gnu/linux for which the replacement is not used.
>From 5dac0403eb27bfc45fa071ec60f37d7df1dced6d Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed,
Joel E. Denny wrote:
> On Wed, 29 Jul 2009, Jim Meyering wrote:
>
>> Joel E. Denny wrote:
>>
>> > On Wed, 29 Jul 2009, Jim Meyering wrote:
>> >
>> >> Joel E. Denny wrote:
>> >
>> >> > I'd like to use this in Bison. Wo
mkr...@beckman.com wrote:
> How about this?
...
Thank you!
I always feel slightly dirty when changing getloadvg-related
files, but this time it wasn't as bad ;-)
I added a log entry, adjusted comments, and pushed this:
(also pushed the ChangeLog-entry addition)
>From 4feca6e66c4ac183f4cd47402048
|7 +++
lib/getloadavg.c |2 +-
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 239faa6..005290e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-07-31 Jim Meyering
+
+ getloadavg: fix symbol name in comment
+ * lib/getloadav
Peter Simons wrote:
> The original version required a very specific spelling of the line:
>
> old_NEWS_hash = foobar
>
> In particular, it didn't allow for \t to be used instead of blanks, and
> it didn't recognize the simply-expanded assignment operator ':='.
> ---
> top/maint.mk |2 +-
> 1
Bruno Haible wrote:
> Jim Meyering wrote:
>> I've pushed them, after adding a ChangeLog entry to each.
>
> And I've updated the copyright years accordingly:
Updating copyright year lists piecemeal is tiresome and unnecessary, now.
http://marc.info/?l=coreutils-
; specified.
> * modules/update-copyright-tests: New
> * tests/test-update-copyright.sh: New.
Thanks for all of that.
I've pushed that as well as your other three change sets,
and one more change:
>From 296de1083182be81806ba8954f05377308fa3eaa Mon Sep 17 00:00:00 2001
From: Jim
tion
or to omit that, on the presumption that every project using
this code has at least one version-controlled file containing
the word Copyright. The risk of an empty file name list seems
negligible, so I've omitted it.
>From 9c34d44ff2f210d5347b430bb505f658098f539e Mon Sep 17 00:00:00 2001
Hi Simon,
I noticed some long lines and unnecessary '&&' between statements
in the refresh-po rule so made a few changes.
I'm pretty sure I've introduced no semantic change.
>From adbc54c3a6c917941c845fccc557a83c46f130d4 Mon Sep 17 00:00:00 2001
From: Jim Meyering
FYI, one more:
>From 8eda5d5ddd593f97e1ca524ef4c87d178f5c5d92 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 4 Aug 2009 11:17:08 +0200
Subject: [PATCH] maint.mk: make update-copyright exclusion list more
configurable
* top/maint.mk (update-copyright): Default to excluding COPYING,
Joel E. Denny wrote:
> On Tue, 4 Aug 2009, Jim Meyering wrote:
>
>> Thanks for all of that.
>> I've pushed that as well as your other three change sets,
>> and one more change:
>
> Thanks. Unfortunately, my email client ate the \r\n sequences in the DOS
Jim Meyering wrote:
> Joel E. Denny wrote:
>> On Tue, 4 Aug 2009, Jim Meyering wrote:
>>
>>> Thanks for all of that.
>>> I've pushed that as well as your other three change sets,
>>> and one more change:
>>
>> Thanks. Unfortunately, my
Joel E. Denny wrote:
> On Mon, 3 Aug 2009, Joel E. Denny wrote:
>
>> I just ran update-copyright on gnulib. It warns about a long list of
>> files. There are various problems:
>>
>> 1. "@copyright{}" or "©" instead of "(C)".
>
>> In my opinion, update-copyright should be extended to handle #1.
>
ug 2009 10:03:10 -0400
> Subject: [PATCH] update-copyright-tests: improve portability
>
> * tests/test-update-copyright.sh: Use cmp if diff cannot handle
> -u or /dev/null. Suggested by Jim Meyering and Eric Blake.
Thanks. Applied.
Joel E. Denny wrote:
> These patches make update-copyright functionality a little easier to
> understand and a little more powerful. Once these are applied, I will
> feel better about writing a patch that allows "(C)" to be omitted.
>
>>From 61c92eb1ecb5b23c667e026cdb72cce1eaf6f847 Mon Sep 17 00:0
Joel E. Denny wrote:
> For Bison, update-copyright is not enough. Our backend skeletons contain
> m4 macro invocations with lists of copyright years as arguments. I've a
> written a script and a makefile target to handle these, but I would like
> it to be called by maint.mk's update-copyright tar
Joel E. Denny wrote:
> On Tue, 4 Aug 2009, Karl Berry wrote:
>
>> It definitely would be nice, and I've contemplated doing so from time to
>> time, but it never seemed like a big enough deal with which to occupy
>> rms's time discussing.
>
> I understand.
>
>> So, the consensus is that we shou
Joel E. Denny wrote:
> On Thu, 6 Aug 2009, Jim Meyering wrote:
>
>> Joel E. Denny wrote:
>> > For Bison, update-copyright is not enough. Our backend skeletons contain
>> > m4 macro invocations with lists of copyright years as arguments. I've a
>> &g
FYI, I've just done this to README:
>From 10cecf2f783bf0504f05947787495a0d2a75db04 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 6 Aug 2009 12:33:21 +0200
Subject: [PATCH] doc: update README
* README: Remove references to cogito.
Remove cvs-repo-updating instructions from 200
I've just pushed this:
>From 27aa230554a630b52c2ce1540f6274c0aa4eaed1 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 6 Aug 2009 14:15:23 +0200
Subject: [PATCH] selinux-at: new module
Initially written for coreutils, this module will soon be
used by findutils, too.
* MODULES
Joel E. Denny wrote:
...
> That works for me. Thanks, and thanks for reviewing and pushing all my
> other patches.
>
> I'm not sure where ties between modules and maint.mk should be documented,
> but the stale advice in update-copyright ought to updated. Here's a
> patch.
Good idea. Pushed.
Bruno Haible wrote:
> Hi Jim,
>
>> +int getfileconat (int fd, char const *file, security_context_t *con);
>> +int lgetfileconat (int fd, char const *file, security_context_t *con);
>> +int setfileconat (int fd, char const *file, security_context_t con);
>> +int lsetfileconat (int fd, char const
Kamil Dudka wrote:
> On Thu August 6 2009 12:36:06 Kamil Dudka wrote:
>> On Thu August 6 2009 12:16:58 Jim Meyering wrote:
>> > Kamil Dudka wrote:
>> > > On Thu July 30 2009 13:57:00 Jim Meyering wrote:
>> > >> > The attached incremental patch fix
nulib/2008-10/msg00399.html
> [2] http://lists.gnu.org/archive/html/bug-gnulib/2008-10/msg00400.html
Thanks again.
This addresses your comments in this file (not yet those in the links):
>From 733e7c2482a9c937b3491704fe97fe7f14622dad Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 7 Au
Paolo Bonzini wrote:
> In selinux-at.h:
>
>> getfileconat (file,&c).
>
> Should be getfilecon.
Fixed. Thanks for proofreading!
Bruno Haible wrote:
...
> Here's a proposed fix. Jim, is that OK to apply (I guess Paul does not
> have time to read this any more)?
>
>
> 2009-08-08 Bruno Haible
>
> Avoid compilation error in C++ mode.
> * lib/gettimeofday.c (rpl_gettimeofday): Cast timezone argument.
...
>
> - in
-in function 'memset'
Ok to push this fix?
>From 961c9e624934d39c05e8ff9f0321b6d03fab1c45 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 9 Aug 2009 22:42:47 +0200
Subject: [PATCH] tests: avoid warnings due to implicit declaration of memset
* tests/test-select-stdin.c: Include for dec
Bruno Haible wrote:
> Jim Meyering wrote:
>> Ok to push this fix?
>>
>> +* tests/test-select-stdin.c: Include for decl of memset,
>
> No. test-select-stdin.c does not use memset(), therefore there is no reason
> for this file to include .
>
> The memse
I prefer this:
2009-08-10 Jim Meyering
tests: raise ulimit virt-mem limit to avoid new failure
* tests/cp/link-heap: Raise limit from 16MB to ~20MB,
to avoid spurious failure on rawhide.
nl, pinky: replace uses of strcat
* src/n
Sergey Poznyakoff wrote:
> Jim Meyering ha escrit:
>
>> I prefer the existing style, so how about making that format string an
>> option?
>
> That's reasonable. Something like that, then:
That's fine, as long as you also add a line or two in --help output.
Joel E. Denny wrote:
> On Thu, 13 Aug 2009, Eric Blake wrote:
...
>> According to Akim Demaille on 8/13/2009 1:59 AM:
>> >> - Copyright (C) 89, 90, 91, 1995-2006, 2008-2009 Free Software
>> >> - Foundation, Inc.
>> >> + Copyright (C) 89, 90, 91, 1995-2006, 2008-2009 Free Software
>> >> Founda
Eric Blake wrote:
> Jim Meyering meyering.net> writes:
>> +# If you have an additional project-specific rule,
>> +# define it in cfg.mk and set this variable to its name.
>> +update-copyright-local ?=
>> +
>> .PHONY: update-copyright
>> -update-copyright
Joel E. Denny wrote:
> On Fri, 14 Aug 2009, Jim Meyering wrote:
>> > Below are some patches to implement that.
>> ...
>> > +2009-08-14 Joel E. Denny
>> > +
>> > + update-copyright: convert 2-digit to 4-digit years
>> > + * build-aux/upd
Joel E. Denny wrote:
> I just realized I don't know how to configure update-copyright permanently
> for a project. The following patch gives me a way.
Pushed. I'll certainly be using that.
Bruno Haible wrote:
> Hi Jim, Eric, et al.,
>
> The ACL support code for AIX 5 currently has just #if 0 stubs. On 2008-12-07,
> I wrote some work-in-progress code for AIX 5 ACLs (function aclx_get etc.).
> The code is not finished. IIRC, the test suite does not pass.
>
> Unfortunately I cannot cont
801 - 900 of 3902 matches
Mail list logo
