Re: bug#13516: tests/rm/unread3 fails on Mac OS X 10.8

2013-01-24 Thread Assaf Gordon
Hello, Paul Eggert wrote, On 01/24/2013 12:03 PM: > Thanks, could you please try the following patch? > This is a gnulib patch, so it also fixes modules/fdopendir -- > you needn't worry about that part of the patch, > as it doesn't apply to coreutils. > I'm CC'ing this possible patch to bug-gnulib

Re: bug#13495: Compilation fails on Mac OS X 10.8.0

2013-01-24 Thread Assaf Gordon
Paul Eggert wrote, On 01/22/2013 01:20 AM: > On 01/21/2013 11:39 AM, Assaf Gordon wrote: >> This fixes the problem. Compilation succeeds with both gcc and clang. > > Thanks for checking. I pushed the following patch into gnulib > and am marking this coreutils bug as done. &g

Re: bug#13495: Compilation fails on Mac OS X 10.8.0

2013-01-25 Thread Assaf Gordon
Paul Eggert wrote, On 01/24/2013 04:38 PM: > On 01/24/13 13:07, Assaf Gordon wrote: >> $ CFLAGS="-g -O0" ./configure > > Isn't it better to use this? > >./configure CFLAGS="-g -O0" > > If that works, it solves your problem.

Re: bug#13495: Compilation fails on Mac OS X 10.8.0

2013-01-25 Thread Assaf Gordon
An ugly work-around: "-O1" seems to overcome the messy macro expansion of stpncpy. So either compile everything with CFLAGS="-g -O1", Or compile everything with "-g -O0" until it fails, then compile two problematic objects with "-O1" and continue, Or just compile the program of interest and igno

Re: bug#13495: Compilation fails on Mac OS X 10.8.0

2013-01-28 Thread Assaf Gordon
Paul Eggert wrote, On 01/25/2013 05:18 PM: > On 01/25/2013 11:25 AM, Assaf Gordon wrote: > >> So I'm guessing that even though gnulib's stpncpy code is used, >> because the MacOS's native declaration of stpncpy is included, it >> causes problems when the

Re: bug#13516: tests/rm/unread3 fails on Mac OS X 10.8

2013-01-28 Thread Assaf Gordon
Global Odey wrote, On 01/28/2013 12:55 PM: > On 1/27/13 8:34 PM, Paul Eggert wrote: >> Thanks, can you please try this patch instead? It's a bit more drastic, but >> I hope it fixes the loop without introducing that other bug. > > Thank you. Your patch does the trick on OS X 10.8.2, however, it c

Compilation errors when using extended GCC warnings

2013-03-29 Thread Assaf Gordon
Hello, I'm trying to add "gnulib" to a new project. My project enables gcc's "-Wswitch-enum -Wswitch-default -Werror" settings. When adding some gnulib modules, compilation fails. When adding the "propername" module, I get the following error: === unistr/u8-uctomb-aux.c: In function 'u8_uctomb_au

question: gnulib modules that only exist in coreutils?

2013-04-07 Thread Assaf Gordon
Hello, I'm trying to use "gnulib" in my project. I would like to use some modules that seem to exist in the 'coreutils' version of 'gnulib', but not otherwise. specifically: strnumcmp and randread (but later perhaps others). In coreutils, the files do exist: === $ cd coreutils $ find -name "*r

Re: question: gnulib modules that only exist in coreutils?

2013-04-08 Thread Assaf Gordon
Hello Jim, Jim Meyering wrote, On 04/07/2013 09:12 PM: > Assaf Gordon wrote: >> >> I'm trying to use "gnulib" in my project. >> I would like to use some modules that seem to exist in the 'coreutils' >> version of 'gnulib', but not

Using gnulib build tools in a non-GPL project?

2013-04-26 Thread Assaf Gordon
Hello, Is it possible (legally) to use two gnulib scripts (git-version-gen and gitlog-to-changelog) in a non-GPL project? and if so, can the project be 1) BSD/MIT, and 2) proprietary/closed-source ? The two scripts are GPLv3+, and are categorized as "GPLed build tools". The intended usage: 1.

test-symlink fails on "lustre" file system (was: bug#37312: test failure in sed-4.7)

2019-09-05 Thread Assaf Gordon
(adding bug-gnulib@) Hello, Thomas Oppe (CC'd) reported the following gnulib test failure on GNU/Linux with "lustre" file system. Details below: === The system details are: 1. Is this reproducible? After running "make check", there should be an executable file called "gnulib-tests/te

gnupload with gpg>=v2.1 fails due to missing TTY

2019-09-17 Thread Assaf Gordon
Hello, While uploading a new archive to ftp.gnu.org, I noticed that gnupload does not play nice with newer version of gpg. On Debian 10 with /usr/bin/gpg being "gpg (GnuPG) 2.2.12", the signage step fails with: $ ./build-aux/gnupload --to ftp.gnu.org:datamash datamash-1.5.tar.gz Enter GPG

Re: git-version-gen: allow 'snapshot' as .tarball-version contents

2019-10-13 Thread Assaf Gordon
Hello Bruno, On 2019-10-13 3:18 p.m., Bruno Haible wrote: Dmitry V. Levin wrote: I need a non-numeric version for continuous publishing of gettext snapshot tarballs, and I want the tarballs to be called gettext-snapshot.tar.gz, I wonder how users of these tarballs would be able to identify sn

Re: bug#39652: SED preinstall check failed

2020-02-19 Thread Assaf Gordon
tag 39652 moreinfo stop (added bug-gnulib@) Hello, On 2020-02-17 8:12 p.m., Gopinath Sekar via wrote: FAIL: test-rename [...] See gnulib-tests/test-suite.log Please report to bug-...@gnu.org

users.txt: add datamash, time

2020-02-23 Thread Assaf Gordon
Hello, I propose the following small addition to users.txt . -assaf >From b3bf948d4179ef144a87568ecd282e960f6bf293 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Sun, 23 Feb 2020 23:07:42 -0700 Subject: [PATCH] users.txt: Add datamash, time * users.txt: Add datamash, time. --- Change

Re: bug#49308: GNU sed for Tru6 configure CFLAGS?

2021-08-04 Thread Assaf Gordon
(adding gnulib@) Hello, On 2021-07-01 12:35 a.m., Jay K wrote: Hi. I built GNU sed for Tru64. With native cc, not gcc. I realize it is an old system. $ uname -srm OSF1 V5.1 alpha $ which cc /usr/bin/cc $ cc -V Compaq C V6.5-303 (dtk) on HP Tru64 UNIX V5.1B (Rev. 2650) Compiler Driver V6.5-30

Re: automated CI testing

2017-05-17 Thread Assaf Gordon
Hello, On Wed, May 17, 2017 at 09:20:33PM +0200, Tim Rühsen wrote: On Mittwoch, 17. Mai 2017 19:09:52 CEST Bruno Haible wrote: > What about automated / CI testing ? [...] Therefore what is more valuable for gnulib (IMO) is automated testing on 20 different platforms. Of course everybody w

FALLTHROUGH warning in quotearg.c with gcc-7.1

2017-05-25 Thread Assaf Gordon
Hello, Pulling the latest gnulib and compling with gcc-7.1, I'm seeing the following warning: gcc-7.1 -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -Ilib -I./lib -Isrc -I./src -g -O2 -MT lib/quotearg.o -MD -MP -MF $depbase.Tpo -c -o lib/quotearg.o lib/quotearg.c &&\ mv -f

GNU Time updates (slightly off-topic)

2017-07-17 Thread Assaf Gordon
Hello, It's time to update GNU time... As the first step, I've converted the code to use modern gnulib structure and added the standard testing framework. Secondly, I've fixed few issues based on downstream Debian patches. There shouldn't be any functional changes in the current code. Later I ho

OpenGrok for gnulib (and other software)

2017-09-25 Thread Assaf Gordon
Hello, I'm running a small OpenGrok* server with various software including gnulib, glibc, coreutils and other libraries/programs: https://opengrok.housegordon.com/ The gnulib source code is here: https://opengrok.housegordon.com/source/xref/gnulib/ Repositories are updated from git twice a

Re: [PATCH] Implement SM3 hash algorithm in gnulib and the computing tool in coreutils.

2017-10-29 Thread Assaf Gordon
Hello, On 2017-10-24 04:09 AM, Bruno Haible wrote: Indeed, we don't have many crypto experts on the gnulib mailing lists. Therefore, I too would like the crypto experts on the libgcrypt or openssl mailing lists to evaluate the SM3 algorithm and your code first, before we can accept it in gnulib.

Fwd: bug#27269: Sed --in-place is messing NTFS file permissions

2017-11-15 Thread Assaf Gordon
ssions Date: Wed, 15 Nov 2017 03:43:30 -0700 From: Assaf Gordon To: Maiko Cezar Rodrigues Costa , 27...@debbugs.gnu.org Hello, On 2017-11-15 02:23 AM, Assaf Gordon wrote: On 2017-06-06 08:45 PM, Maiko Cezar Rodrigues Costa wrote: Hi, I've a problem with sed when using the --in-place

Re: Fwd: bug#27269: Sed --in-place is messing NTFS file permissions

2017-11-18 Thread Assaf Gordon
Hi Paul, On 2017-11-18 03:46 PM, Paul Eggert wrote: Assaf Gordon wrote: set_permissions uses the USE_ACL #define to either call "set_acls" or call chmod/fchmod directly [4]. It vaguely sounds like a Gnulib bug if set_permissions isn't calling set_acls when it should. Howeve

Re: localename: add support for musl libc

2018-02-24 Thread Assaf Gordon
Hello Bruno, On Sat, Feb 24, 2018 at 01:01:07PM +0100, Bruno Haible wrote: > On Alpine Linux 3.7.0, which uses musl libc, I see this test failure: [...] > diff --git a/lib/localename.c b/lib/localename.c > index 2133cbc..74c8ee0 100644 > --- a/lib/localename.c > +++ b/lib/localename.c > @@ -40,7 +

Re: [PATCH v2 1/4] sha1sum: use AF_ALG when available

2018-04-25 Thread Assaf Gordon
Hello Matteo, On Wed, Apr 25, 2018 at 01:26:08PM +0200, Matteo Croce wrote: > Linux supports accessing kernel crypto API via AF_ALG since > version 2.6.38. Coreutils uses libcrypto when available and fallbacks to > generic C implementation of various hashing functions. Not exactly: coreutils (and

Re: [PATCH v3 0/4] Use AF_ALG in checksum utilities

2018-05-06 Thread Assaf Gordon
Hello Bruno and all, On Sun, May 06, 2018 at 12:31:36PM +0200, Bruno Haible wrote: > Assaf suggested to let it turned off by default, but I prefer to turn it on > by default because I'd still suggest turning it off by default to be more conservative. Few things to consider: > * All known pas

Re: af_alg benchmarks and performance

2018-05-07 Thread Assaf Gordon
Hello Bruno and all, On Tue, May 08, 2018 at 01:10:52AM +0200, Bruno Haible wrote: > Let me try to summarize. Thanks for writing this - informative and helpful. > * We need to consider each of the algorithms md5, sha1 sha256 separately, > because each algorithm has a different performanc

Re: af_alg benchmarks and performance

2018-05-07 Thread Assaf Gordon
Hello, On Tue, May 08, 2018 at 02:20:07AM +0200, Bruno Haible wrote: > The following approaches come to mind: [...] > * Use the kernel-provided meta-info about the algorithms to decide whether > to use the kernel API. > > In detail: Read /proc/crypto at run time. It consists of records

Re: [PATCH v3 0/4] Use AF_ALG in checksum utilities

2018-05-07 Thread Assaf Gordon
Hello Paul, On Mon, May 07, 2018 at 12:36:43AM -0700, Paul Eggert wrote: > Assaf Gordon wrote: [...] > > It won't matter to a single user on a desktop, but imagine > > a shared server at a university, when all of a sudden a sysadmin > > might see a very very high %SYS

Re: af_alg benchmarks and performance

2018-05-09 Thread Assaf Gordon
Hello Matteo and all, Let me emphasize that I'm not against this feature, but I just think it should be disabled by default, and enabled explicitly with a "configure" flag when downstream users want it and deemed it worthwhile. On 09/05/18 02:57 AM, Matteo Croce wrote: [...] All this kernel sup

[PATCH]: regex: fix memory leak in multibyte character set regexes.

2018-07-31 Thread Assaf Gordon
nux-gnu/libc.so.6+0x202e0) == I think the attached patch fixes the issue. Comments welcomed. -assaf >From b1c219384e22fa97ee6fbad7f831b2e18c54 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Tue, 31 Jul 2018 12:18:26 -0600 Subject: [PATCH] regex:

Re: [PATCH]: regex: fix memory leak in multibyte character set regexes.

2018-08-01 Thread Assaf Gordon
rom 'dfamalloc()' should be dfafree'd + free'd. A free() call is missing in one instance. Patch attached, comments welcomed. - assaf >From 4abc3de62c937752327b08b0618426ce4018363d Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Wed, 1 Aug 2018 22:14:21 -0600 Subject: [PAT

regex_internal: uninitialized memory access (long)

2018-08-13 Thread Assaf Gordon
Hello all, I suspect there is an uninitialized memory access deep inside regex_internal.c under very particular circumstances. This was first reported by "project-repo " as part of his fuzzing efforts, here: https://lists.gnu.org/r/sed-devel/2018-08/msg00017.html I've been able to pinpoint the

Re: regex_internal: uninitialized memory access (long)

2018-08-24 Thread Assaf Gordon
Hello, On 13/08/18 03:51 PM, Assaf Gordon wrote: I suspect there is an uninitialized memory access deep inside regex_internal.c under very particular circumstances. (continuation of https://lists.gnu.org/r/bug-gnulib/2018-08/msg00071.html ) I've pin-pointed the change that cause

Re: regex_internal: uninitialized memory access (long)

2018-08-25 Thread Assaf Gordon
Hi, On 25/08/18 01:46 AM, Paul Eggert wrote: Please try the attached gnulib patch, which should fix the problem in a portable way. Modern GCC optimizes the clear code just as well as the confusing code, so we might as well write it clearly. Thanks for the quick fix and explanation. The patch

bug#32592: heap-use-after-free in regex module (was: s with i modifier seems to work incorrectly)

2018-09-05 Thread Assaf Gordon
(adding gnulib) On 04/09/18 07:02 PM, Saito Takaaki wrote: [... discussing a sed bug ...] However, a friend showed me a more complex case which is problematic even with sed 4.4 on ideone. The last two lines of the output (for the identical input lines) are particularly interesting. https://ide

Re: bug#32592: heap-use-after-free in regex module

2018-09-05 Thread Assaf Gordon
Hello, On Wed, Sep 5, 2018 at 12:32 AM Assaf Gordon wrote: >>>> On 04/09/18 07:02 PM, Saito Takaaki wrote:>>> https://ideone.com/Sq5xJX>>>>>> I hope this helps even a bit.>>>> The linked snippet you provided exposed a heap-use-after-free

Re: bug#32592: heap-use-after-free in regex module

2018-09-05 Thread Assaf Gordon
Hello, Assuming the gnulib bugfix is valid (in my previous email), I suggest adding the following test to sed (after updating gnulib). comments welcomed, - assaf >From bc2794c76cd4202df5172bdbe364a4006e6edbe6 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Wed, 5 Sep 2018 18:58:55 -0

Re: bug#32592: heap-use-after-free in regex module

2018-09-05 Thread Assaf Gordon
;t see a code change for > "check for allocation errors and bail out if needed". Thanks! I initially had a check for REG_NOERROR there, but removed it. Attached an updated patch without the outdated comment. -assaf >From 3e6bc87d1a8dc6e22c6d60d06aef0b0b6cb03a49 Mon Sep 17 00:00:

Re: bug#32592: heap-use-after-free in regex module

2018-09-06 Thread Assaf Gordon
Thank you all for the review and comments. On Thu, Sep 6, 2018 at 1:18 AM, Paul Eggert wrote: > What a coincidence that we would find two bugs right next to each other, > huh?... > > I filed a bug report against glibc, and unless there's an objection I would > like to fix both bugs in glibc and p

two (and a half) more crashes in regex module

2018-09-11 Thread Assaf Gordon
SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) /* gnulib regex crash reproducer Copyright (C) 2018 Assaf Gordon License: GPLv3-or-later */ #define _GNU_SOURCE #include #include #include #include #include int main(void) { const char *input = "1AA"; static stru

two more crashes in regex module

2018-09-11 Thread Assaf Gordon
==7809== ==7809== For counts of detected and suppressed errors, rerun with: -v ==7809== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) /* gnulib regex crash reproducer Copyright (C) 2018 Assaf Gordon License: GPLv3-or-later */ #define _GNU_SOURCE #include #include #include

Re: two (and a half) more crashes in regex module

2018-09-18 Thread Assaf Gordon
Hello, On 12/09/18 12:02 AM, Assaf Gordon wrote:    $ echo 1 |  grep -E "(\'|^)(\1|)"    grep: regexec.c:1375: pop_fail_stack: Assertion `num >= 0' failed.    Aborted I don't have a fix yet, but I reduced the crash to this interesting case: $ echo 1 | grep

memory leaks in gnulib tests (for ASAN/LINT)

2018-10-09 Thread Assaf Gordon
Hello gnulib, 'deltatau' recently reported 3 memory leaks detected in gnulib's test in sed [1]. This was found using our recent ASAN build feature [2]. [1] https://bugs.gnu.org/32685 [2] https://git.savannah.gnu.org/cgit/sed.git/commit/?id=0cc0ade4237b8db69f5253c3d933f9890b698f4d It is a long

Re: bug#6816: df bug on 64-bit Solaris (need to use getextmntent)

2018-10-10 Thread Assaf Gordon
(triaging old bugs) Hello, On 15/09/10 04:18 PM, Eric Blake wrote: On 08/06/2010 01:56 PM, Wood, David wrote: From mnttab(4) on Solaris 10: [...] At this point, me->me_dev contains a wrongly packed (32-bit) device number, which forces the find_mount_point() code path (causing other unpl

mountlist: support windows

2018-10-10 Thread Assaf Gordon
welcomed, - assaf >From d1c3e9a61e7c1e9a6bab2b5198d24391e309adc0 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Wed, 10 Oct 2018 14:08:42 -0600 Subject: [PATCH 1/2] mountlist tests: add mountlist-tests module Call read_file_system_list, print the list, and free the entries. Typical output example: $ ./gnulib-tool -

Re: memory leaks in gnulib tests (for ASAN/LINT)

2018-10-10 Thread Assaf Gordon
n the future). regards, - assaf >From 8769b66e1e05f5fdb46221f4a49cef58abaa0b0c Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Wed, 10 Oct 2018 17:01:43 -0600 Subject: [PATCH] samacls tests: free memory under lint Avoids false-positives under ASAN and provides better usage examples. I

Re: mountlist: platform comments

2018-10-11 Thread Assaf Gordon
Hello Bruno, On 11/10/18 03:31 PM, Bruno Haible wrote: The platform comments in mountlist.c and ls-mntd-fs.m4 are not very informative any more. E.g. What is "BSD4.4" nowadays? Why is "Solaris" not mentioned? Here's what I found by compiling a testdir on today's platforms and looking for MOUNTE

Re: bug#6816: df bug on 64-bit Solaris (need to use getextmntent)

2018-10-29 Thread Assaf Gordon
Hello Bruno, On 2018-10-12 10:17 a.m., Bruno Haible wrote: David Wood wrote: At this point, me->me_dev contains a wrongly packed (32-bit) device number, which forces the find_mount_point() code path (causing other unpleasantries). The following patch against coreutils v8.5 fixes the problem:

random module linking problem on mingw ?

2018-12-14 Thread Assaf Gordon
Hello, Around June 2018, there were few changes to the random module: == 6979c258b random_r: do not crash if state is unaligned dc4b9a1f9 random_r: omit unnecessary include 137dda358 random, random_r: merge from glibc == After uprgading gnulib and re-building (towards a new release), and when

Re: random module linking problem on mingw ?

2018-12-15 Thread Assaf Gordon
Hello, On 2018-12-14 3:36 p.m., Paul Eggert wrote: This does not ring a bell with me. Presumably the "# define __random_r random_r" business in lib/random_r.c and lib/stdlib.in.h also need to be done for random and srandom in lib/random.c and lib/stdlib.in.h? Thanks for the hint. The attache

Re: [platform-testers] new snapshot available: grep-3.1.51-e767

2018-12-19 Thread Assaf Gordon
On 2018-12-18 5:49 a.m., Bruno Haible wrote: Hi Assaf, In you reported: CYGWIN_NT-10.0 2.11.1(0.329/5/3) (x86_64) (with one gnulib failure: test-wctype-h) Can you please give more details? With an older version of Cygw

Re: random module linking problem on mingw ?

2018-12-19 Thread Assaf Gordon
On 2018-12-16 8:29 a.m., Bruno Haible wrote: For me, with a gnulib testdir created through ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure random I still get a link error in test-random. "nm" shows why: random.o defines __initstate and __setstate, where test-random.c expec

new module suggestion: fprintftime-check

2018-12-28 Thread Assaf Gordon
Hello, I'd like to suggest the following new module: fprintftime-check. It uses the same infrastructure as fprintftime (i.e. #include "nstrtime,c") to implement a new function: int fprintftime_check (const char *format, const char** err_ptr); This function enables syntax-check of the format s

Re: new module suggestion: fprintftime-check

2018-12-28 Thread Assaf Gordon
Hello Bruno, On 2018-12-28 9:34 a.m., Bruno Haible wrote: This function enables syntax-check of the format string. First question: Should this syntax-check be integrated into the nstrftime() and fprintftime() functions? These functions are gnulib inventions, therefore they could be extended to

Re: lib/freadseek.c:69:3: error: #error "Please port gnulib freadseek.c to your platform!

2018-12-29 Thread Assaf Gordon
Hello, We'll need a bit more technical information to troubleshoot the issue: On 2018-12-29 1:22 a.m., Necktwi Ozfguah wrote: While I am building coreutils with musl on  aarch64 (RaspberryPi 3B), Which operating system and which version are you using? The output of "uname -a" would be helpf

Re: new module suggestion: fprintftime-check

2018-12-29 Thread Assaf Gordon
On 2018-12-28 11:08 p.m., Bruno Haible wrote: [CCing Florian Weimer. Florian, the thread started at https://lists.gnu.org/archive/html/bug-gnulib/2018-12/msg00149.html ] Assaf Gordon wrote: The comment even says: /* Unknown format; output the format, including the '%',

Re: lib/freadseek.c:69:3: error: #error "Please port gnulib freadseek.c to your platform!

2018-12-29 Thread Assaf Gordon
Hello, On 2018-12-29 7:51 a.m., Necktwi Ozfguah wrote: Its coreutils-8.30 with musl-1.1.20 Linux aarch64, Gentoo. I've untared coreutils-8.30.tar.xz cd coreutils-8.30 ./bootstrap ./configure CFLAGS="-march=armv8-a+crc -mtune=cortex-a53 -mcpu=cortex-a53 -ftree-vectorize -O2 -pipe -fomit-frame-

Re: bug#34142: AddressSanitizer reported heap-buffer-overflow

2019-01-20 Thread Assaf Gordon
(forwarding to gnulib) Hello, Hongxu Chen reported a heap-buffer-overflow in gnulib's regexec code. It can be reproduced with current sed using: git clone git://git.sv.gnu.org/sed.git cd sed ./bootstrap && ./configure make build-asan echo 00 |

Re: bug#34141: Stackoverflow triggered at lib/regexec.c:1948

2019-01-20 Thread Assaf Gordon
(forwarding to gnulib) Hello, Hongxu Chen reported a stack-overflow in regexec. I suspect it is the same as the one reported here: https://lists.gnu.org/r/bug-gnulib/2018-09/msg00066.html But just in case, the full report is below. regards, - assaf On 2019-01-19 10:58 p.m., Hongxu Chen wro

selinux: insufficient M4 detection with building static binaries

2019-04-06 Thread Assaf Gordon
Hi, While exploring build coreutils as static binary ( https://lists.gnu.org/r/coreutils/2019-04/msg1.html ) I noticed that gnulib's selinux detection is incomplete. Details: The m4/selinux-selinux.m4 files checks for 'setfilecon' function like so: "AC_SEARCH_LIBS([setfilecon], [selinux], .

Re: [PATCH] ISO 8601 basic format and decimal hours, minutes

2019-04-07 Thread Assaf Gordon
Hello Alex, Thank for you putting the time for writing the patch and descriptions in such details. In general: On 2019-02-18 9:00 p.m., Alex Eulenberg wrote: 1. Accept dates in the ISO 8601 basic date and time format. [...]> 2. Accept decimal fractions of time units other than seconds in acc

Re: selinux: insufficient M4 detection with building static binaries

2019-04-08 Thread Assaf Gordon
Hello Bruno, Thanks for investigating further and the clear explanation. On 2019-04-07 5:08 a.m., Bruno Haible wrote: [] So, these are the libraries that are needed. Apparently libselinux is built in such a way that it needs libdl in the shared build, but libsepol in the static build. Ind

Re: Why does close_stdout close stdout and stderr?

2019-05-07 Thread Assaf Gordon
Hello aa: fsync failed: Invalid argument This perhaps could be avoided if fsync is checked for errors, then a fall-back to fclose? but that's more code, not less... --- For these reasons, I strongly encourage to keep close_stdout + close_stderr. regards, - assaf /* Test program fo

Re: Why does close_stdout close stdout and stderr?

2019-05-07 Thread Assaf Gordon
I should've added: On 2019-05-07 3:44 a.m., Assaf Gordon wrote: I'm attaching a sample test program to illustrate some points. The program writes to stdout/stderr then optionally calls fclose/fflush/fsync. Note the following: The attached program also calls "ferror" o

Re: parse-datetime.y - Military Timezones are inverted from the correct sense

2019-08-09 Thread Assaf Gordon
Hello, On 2019-08-09 5:31 a.m., Neil Hoggarth wrote: I have observed incorrect handling of "Military" timezones when exercising the --date=... option of the GNU coreutils "date" utility. I believe the underlying problem is with initialization of "military_table[]" in the parse-datetime.y file of

Re: parse-datetime.y - Military Timezones are inverted from the correct sense

2019-08-09 Thread Assaf Gordon
gnu date, I suggest the attached patch for coreutils. -assaf >From 19f7eab06af234641a2927514c03570c07a311db Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Fri, 9 Aug 2019 19:51:42 -0600 Subject: [PATCH 1/2] gnulib: update to latest --- gnulib | 2 +- 1 file changed, 1 insertion(+), 1 delet

Possible GETTEXT version mismatch?

2019-08-23 Thread Assaf Gordon
Hello, Just checking, but could it be that there's some mismatch in gnulib about gettext? $ git grep GETTEXT_MACRO_VERSION build-aux/po/Makefile.in.in:GETTEXT_MACRO_VERSION = 0.19 [...] m4/po.m4: AC_SUBST([GETTEXT_MACRO_VERSION], [0.20]) While trying to upgrade gnulib in GNU datamash,

iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-23 Thread Assaf Gordon
Hello, While investigating some other issue, I noticed that non-gnu make fails to create 'iconv_open-aix.h' from 'iconv_open-aix.gperf'. Perhaps this is a non-issue, and only gnu-make is supported for this bootstrapping stage (and non-gnu makes are only supported after "make dist"). Still, worth

: gettext-and-autopoint documentation update?

2019-08-24 Thread Assaf Gordon
Hello, The gnulib manual says: "2. After running gettextize, invoke gnulib-tool and import the gettext module. " https://www.gnu.org/software/gnulib/manual/html_node/gettextize-and-autopoint.html (from 'doc/gnulib-tool.texi' at '@node gettextize and autopoint'). But running: ./gnulib-t

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Assaf Gordon
Hello Bruno, On 2019-08-24 2:19 a.m., Bruno Haible wrote: Perhaps this is a non-issue, and only gnu-make is supported for this bootstrapping stage (and non-gnu makes are only supported after "make dist"). Still, worth reporting. Indeed, we need to distinguish the two uses: Building from a tarb

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Assaf Gordon
On 2019-08-24 3:08 p.m., Bruno Haible wrote: Assaf Gordon wrote: this version of "make" is the native version (=preinstalled by the operating system) in FreeBSD and NetBSD So, by improving the support for OpenBSD I regressed on the same feature in FreeBSD? Ouch. Somewhat related,

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Assaf Gordon
WOW! Bruno, that was exactly the issue! I should've asked you directly before spending hours debugging and bisecting :) On 2019-08-24 3:36 p.m., Bruno Haible wrote: The fact that the error message in both case is "don't know how to make " perhaps hints there's some common dependency detec

How to force using a module in Gnulib? (expl() on OpenBSD)

2014-04-14 Thread Assaf Gordon
Hello, How do I force using the GnuLib implementation of a module, despite the platform having the function ? Case in point: It seems "expl()" is broken on OpenBSD5.4. Others have noticed the same: http://openbsd.7691.n7.nabble.com/exp-expl-on-Linux-and-OpenBSD-expl-bug-td242556.html But a si

Re: How to force using a module in Gnulib? (expl() on OpenBSD)

2014-04-15 Thread Assaf Gordon
Hello, On 04/15/2014 05:20 AM, Pádraig Brady wrote: On 04/15/2014 12:54 AM, Assaf Gordon wrote: It seems "expl()" is broken on OpenBSD5.4. You can set an override var for the configure run, <...> However, since you have a simple enough test it seems it would be better to

Re: How to force using a module in Gnulib? (expl() on OpenBSD)

2014-04-16 Thread Assaf Gordon
Hello, On 04/15/2014 01:34 PM, Pádraig Brady wrote: On 04/15/2014 05:18 PM, Assaf Gordon wrote: + dnl On some systems (OpenBSD5.4) the system's native expl() is buggy: + dnl it returns 'nan' for small values. This test compares expl() to exp() . You might assume that fabs

Re: How to force using a module in Gnulib? (expl() on OpenBSD)

2014-04-16 Thread Assaf Gordon
On 04/16/2014 03:31 PM, Pádraig Brady wrote: On 04/16/2014 06:33 PM, Paul Eggert wrote: Pádraig Brady wrote: + [case $host_os in +mingw*) gl_cv_func_expl_buggy="guessing no";; +*) gl_cv_func_expl_buggy="guessing yes";; + esac]) Sorry, w

syntax-check rule 'sc_copyright_check' assumes "Free Software Foundation"

2014-04-18 Thread Assaf Gordon
Hello, A minor nit-pick for GnuLib's "make syntax-check", where "maint.mk" has the following rule: === sc_copyright_check: <...> @require='Copyright @copyright\{\} .*'$$(date +%Y)' Free' \ in_vc_files=$(texi) \ halt='out of

gnulib overrides git-log-fix upon upgrade?

2014-04-18 Thread Assaf Gordon
Hello, A recent change added a stub "git-log-fix" file to gnulib: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=ce457d622d947d8aa3e325d98a2818d097e7fec9 But, it might have an unintended consequences: When updating "gnulib" submodule in a project, it overrides the project's "git-lo

Re: gnulib overrides git-log-fix upon upgrade?

2014-04-18 Thread Assaf Gordon
But wait... just to verify before pushing this... On 04/18/2014 07:59 PM, Pádraig Brady wrote: On 04/18/2014 11:06 PM, Assaf Gordon wrote: A recent change added a stub "git-log-fix" file to gnulib: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;

[PATCH] announce-gen: avoid perl warnings

2014-07-09 Thread Assaf Gordon
Hello, When running "./build-aux/announce-gen" without any parameters, there are three "use of uninitialized value" warnings: $ ./build-aux/announce-gen announce-gen: release type not specified announce-gen: package name not specified announce-gen: previous version string not specified anno

gnulib "lock" module - test core dump

2014-07-09 Thread Assaf Gordon
Hello, While trying to test another gnulib module (localename), the unit tests failed with a coredump in "test-lock" (related to threading?) . I'm not trying to use threads, but it prevents the 'localename' test from completing. If this is some artifact on my system, I apologize for the noise.

Re: gnulib "lock" module - test core dump

2014-07-10 Thread Assaf Gordon
Follow-up: On 07/09/2014 07:49 PM, Assaf Gordon wrote: While trying to test another gnulib module (localename), the unit tests failed with a coredump in "test-lock" (related to threading?) . <...> System is: Linux 3.13.0-29-generic x86_64 gcc version 4.8.2 (Ubuntu 4.8.2-19u

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
Follow-up: On 07/09/2014 08:29 PM, Assaf Gordon wrote: Relating to a coreutil patch I previously sent, I'm using gnulib's "localename" module. Compiling it triggers two warnings (and errors with -Werror) about functions being candidates for pure/const attributes. I

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
On 07/10/2014 12:20 PM, Pádraig Brady wrote: On 07/10/2014 01:39 AM, Assaf Gordon wrote: make all-recursive make[1]: Entering directory `/home/gordon/projects/gnulib/testdir30793/build' Making all in gllib make[2]: Entering directory `/home/gordon/projects/gnulib/testdir30793/build/

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
On 07/10/2014 01:58 PM, Pádraig Brady wrote: Oh I see now. That was more apparent from your initial patch: http://lists.gnu.org/archive/html/bug-gnulib/2014-07/msg00038.html (which I didn't get due to recent GNU mailing list issues). I'll apply that. Regarding the patch I sent, I think the "

"localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
Hello, Relating to a coreutil patch I previously sent, I'm using gnulib's "localename" module. Compiling it triggers two warnings (and errors with -Werror) about functions being candidates for pure/const attributes. I couldn't trigger it directly with gnulib, but it's reproducible with "coreu

Re: gnulib "lock" module - test core dump

2014-07-11 Thread Assaf Gordon
On 07/11/2014 02:45 AM, Paul Eggert wrote: Thanks, it seems to be a compiler bug on Ubuntu: "#pragma weak" doesn't work, and this breaks gnulib's glthread module. For what it's worth I filed a bug report here: https://bugs.launchpad.net/ubuntu/+source/gcc-defaults/+bug/1340250 Are you expert

tests fail: "test-lock" and "test-thread_create" with gcc 4.6/4.8

2014-09-04 Thread Assaf Gordon
Hello, On Ubuntu 14.04 LTS with GCC 4.6.4 and 4.8.2, the tests "test-lock" and "test-thread_create" fail. They do not fail on same system with GCC 4.4.7 or Clang-3.3 . Confirmed also by Daiki Uenu: http://lists.gnu.org/archive/html/bug-libunistring/2014-09/msg5.html From a brief look it s

"test-lock" stuck on FreeBSD

2014-09-04 Thread Assaf Gordon
Hello, On FreeBSD 10, 9.3, 8.4 (running inside kvm), the test "test-lock" sometime gets stuck. It was found through libunistring but I've also reproduced it with the latest gnulib directly (v0.1-210-g4738e5a), by doing: ./gnulib/gnulib-tool --create-testdir --dir=test-thread --with-tests

Re: tests fail: "test-lock" and "test-thread_create" with gcc 4.6/4.8

2014-09-04 Thread Assaf Gordon
On 09/04/2014 06:00 PM, Paul Eggert wrote: Assaf Gordon wrote: COLLECT_GCC=gcc-4.8 COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Yes, it appears to be a bug in the Ubuntu link-time optimization. Could you please report it to Ubuntu? In the meantime I have installed into

Re: "test-lock" stuck on FreeBSD

2014-09-04 Thread Assaf Gordon
On 09/04/2014 06:02 PM, Paul Eggert wrote: I'm afraid you're going to have to debug this one, as I don't have easy access to FreeBSD SadlyI will not be able to devote time for that in the near future. So it will have to wait. (yes, I know I could set it up in a virtual machine, but it's just

Portable printing of 'size_t' (especially with mingw for windows)

2014-09-11 Thread Assaf Gordon
Hello, I'm not sure if this is a gnulib question per-se, but I'm hopeful you could perhaps advise me. I use the following (or similar) code in my project: size_t line=42; error(EXIT_FAILURE, 0, _("error in line %zu"), line); The "%zu" works for 'size_t' on all unix-like systems I've t

Re: Portable printing of 'size_t' (especially with mingw for windows)

2014-09-11 Thread Assaf Gordon
On 09/11/2014 11:48 AM, Pádraig Brady wrote: I wonder if there's a definition in "inttypes.h" or similar that would be a correct one to use, or if there's another portable way to compile it. I've some notes on printing int values at: http://www.pixelbeat.org/programming/gcc/int_types/ That

Minor portability compilation error: '#include_next' problem with TCC (Tiny C Compiler)

2014-09-15 Thread Assaf Gordon
Hello, I've encountered a compilation error when compiling gnulib with TCC ( Tiny C Compiler, http://bellard.org/tcc/ ): it seems the "#include_next" is not working properly, but "m4/include_next.m4" does not detect it. Tested with TCC version 0.9.26 from the standard debian/stable package. T

Re: Minor portability compilation error: '#include_next' problem with TCC (Tiny C Compiler)

2014-09-15 Thread Assaf Gordon
On 09/15/2014 01:31 PM, Assaf Gordon wrote: I've encountered a compilation error when compiling gnulib with TCC ( Tiny C Compiler, http://bellard.org/tcc/ ): it seems the "#include_next" is not working properly, but "m4/include_next.m4" does not detect it. Tested wit

Minor portability problems: gnulib/coreutils on MINIX3

2014-09-17 Thread Assaf Gordon
Hello, Another exotic portability report: I'm experimenting with compiling GNU Coreutils on MINIX3 (which is supposed to be POSIX-compliant minix kernel with NetBSD userspace). I'm compiling coreutils-8.23, with: $ uname -a Minix 10.0.2.15 3.3.0 Minix 3.3.0 (GENERIC) i386 $ cc -v

Portability testing using pre-configured VMs

2014-10-03 Thread Assaf Gordon
Hello, To ease portability testing of GNU software, I've created a collection of virtual-machines of POSIX-compatible, Free-Software operating systems. These are pre-configured with programs required for building autotools-based projects. If anyone is interested in using them, downloads and mo

build-aux/gnu-web-update-doc-update-git

2014-11-06 Thread Assaf Gordon
Hello gnulib developers, I'm experimenting with GIT-based repositories for the web pages at http://www.gnu.org/software/XXX . For details see here: http://lists.gnu.org/archive/html/savannah-hackers-public/2014-11/msg1.html The current gnulib script 'build-aux/gnu-web-update-doc-update' p

Re: build-aux/gnu-web-update-doc-update-git

2014-11-06 Thread Assaf Gordon
Hello, On 11/06/2014 07:47 PM, Karl Berry wrote: My feedback is that instead of being a separate script that is mostly the same, it seems like it would be better as an option. Attached is an updated patch, this time adding "-G/--git" option to the existing script 'build-aux/gnu-web-doc-update

  1   2   >