Re: servent: Add tests.

Hi Collin, > > But should this condition > > > > #if defined _WIN64 && !defined __CYGWIN__ > > > > not better be > > > > #if !(defined _WIN32 && !defined _WIN64 && !defined __CYGWIN__) > > > > ? > ... > So either would work I believe. Please consider the boolean value of these expressions.

Re: behavioral change in coreutils `pwd` handling '//' (double slash) caused by gnulib update

On 2025-01-06 15:44, Kaz Kylheku wrote: But, here is a question; if you're going to rely on /proc/self in implementing getcwd, why not just read the /proc/self/cwd symlink? Haven't a clue. Also, I don't know why on Linux the Gnulib code doesn't use the getcwd syscall; this should be better th

Re: servent: Add tests.

Bruno Haible writes: > Please consider the boolean value of these expressions. > - Unix: I wish the signature check to be enabled. > - Cygwin: likewise > - 64-bit Windows: here it can be enabled as well. > - 32-bit Windows: here not. This is the case we need to exclude. Oops, that is emb

Re: servent: Add tests.

Hi Bruno, Bruno Haible writes: > But should this condition > > #if defined _WIN64 && !defined __CYGWIN__ > > not better be > > #if !(defined _WIN32 && !defined _WIN64 && !defined __CYGWIN__) > > ? Good question. I wasn't exactly sure how _WIN32 and _WIN64 were defined and copied the conditi

Re: servent: Add tests.

Hi Bruno, Bruno Haible writes: > It's a matter of effort. Disabling the signature test means that code that > uses the function via a function pointer (as opposed to direct invocation) > may run into trouble. Whereas enabling it forces you to fix that case as well, > at the cost of more code in

Re: behavioral change in coreutils `pwd` handling '//' (double slash) caused by gnulib update

On 2024-12-31 10:40, Bruno Haible via GNU coreutils General Discussion worote: > Zach van Rijn wrote in > : >> I am investigating a possible regression in gnulib that manifests >> as a behavioral change in coreutils `pwd` on some

Re: servent: Add tests.

Hi Collin, > I have chosen the lazy option and just disabled the tests. From my quick > search I don't see it used as a function pointer and 32-bit Windows > doesn't seem worth the effort. > > Pushed the attached patch to disable the tests there and document the > declaration. Thanks. This will