Re: [PATCH 3/3] mktime: improve tm_isdst heuristic

2025-01-05 Thread Paul Eggert
On 2025-01-05 07:07, Pádraig Brady wrote: I notice coreutils CI is now failing in a gnulib test with: test-parse-datetime.c:419: assertion 'result.tv_sec == 515107490 - 60 * 60 + (has_leap_seconds ? 13 : 0)' failed Adding some extra debug I see that result.tv_sec is 1 hour too late (i.e. 5151

Re: [PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Hi Paul, Reviewing parse-datetime.y, I see that * 6 invocations of dbg_fputs don't use _(), while the others do. * The invocations of _() inside dbg_printf and dbg_fputs is useless, because at this point in the code the argument is not a string literal, thus 'xgettext' will not extract

Re: [PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Paul Eggert
On 2025-01-05 15:10, Bruno Haible wrote: Any objections to fixing it like in the attached proposed patch? No, and thanks that looks good.

Re: [PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > No, and thanks that looks good. OK. Pushed.

[PATCH] utimensat: mention Linux kernel bug with CIFS

2025-01-05 Thread Paul Eggert
* doc/posix-functions/utimensat.texi (utimensat): Mention Linux kernel bug reported by Bruno Haible in: https://lists.gnu.org/r/bug-tar/2024-12/msg4.html --- ChangeLog | 7 +++ doc/posix-functions/utimensat.texi | 3 +++ 2 files changed, 10 insertions(+) diff --gi

sigsegv tests: Work around a longjmp bug on GNU/Hurd

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Testing a diffutils snapshot on GNU/Hurd, I see two test failures: FAIL: test-sigsegv-catch-stackoverflow1 === *** longjmp causes uninitialized stack frame ***: terminated FAIL test-sigsegv-catch-stackoverflow1 (exit status: 134) FAIL: test-sigsegv-catch-stack

Re: servent: Add tests.

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Collin Funk wrote: > Now all tests pass except for MSVC (32). The error I see there is: > > D:\a\ci-scratch\ci-scratch\testdir1\gltests\test-servent.c(25): error > C2440: 'initializing': cannot convert from 'servent *(__stdcall *)(const char > *,const char *)' to 'servent *(__cdecl *)(const

Re: [PATCH 3/3] mktime: improve tm_isdst heuristic

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > Although I > could not reproduce the test failure on either Fedora 41 or Ubuntu 24.10 > I installed the attached patch, which I hope fixes things for the > coreutils CI (for which I don't know the build+run environment). The test failure occurred also (before your patch) in

[PATCH] parse-datetime: pacify gcc 14 -Wformat-security

2025-01-05 Thread Paul Eggert
I found this when updating GNU patch. * lib/parse-datetime.y (dbg_herald): New static function. (dbg_printf): Use it. (dbg_fputs): New static function. All dbg_printf callers changed to use it, if their formats contain no directives. (parse_datetime_body): Call fputs instead of fprintf if either w

Re: tests: Don't use module 'getcwd' as dependency

2025-01-05 Thread Jim Meyering
On Sun, Jan 5, 2025 at 4:36 AM Bruno Haible via Gnulib discussion list wrote: > Building a recent diffutils snapshot on FreeBSD 5.2.1, I see this > compilation error: > > CCLD diff > ../lib/libdiffutils.a(libdiffutils_a-save-cwd.o): In function `save_cwd': > /usr/home/bruno/diffutils-3.10.24

tests: Don't use module 'getcwd' as dependency

2025-01-05 Thread Bruno Haible via Gnulib discussion list
Building a recent diffutils snapshot on FreeBSD 5.2.1, I see this compilation error: CCLD diff ../lib/libdiffutils.a(libdiffutils_a-save-cwd.o): In function `save_cwd': /usr/home/bruno/diffutils-3.10.242-d65b/build/lib/../../lib/save-cwd.c:65: undefined reference to `rpl_getcwd' gmake[2]: *

xstrtol, xstrtoll tests: Avoid test failure after 2024-07-25 change

2025-01-05 Thread Bruno Haible via Gnulib discussion list
On Cygwin 2.9.0 I'm seeing a test failure: FAIL: test-xstrtol.sh This patch avoids the failure, acknowledging that the results here are different on different Cygwin versions. 2025-01-05 Bruno Haible xstrtol, xstrtoll tests: Avoid test failure after 2024-07-25 change. * tes

Re: [PATCH 3/3] mktime: improve tm_isdst heuristic

2025-01-05 Thread Pádraig Brady
On 05/01/2025 02:35, Paul Eggert wrote: * lib/mktime.c (__mktime_internal): When tm_isdst disagrees with what was requested, search at most a year (+ stride) from the requested time for a matching tm_isdst, and ignore the request if the search fails. This is more likely to match user expectation