Re: experimenting with realloc behaviour

2024-10-21 Thread Bruno Haible via Gnulib discussion list
Paul Eggert wrote: > > Well, if we go for some VARIABLE=VALUE option that is not visible through > > './configure --help', it could be the name of some cache variable: > >gl_cv_realloc_sanitize=yes > > > > Would that be OK? > > Yes, I think so. Implemented through these two patches. The fir

Re: Adding slice-by-4 and slice-by-8 to CRC32

2024-10-21 Thread Bruno Haible via Gnulib discussion list
Hi Sam, Sam Russell wrote on 2024-10-15: > I emailed > ass...@fsf.org and asked to kick off the copyright assignment process. The FSF has received and processed your copyright assignment for Gnulib. You can now start sending proposed patches for review for real. I guess, the first patch should b

Re: [PATCH] tests/test-crc.c: New tests for future optimised implementation.

2024-10-21 Thread Sam Russell
Copyright paperwork is done, is there anymore feedback on this? IMO the main things are as follows: 1) correctness 2) consistency with coding standard 3) solves a problem (new approach reads 8 bytes at a time so we need something that will break if the code does this wrong e.g. alignment, endianne