Re: acl, copy-file: First step towards more consistent function names

2024-08-25 Thread Pádraig Brady
On 24/08/2024 17:49, Bruno Haible wrote: In most Gnulib modules, when we have a function that does something and another function that does the same thing with diagnostics, the common convention is that the latter has an 'x' prefix. Such as for malloc — xalloc vasprintf — xvasprintf getc

Re: acl, copy-file: First step towards more consistent function names

2024-08-25 Thread Collin Funk
Hi Pádraig, Pádraig Brady writes: > I always thought the x...() variants indicate they might eXit(). > > Are there any other x...() variants that just output a diagnostic, > and don't exit()? Originally I felt the same way. Since I generally think about xmalloc, xstrdup, which 99% of the time j

Re: acl, copy-file: First step towards more consistent function names

2024-08-25 Thread Bruno Haible
Pádraig Brady wrote: > I always thought the x...() variants indicate they might eXit(). > > Are there any other x...() variants that just output a diagnostic, > and don't exit()? Indeed, we currently have three categories of x...() variants: - Most of them emit diagnostics and call exit (EXIT_

Re: acl, copy-file: First step towards more consistent function names

2024-08-25 Thread Pádraig Brady
On 25/08/2024 11:48, Bruno Haible wrote: Pádraig Brady wrote: I always thought the x...() variants indicate they might eXit(). Are there any other x...() variants that just output a diagnostic, and don't exit()? Indeed, we currently have three categories of x...() variants: - Most of them

Re: [PATCH] diffseq: port to clang 18.1.6 in ‘patch’

2024-08-25 Thread Paul Eggert
On 2024-08-24 09:05, Bruno Haible wrote: So, when we have a conditional that tests for GCC >= 4.7 or 10 or 14, we don't need to exclude clang, because it's already excluded. Weird. I can no longer reproduce the problem with clang. So I undid that change. If the problem happens again I'll be mo