RE: lib/fnmatch.c: mistakes `char32_t` rather than `wchar_t` on Windows

2024-07-12 Thread YX Hao
Hi Bruno, > The dependencies to these modules (unistr/u32-strlen and unistr/u32-pcpy) are > declared in modules/fnmatch, as well as the link requirements > Could it be that > This workaround of yours disables the support of Unicode characters outside > the BMP (used by Chinese, Emoji, and many

Re: Integer overflows in memchr

2024-07-12 Thread Paul Eggert
On 6/30/24 13:14, Po Lu wrote: I think there should be a trivial test for a functional strnlen in strnlen.m4, since it would be terrible to duplicate what ought to be the responsibility of Gnulib in Emacs's configure.ac. Here's a first cut at doing that, as a patch to Emacs master that I have

timespec_sub bug fix

2024-07-12 Thread Bruno Haible
I needed more infos about this bug fix (so I can know why the CI did not report it within three weeks). Since bug-gnulib was not in CC, I had to search. I updated this ChangeLog entry: 2024-07-10 Pip Cet timespec-sub: Fix compilation error on clang. Reported by Gerd Möllmann

Re: timespec_sub bug fix

2024-07-12 Thread Collin Funk
Bruno Haible writes: > I needed more infos about this bug fix (so I can know why the CI did > not report it within three weeks). Since bug-gnulib was not in CC, I had > to search. I updated this ChangeLog entry: timespec-sub.c:38:12: error: operand argument to checked integer operation must be

Re: timespec_sub bug fix

2024-07-12 Thread Paul Eggert
On 7/13/24 04:20, Collin Funk wrote: Both type2 and type3 shall be any integer type other than "plain" char, bool, a bit-precise integer type, or an enumerated type, and they need not be the same. Yes, and it's annoying that you can't use 'bool' there. In theory, for example, it