test-framework-sh: Fix typo in function invocation (regression 2024-06-11).

2024-06-23 Thread Collin Funk
I noticed that tests/init.sh is copied to many GNU projects for their own test suite (manually I assume). This means that on BSD the use of '-t' spams the -p directories in /tmp. I noticed this when looking at something unrelated in diffutils earlier. While copying the file over I noticed a ca

Re: tests/init.sh

2024-06-23 Thread Bruno Haible
Collin Funk wrote: > If someone wants to update these packages that would be nice. :) > > $ find . -name 'init.sh' | xargs grep -l 'mktemp -d -t -p' > ./cppi/tests/init.sh > ./diffutils/tests/init.sh > ./grep/tests/init.sh > ./parted/tests/init.sh > ./sed/testsuite/init.sh > ./vc-dwim/tests/init.s

Re: tests/init.sh

2024-06-23 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > Rather than having to sync this file from gnulib manually, it would > be better if the 'bootstrap.conf' file of each of the packages > would contain an invocation of > gnulib-tool --copy-file tests/init.sh > This would make this sync automatic. Agreed. I don'

Re: tests/init.sh

2024-06-23 Thread Bruno Haible
Collin Funk wrote: > I don't see that option used much. GNU poke uses it in bootstrap.conf. > So I think it is worth mentioning > that projects like sed will need to use the --tests-base option. No, that would add constraints between things that better stay independent: - the import of Gnulib

Re: tests/init.sh

2024-06-23 Thread Collin Funk
Bruno Haible writes: >> So I think it is worth mentioning >> that projects like sed will need to use the --tests-base option. > > No, that would add constraints between things that better stay > independent: > - the import of Gnulib tests into the package (if desired), > - the use of init.sh