Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-29 Thread Bruno Haible
Hi Collin, > I was not a fan of adding another value to the left side of this > assignment: > > emit, uses_subdirs = self.emitter.lib_Makefile_am(basename, ...) Why not? This is perfectly normal functional programming style. Lisp has it ("multiple values"), ISO C has it ("struct" as return v

Re: what can we expect from developers

2024-03-29 Thread Darshit Shah
Hi Bruno, I think you make some fair points on the contributions made by people with a passable knowledge of the language. However, when I said "maintained", I kind of assumed that there will be someone with a good enough command over the language who will be the arbiter of what patches get ap

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-29 Thread Collin Funk
Hi Bruno, On 3/29/24 4:16 AM, Bruno Haible wrote: >> I was not a fan of adding another value to the left side of this >> assignment: >> >> emit, uses_subdirs = self.emitter.lib_Makefile_am(basename, ...) > > Why not? This is perfectly normal functional programming style. > Lisp has it ("multi

Re: bug#70070: FAIL: test-localtime_r

2024-03-29 Thread Pádraig Brady
On 29/03/2024 12:40, Andreas Schwab wrote: FAIL: test-localtime_r == test-localtime_r.c:58: assertion 'result->tm_hour == 18' failed FAIL test-localtime_r (exit status: 134) FAIL: test-localtime_r-mt = thread2 disturbed by thread1! thread1 disturbed

gnulib-tool.py: Display specified modules in bold.

2024-03-29 Thread Collin Funk
I noticed that the bold printing was missing. One of the most important changes I've made yet. CollinFrom 95e3bf4e2d912ffc87889c72cff7119523bf081b Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Fri, 29 Mar 2024 06:09:20 -0700 Subject: [PATCH] gnulib-tool.py: Display specified modules in bold.

Re: gnulib-tool.py: Display specified modules in bold.

2024-03-29 Thread Pádraig Brady
On 29/03/2024 13:12, Collin Funk wrote: I noticed that the bold printing was missing. One of the most important changes I've made yet. You could determine that programatically with something like: if os.system(r'{ tput bold || tput md; } >/dev/null 2>&1') == 0: # enable bold output cheers,

Re: what can we expect from developers

2024-03-29 Thread Dmitrii Pasechnik
On Fri, Mar 29, 2024 at 12:54:12PM +0100, Darshit Shah wrote: > I think you make some fair points on the contributions made by people with a > passable knowledge of the language. > However, when I said "maintained", I kind of assumed that there will be > someone with a good enough command over t

Re: bug#70070: FAIL: test-localtime_r

2024-03-29 Thread Bruno Haible
Andreas Schwab wrote: > > FAIL: test-localtime_r > > == > > > > test-localtime_r.c:58: assertion 'result->tm_hour == 18' failed > > FAIL test-localtime_r (exit status: 134) > > > > FAIL: test-localtime_r-mt > > = > > > > thread2 disturbed by thread1! >

Re: gnulib-tool.py: Fix removal of variables from GLMakefileTable.

2024-03-29 Thread Bruno Haible
Hi Collin, > You have to be a bit careful with unpacking tuples: > >(a, b) = (1, 2, 3) >Traceback (most recent call last): > File "", line 1, in > ValueError: too many values to unpack (expected 2) > (a, b, _) = (1, 2, 3) > print(f'{a} {b}') > 1 2 Common Lisp, in t

Re: gnulib-tool.py: Display specified modules in bold.

2024-03-29 Thread Bruno Haible
Hi Collin, > I noticed that the bold printing was missing. Thanks! Applied. > One of the most important changes I've made yet. :-)

Re: bug#70070: FAIL: test-localtime_r

2024-03-29 Thread Andreas Schwab
On Mär 29 2024, Bruno Haible wrote: > Yes. And make sure that it has a time zone database installed at all. Why? That doesn't make any sense.

Re: bug#70070: FAIL: test-localtime_r

2024-03-29 Thread Bruno Haible
Andreas Schwab wrote: > > Yes. And make sure that it has a time zone database installed at all. > > Why? That doesn't make any sense. You can leave the consideration of which test case makes sense or not on my side. What we need from you, as a reporter, is a statement on which platform (distro a

Re: gnulib-tool.py: Display specified modules in bold.

2024-03-29 Thread Bruno Haible
Pádraig Brady wrote: > You could determine that programatically with something like: > > if os.system(r'{ tput bold || tput md; } >/dev/null 2>&1') == 0: ># enable bold output Thanks for the hint, but this way of doing introduces more complexity. There are basically 4 situations regarding TE

Issue with intprops-internal.h / GCC 8.3

2024-03-29 Thread Paul Smith
I have a bug report for a compiler error in GNU Make, using intprops-internal.h, on Debian 10 with GCC 8.3: https://savannah.gnu.org/bugs/?65537 This is with gnulib stable-202401 current Git HEAD. Thoughts? Maybe I just have to disable this warning? Note, I already do not enable -Werror etc.

Re: gnulib-tool.py: Display specified modules in bold.

2024-03-29 Thread Bruno Haible
Pádraig Brady wrote: > > You could determine that programatically with something like: > > > > if os.system(r'{ tput bold || tput md; } >/dev/null 2>&1') == 0: > ># enable bold output Thanks for the hint. Use of 'tput bold' indeed activates bold-face output on - Linux console (TERM=linux),

Re: Issue with intprops-internal.h / GCC 8.3

2024-03-29 Thread Paul Eggert
On 3/29/24 13:14, Paul Smith wrote: I have a bug report for a compiler error in GNU Make, using intprops-internal.h, on Debian 10 with GCC 8.3: https://savannah.gnu.org/bugs/?65537 This is a false alarm from that old GCC version. I suggested to the original bug reporter to try the attached pa

Re: gnulib-tool.py: Display specified modules in bold.

2024-03-29 Thread Collin Funk
Hi Pádraig, On 3/29/24 6:34 AM, Pádraig Brady wrote: > On 29/03/2024 13:12, Collin Funk wrote: > You could determine that programatically with something like: > > if os.system(r'{ tput bold || tput md; } >/dev/null 2>&1') == 0: > # enable bold output Thanks for the advice. I tried checking if

Re: Issue with intprops-internal.h / GCC 8.3

2024-03-29 Thread Bruno Haible
Hi Paul, > I have a bug report for a compiler error in GNU Make, using > intprops-internal.h, on Debian 10 with GCC 8.3: > > https://savannah.gnu.org/bugs/?65537 > > This is with gnulib stable-202401 current Git HEAD. > > Thoughts? Maybe I just have to disable this warning? > > > Note, I alr

Re: what can we expect from developers

2024-03-29 Thread Bruno Haible
Hi Darshit, > I will however concede that modern Python has a lot of syntactic sugar which > in a way detracts from Python's original charm of being extremely easy to > read and parse. So if we for example end up using complex generators and > comprehensions, it will make it hard for a lot of p

gnulib-tool.py: Fix reading of 'gl_VC_FILES' in gnulib-cache.m4.

2024-03-29 Thread Collin Funk
This small patch fixes this diff in the import tests: $ cat ../output.txt $ diff -u ./test-oath-toolkit-1.result/gl/m4/gnulib-cache.m4 tmp27490-result/gl/m4/gnulib-cache.m4 --- ./test-oath-toolkit-1.result/gl/m4/gnulib-cache.m4 2024-03-29 02:47:03.843697386 -0700 +++ tmp27490-result/gl/m4/gnul

gnulib's build-to-host.m4 and its role in the recent xz backdoor

2024-03-29 Thread Eric Gallager
Hi, I recently read about the major xz backdoor that's been all over the internet, for example, here: https://openwall.com/lists/oss-security/2024/03/29/4 One thing I noticed in the writeup is that part of the way it worked involved a modified copy of gnulib's build-to-host.m4 macro file; compare t