Re: [PATCH 2/2] posix: Improve randomness on try_tempname_len

2021-01-11 Thread Adhemerval Zanella
On 08/01/2021 23:20, Paul Eggert wrote: > On 1/4/21 9:03 AM, Adhemerval Zanella wrote: >> For __GT_NOCREATE (mktemp, tempnam, tmpnam) getrandom is also used >> on first try, otherwise randomness is obtained using the clock plus >> a linear congruential generator. > > Why not use getrandom in th

Re: [PATCH 1/2] posix: Sync tempname with gnulib [BZ #26648]

2021-01-11 Thread Adhemerval Zanella
On 08/01/2021 22:58, Paul Eggert wrote: > On 1/4/21 9:03 AM, Adhemerval Zanella wrote: > >> -# define __lstat64(version, file, buf) lstat (file, buf) >> +# define __lxstat64(version, file, buf) lstat (file, buf) > > That change isn't quite right for the !_LIBC case, since it doesn't define >

Re: [PATCH 2/3] posix: Remove alloca usage on regex build_trtable

2021-01-11 Thread Adhemerval Zanella
On 08/01/2021 19:30, Paul Eggert wrote: > On 1/6/21 10:17 AM, Adhemerval Zanella wrote: >> __libc_use_alloca/alloca is replaced with malloc regardless. > > These allocations are so small that they should be put on the stack instead > of using malloc. I did that in Gnulib by installing the atta

Re: [PATCH 1/3] posix: Remove alloca usage on regex set_regs

2021-01-11 Thread Adhemerval Zanella
On 08/01/2021 17:14, Paul Eggert wrote: > On 1/6/21 10:17 AM, Adhemerval Zanella wrote: >> It replaces the regmatch_t with a dynarray list. > > regexec.c is shared with Gnulib, so some work needed to be done on the Gnulib > side for this patch since Gnulib didn't have dynarray. Dynarray is som

Re: [PATCH 3/3] posix: Remove alloca definition from regex

2021-01-11 Thread Adhemerval Zanella
On 08/01/2021 22:20, Paul Eggert wrote: > This patch looks good for glibc, once the previous two regex patches are > done. I installed it into Gnulib by applying the attached, so that > regex_internal.h can stay in lock-step between Gnulib and glibc. Right, I will sync the regex code with gnu

Re: rcs configure hang

2021-01-11 Thread Kelly Wang (kellythw)
Hi Thien, Thanks for follow up. Here is my reply on 11/10/2020. Thanks for checking. Here is my system info: % uname -a Linux sjc-ads-7913 4.18.0-147.3.1.el8_1.x86_64 #1 SMP Wed Nov 27 01:11:44 UTC 2019 x86_64 unknown unknown GNU/Linux % rpm -q kernel kernel-4.18.0-80.el8.x86_64 kernel-4.18.0-14

Re: rcs configure hang

2021-01-11 Thread Florian Weimer
* Kelly Wang: > Hi Florian, > > Thanks for checking. Here is my system info: > % uname -a > Linux sjc-ads-7913 4.18.0-147.3.1.el8_1.x86_64 #1 SMP Wed Nov 27 01:11:44 UTC > 2019 x86_64 unknown unknown GNU/Linux > % rpm -q kernel > kernel-4.18.0-80.el8.x86_64 > kernel-4.18.0-147.3.1.el8_1.x86_64 >

Re: [PATCH 2/2] posix: Improve randomness on try_tempname_len

2021-01-11 Thread Paul Eggert
On 1/11/21 4:29 AM, Adhemerval Zanella wrote: The idea is to always issue getrandom for __GT_DIR or __GT_FILE on first try, as you suggested initially [1]. I followed your idea [2]:... > [1] https://sourceware.org/pipermail/libc-alpha/2020-September/117535.html [2] https://sourceware.org/pip