Re: [PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-23 Thread Paul Eggert
On 11/22/20 10:08 AM, Pádraig Brady wrote: Non leaky version attached. Thanks, I installed that, along with the attached further coreutils patch to fix some bugs in the nearby errno handling. Most likely there are other issues in the SELinux area but I ran out of time to look into this right

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-23 Thread Kamil Dudka
On Sunday, November 22, 2020 7:08:44 PM CET Pádraig Brady wrote: > > It seems selabel_lookup requires absolute paths. > > Reinstating that code with the attached, > > gets all tests to pass here on Fedora 32 > > with selinux enabled. > > Non leaky version attached. > > cheers, > Pádraig Thanks f

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-23 Thread Paul Eggert
On 11/23/20 1:15 AM, Kamil Dudka wrote: ...: context lookup failed: Operation not supported Thanks, I think I see the problem. I installed the attached to try to fix it. From e3a96eb14e8834f046d8370db80dfdc561ef5550 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 23 Nov 2020 01:48:1

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-23 Thread Kamil Dudka
On Monday, November 23, 2020 10:49:57 AM CET Paul Eggert wrote: > Thanks, I think I see the problem. I installed the attached to try to fix it. Yes, this made the test-suite green again. Thanks! Kamil

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-23 Thread Bernhard Voelker
On 11/23/20 3:26 AM, Paul Eggert wrote: > On 11/22/20 10:59 AM, Bernhard Voelker wrote: >> selinux.c:257 has a superfluous semicolon after a jump label, >> and a strange indentation: > > The semicolon is required by the C standard, which does not allow a label > before > a declaration. Emacs ind

[PATCH] selinux-at, selinux-h: use const correct declarations

2020-11-23 Thread Pádraig Brady
* lib/se-selinux.in.h: Use const for "set" functions, to match current selinux, and support cleaner user code. * lib/selinux-at.c: Likewise. * lib/selinux-at.h: Likewise. --- ChangeLog | 8 lib/se-selinux.in.h | 18 +- lib/selinux-at.c| 4 ++-- lib/selinux-

Re: Signals on Mingw

2020-11-23 Thread Eli Zaretskii
> From: Reuben Thomas > Date: Sun, 22 Nov 2020 23:46:37 + > Cc: bug-gnulib > >- Is it useful to have these signal names defined at all? If they can never > occur on native Windows, it does not necessarily make sense to define > them. > > If I wanted native (non-POSIX) functionalit

Re: Signals on Mingw

2020-11-23 Thread Reuben Thomas
On Mon, 23 Nov 2020 at 16:09, Eli Zaretskii wrote: > > Can you elaborate what are you using this module for in the MinGW > build? AFAIK, Posix signals can never work well enough on Windows to > care about them. Maybe I'm missing something. > Signal numbers for use in a GDB debugger stub: stubs

Re: Signals on Mingw

2020-11-23 Thread Eli Zaretskii
> From: Reuben Thomas > Date: Mon, 23 Nov 2020 16:38:22 + > Cc: Bruno Haible , bug-gnulib > > Can you elaborate what are you using this module for in the MinGW > build? AFAIK, Posix signals can never work well enough on Windows to > care about them. Maybe I'm missing something. > > Sig

Re: Signals on Mingw

2020-11-23 Thread Reuben Thomas
On Mon, 23 Nov 2020 at 16:47, Eli Zaretskii wrote: > > From: Reuben Thomas > > Date: Mon, 23 Nov 2020 16:38:22 + > > Cc: Bruno Haible , bug-gnulib > > > > Can you elaborate what are you using this module for in the MinGW > > build? AFAIK, Posix signals can never work well enough on Windo

Re: Signals on Mingw

2020-11-23 Thread Reuben Thomas
On Mon, 23 Nov 2020 at 17:08, Reuben Thomas wrote: > Good question! Looks like the code is relying on the definitions matching. > (I used one of the sample debugger stubs, which seems not to have been > changed for many years; meanwhile, gdb seems to have introduced its own > enumeration. I guess

Re: %z for printf on mingw

2020-11-23 Thread Bruno Haible
Hi Reuben, > gnulib can #define __USE_MINGW_ANSI_STDIO so that %z is implemented, but > warnings are still generated for xasprintf (not for printf). > > As far as I can tell, this is because the > _GL_ATTRIBUTE_FORMAT_PRINTF_SYSTEM machinery to choose the correct > attribute (__gnu_printf__ or __