Re: [PATCH] Update savannah URLs of gnulib.git files

2020-11-21 Thread Bruno Haible
Hi Dmitry, > * MODULES.html.sh: Prefer cgit URLs over gitweb. I don't think this is a good idea. For a particular file, the result of both wget commands is the same. But the use in such scripts also encourages users to use similar URLs to access to git repository. Here, gitweb is more human-fri

Re: [PATCH] Update savannah URLs of gnulib.git files

2020-11-21 Thread Dmitry V. Levin
Hi Bruno, On Sat, Nov 21, 2020 at 03:18:15PM +0100, Bruno Haible wrote: > Hi Dmitry, > > > * MODULES.html.sh: Prefer cgit URLs over gitweb. > > I don't think this is a good idea. > > For a particular file, the result of both wget commands is the same. I vaguely remember we had different points

[PATCH] read-file: remove dead assignment

2020-11-21 Thread Daiki Ueno
>From 69b8df2c5b011b09c8d03c13566356a906bd89dc Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Sat, 21 Nov 2020 17:32:58 +0100 Subject: [PATCH] read-file: remove dead assignment * lib/read-file.c (fread_file): Remove dead assignment when RF_SENSITIVE is set, flagged by clang-analyzer. --- Change

Re: [PATCH] read-file: remove dead assignment

2020-11-21 Thread Bruno Haible
Daiki Ueno wrote: > diff --git a/lib/read-file.c b/lib/read-file.c > index 88bc0070a..be93a7e09 100644 > --- a/lib/read-file.c > +++ b/lib/read-file.c > @@ -156,7 +156,6 @@ fread_file (FILE *stream, int flags, size_t *length) >memcpy (new_buf, buf, save_alloc); >expl

Re: [PATCH] Update savannah URLs of gnulib.git files

2020-11-21 Thread Bruno Haible
Hi Dmitry, > in this case of blob_plain requests there is > obviously no difference except that cgit is usually faster. It is a lesser problem that a script takes 0.3 seconds longer to execute, than that a developer gets confused when they want to take a look at a git repository and the foremost

Update after 'test-driver' in Automake changed

2020-11-21 Thread Bruno Haible
This patch avoids a notice when Automake 1.16.3 is used: patching file build-aux/test-driver Hunk #1 succeeded at 106 (offset 2 lines). 2020-11-21 Bruno Haible Update after 'test-driver' in Automake changed. * build-aux/test-driver.diff: Rebase. diff --git a/build-aux/test-d

[PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-21 Thread Paul Eggert
Coreutils with --enable-gcc-warnings does not build on Ubuntu 20.10 because matchpathcon is deprecated in favor of selabel_open etc., so this patch adds stubs for these functions. * lib/se-label.c, lib/se-label.in.h, m4/selinux-label-h.m4: New files. * lib/se-selinux.in.h (struct selinux_opt): Add

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-21 Thread Bernhard Voelker
On 11/21/20 9:55 PM, Paul Eggert wrote: > Coreutils with --enable-gcc-warnings does not build on Ubuntu 20.10 > because matchpathcon is deprecated in favor of selabel_open etc., > so this patch adds stubs for these functions. Hi Paul, caution - duplicate work ahead: https://lists.gnu.org/archiv

Re: bug#44535: grep-3.6 released [stable]

2020-11-21 Thread Paul Eggert
On 11/12/20 11:39 PM, Paul Eggert wrote: We have dueling compilers here, as Sun C complains if the return statements are present[1], whereas gcc -Wreturn-type complains if they're absent. Since the return statements are clearly bogus and unnecessary I'm inclined to continue to omit them. I lo

[PATCH] setlocale-null-tests: work around GCC bug 44511

2020-11-21 Thread Paul Eggert
* tests/test-setlocale_null-mt-all.c: * tests/test-setlocale_null-mt-one.c: Ignore -Wreturn-type, to work around GCC bug 44511. --- ChangeLog | 5 + tests/test-setlocale_null-mt-all.c | 5 + tests/test-setlocale_null-mt-one.c | 5 + 3 files changed, 15 insertio

Re: [PATCH] selinux-h: add stubs for selabel_open etc.

2020-11-21 Thread Paul Eggert
Yes, it's looking like great minds think alike. The coreutils patch I had prepared is fancier than yours, though, as it caches the result of selabel_open and this should yield better performance. I don't use SELinux either. From the look of the coreutils source it appears that the coreutils S