: gettext-and-autopoint documentation update?

2019-08-24 Thread Assaf Gordon
Hello, The gnulib manual says: "2. After running gettextize, invoke gnulib-tool and import the gettext module. " https://www.gnu.org/software/gnulib/manual/html_node/gettextize-and-autopoint.html (from 'doc/gnulib-tool.texi' at '@node gettextize and autopoint'). But running: ./gnulib-t

Remove unused file

2019-08-24 Thread Bruno Haible
The file m4/stat-macros.m4 is unused since 2006-10-27. 2019-08-24 Bruno Haible Remove unused file. * m4/stat-macros.m4: Remove file. diff --git a/m4/stat-macros.m4 b/m4/stat-macros.m4 deleted file mode 100644 index 72e9ec4..000 --- a/m4/stat-macros.m4 +++ /dev/null @@ -1,

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Bruno Haible
Hi Assaf, > Perhaps this is a non-issue, and only gnu-make is supported > for this bootstrapping stage (and non-gnu makes are only supported > after "make dist"). Still, worth reporting. Indeed, we need to distinguish the two uses: Building from a tarball, and building from a git checkout. For b

gc: fix configuration with --with-libgcrypt

2019-08-24 Thread Bruno Haible
When I run $ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure crypto/gc-sha1 crypto/gc-md2 crypto/gc-md4 crypto/gc-md5 crypto/gc-rijndael crypto/gc-sm3 $ cd ../testdir1 $ ./configure --with-libgcrypt the configuration always fails with configure: error: libgcrypt not found

crypto/gc: access the module indicators correctly

2019-08-24 Thread Bruno Haible
The C macros defined by gl_MODULE_INDICATOR expand to expressions that evaluate to 0 or 1. They don't always evaluate to 1. (Namely, when a module is needed by tests only.) Therefore it is wrong to test them with '#ifdef'. 2019-08-24 Bruno Haible crypto/gc: Access the module indicator

crypto/gc: fix link error with --with-libgcrypt

2019-08-24 Thread Bruno Haible
A gnulib testdir created through ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure crypto/gc-md5 when built with ./configure --with-libgcrypt && make fails with gcc -g -O2 -o test-gc-md5 test-gc-md5.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a(gc-lib

Re: crypto/gc: fix link error with --with-libgcrypt

2019-08-24 Thread Bruno Haible
> A gnulib testdir created through > > ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure > crypto/gc-md5 > > when built with > > ./configure --with-libgcrypt && make > > fails with Similar link errors also exist for crypto/gc-md2, crypto/gc-md4, crypto/gc-rijndael, and t

crypto/gc-md2: add comment

2019-08-24 Thread Bruno Haible
The gc-libgcrypt.c file always takes the md2 implementation from gnulib. It should get it from libgcrypt, when this library is available, like for md4, md5, sha1. How to reproduce: $ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure \ crypto/gc-md2 crypto/gc-md4 crypto/gc-md5 c

crypto/gc-md2: optimize and clarify code

2019-08-24 Thread Bruno Haible
Make lib/gc-gnulib.c and lib/gc-libgcrypt.c more consistent with each other. 2019-08-24 Bruno Haible crypto/gc-md2: Optimize and clarify code. * lib/gc-gnulib.c (gc_hash_open): Comment out md2_init_ctx invocation. * lib/gc-libgcrypt.c (gc_hash_open): Clarify why md2_in

crypto/gc-sm3: fix compilation error with --with-libgcrypt

2019-08-24 Thread Bruno Haible
This fails: $ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure crypto/gc-sm3 $ cd ../testdir1 $ ./configure --with-libgcrypt $ make ... gc-libgcrypt.c: In function 'gc_hash_open': gc-libgcrypt.c:309:17: error: 'GCRY_MD_SM3' undeclared (first use in this function) gcryalg

new modules crypto/gc-sha256, crypto/gc-sha512

2019-08-24 Thread Bruno Haible
When Simon added the "generic crypto" modules (= modules that can use libgcrypt, libcrypt from openssl, or just gnulib code), he prepared the code for use of modules named gc-sha256, gc-sha384, gc-sha512 2007-02-05. But these modules did not exist, since there was no fallback code available in gnul

Re: Possible GETTEXT version mismatch?

2019-08-24 Thread Bruno Haible
Hi Assaf, > Just checking, but could it be that there's some mismatch > in gnulib about gettext? > >$ git grep GETTEXT_MACRO_VERSION >build-aux/po/Makefile.in.in:GETTEXT_MACRO_VERSION = 0.19 >[...] >m4/po.m4: AC_SUBST([GETTEXT_MACRO_VERSION], [0.20]) > > While trying to upgrade

doc: document most of the files outside of modules

2019-08-24 Thread Bruno Haible
I'm adding two new documentation chapters. 2019-08-24 Bruno Haible doc: Document most of the files outside of modules. * doc/gnulib.texi (Build Infrastructure Files, Release Management Files): New chapters. diff --git a/doc/gnulib.texi b/doc/gnulib.texi index 051c077.

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Assaf Gordon
Hello Bruno, On 2019-08-24 2:19 a.m., Bruno Haible wrote: Perhaps this is a non-issue, and only gnu-make is supported for this bootstrapping stage (and non-gnu makes are only supported after "make dist"). Still, worth reporting. Indeed, we need to distinguish the two uses: Building from a tarb

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Bruno Haible
Assaf Gordon wrote: > this version of "make" is the native version > (=preinstalled by the operating system) in FreeBSD and NetBSD So, by improving the support for OpenBSD I regressed on the same feature in FreeBSD? Ouch. Bruno

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Assaf Gordon
On 2019-08-24 3:08 p.m., Bruno Haible wrote: Assaf Gordon wrote: this version of "make" is the native version (=preinstalled by the operating system) in FreeBSD and NetBSD So, by improving the support for OpenBSD I regressed on the same feature in FreeBSD? Ouch. Somewhat related, I'm also

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Bruno Haible
Hi Assaf, > I'm also struggling with another "bmake" issue relating to automake, > here: https://lists.gnu.org/r/automake/2019-08/msg0.html > > Seems like some recent change in automake broke compilation (of released > tarballs) with "bmake", while gnu-make still works. > > The fact that th

Re: iconv_open: non-gnu make fails to generate "iconv_open-aix.h"

2019-08-24 Thread Assaf Gordon
WOW! Bruno, that was exactly the issue! I should've asked you directly before spending hours debugging and bisecting :) On 2019-08-24 3:36 p.m., Bruno Haible wrote: The fact that the error message in both case is "don't know how to make " perhaps hints there's some common dependency detec

[PATCH] intprops: say why not Clang __builtin_add_overflow

2019-08-24 Thread Paul Eggert
* lib/intprops.h (_GL_HAS_BUILTIN_OVERFLOW): Mention Clang in comment, responding to a query from Mattias EngdegÄrd. --- ChangeLog | 7 +++ lib/intprops.h | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 2a458f077..f7fbcf413 100644 --- a

Re: gc: fix configuration with --with-libgcrypt

2019-08-24 Thread Paul Eggert
Bruno Haible wrote: Paul and Karl: If you agree, can we add a $LIBGCRYPT to config/srclist.txt? We like keeping files in sync; that's what config/srclist.txt is for. So I'm all for this, and expect Karl will be too.