Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread Kamil Dudka
On Tuesday, April 10, 2018 9:54:26 PM CEST Bernhard Voelker wrote: > Hi Kamil, > > On 04/06/2018 09:29 AM, Kamil Dudka wrote: > > On Friday, April 6, 2018 8:08:55 AM CEST Bernhard Voelker wrote: > >> On 04/05/2018 02:44 PM, Kamil Dudka wrote: > >>> The same 'find' command with > >>> the -noleaf op

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread James Youngman
On Thu, Apr 5, 2018 at 4:49 PM, Paul Eggert wrote: > > On 04/05/2018 05:44 AM, Kamil Dudka wrote: >> >> Does this change (intentionally?) enable leaf optimization for CIFS? > > > No, I wasn't thinking about CIFS when I wrote that. Thanks for reporting it. I installed the attached to try to fix thi

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread Kamil Dudka
On Wednesday, April 11, 2018 3:38:40 PM CEST James Youngman wrote: > On Thu, Apr 5, 2018 at 4:49 PM, Paul Eggert wrote: > > On 04/05/2018 05:44 AM, Kamil Dudka wrote: > >> Does this change (intentionally?) enable leaf optimization for CIFS? > > > > No, I wasn't thinking about CIFS when I wrote th

Gnulib on Windows (native / mingw32) / VMS / etc.

2018-04-11 Thread Paul Smith
Hi all. I spent a bit of time this weekend looking into what it would take to update GNU make to use the glob/fnmatch implementations from the current gnulib, rather than the ancient (and buggy) implementation that GNU make has embedded, more or less unchanged, for at least 25 years. This, unfort

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread Paul Eggert
On 04/11/2018 07:03 AM, Kamil Dudka wrote: As far as I know, there is currently no fix available for that. I looked into this and found some bugs in relevant code (bugs that I introduced last summer; sorry!). I installed the attached into Gnulib to fix what I found. Please give it a try and s

Re: Gnulib on Windows (native / mingw32) / VMS / etc.

2018-04-11 Thread Paul Eggert
Except for VMS, GNU Emacs is in a boat similar to GNU Make. It uses Gnulib (but not Automake), it is buildable on MS-Windows and does not need Cygwin, it has its own configuration batch script for MS-Windows (and MS-DOS!). So I would look to Emacs for inspiration here. I'm mostly responsible fo

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread Bernhard Voelker
On 04/11/2018 09:53 PM, Paul Eggert wrote: > @@ -1589,6 +1593,15 @@ mem1: saved_errno = errno; > tail->fts_link = p; > tail = p; > } > + > +/* If there are many entries, no sorting function

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread Paul Eggert
On 04/11/2018 02:58 PM, Bernhard Voelker wrote: didn't you mean the '>' operator? No, '==' should be right. I added the attached to try to explain this better. Thanks for the nudge. >From 09ca545d5c0af8760ce27b1e9cbe300e64f73746 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 11 Apr 2

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread Bernhard Voelker
On 04/12/2018 01:28 AM, Paul Eggert wrote: > No, '==' should be right. I added the attached to try to explain this > better. Thanks for the nudge. ah, indeed, running dirent_inode_sort_may_be_useful only once in the loop may/will save quite some time, thanks. Have a nice day, Berny