Re: [PATCH] gnulib-tool: new option --gnu-make

2017-03-14 Thread Paul Eggert
Bruno Haible wrote: Anything that uses an Automake-specific feature other than "if FOO / else / endif" would be suspect, yes. For example, I suppose there would be trouble if a module uses the Automake syntax "if FOO / else !FOO / endif !FOO". Hmm. We use this pattern a lot. In particular, in ev

Re: Not distributing README-release automatically.

2017-03-14 Thread Mathieu Lirzin
Jim Meyering writes: > On Tue, Mar 7, 2017 at 8:08 AM, Mathieu Lirzin wrote: >> >> Jim Meyering writes: >> >>> On Sun, Mar 5, 2017 at 8:12 AM, Mathieu Lirzin wrote: I have been using 'readme-release' module and was surprised to discover that the "README-release" file was automat

[PATCH] users.txt: Update link to libvirt's repo

2017-03-14 Thread Michal Privoznik
The currently listed link does not exist anymore. For a quite long time the libvirt's repo lives on libvirt.org server. Signed-off-by: Michal Privoznik --- users.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/users.txt b/users.txt index d638a335a..4fa555331 100644 --- a/

unused-parameter.h: not

2017-03-14 Thread Michal Privoznik
Dear list, I'm a libvirt developer and we rely on gnulib in our project. However, I was reviewing a patch for bhyve driver (bhyve is a *BSD hypervisor), so I've booted up my FreeBSD virtual machine and started the review. While doing 'make distcheck' gnulib tests ran and I've noticed couple of the

[PATCH] gnulib-tool: fix typo in comment output

2017-03-14 Thread Paul Eggert
* gnulib-tool (func_import): Fix typo with previous change. --- ChangeLog | 3 +++ gnulib-tool | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 09aec7b..6ae54d5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2017-03-14 Paul Eggert +

Re: Not distributing README-release automatically.

2017-03-14 Thread Jim Meyering
On Tue, Mar 14, 2017 at 4:34 AM, Mathieu Lirzin wrote: > Jim Meyering writes: > >> On Tue, Mar 7, 2017 at 8:08 AM, Mathieu Lirzin wrote: >>> >>> Jim Meyering writes: >>> On Sun, Mar 5, 2017 at 8:12 AM, Mathieu Lirzin wrote: > > I have been using 'readme-release' module and was sur

Re: Not distributing README-release automatically.

2017-03-14 Thread Bruno Haible
Mathieu Lirzin wrote: > Here is the patch: Given the code from gnulib-tool that you are removing, I think: > +EXTRA_DIST += top/GNUmakefile This should read EXTRA_DIST += $(top_srcdir)/GNUmakefile > +EXTRA_DIST += top/maint.mk This should read EXTRA_DIST += $(top_srcdir)/maint.mk othe

Re: [PATCH] users.txt: Update link to libvirt's repo

2017-03-14 Thread Bruno Haible
Michal Privoznik wrote: > The currently listed link does not exist anymore. For a quite > long time the libvirt's repo lives on libvirt.org server. Thanks. Applied. Bruno

Re: unused-parameter.h: not

2017-03-14 Thread Bruno Haible
Hi Michal, > libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. > -I../../../../gnulib/lib -I../.. -I../../../.. -O0 -ggdb3 -MT fflush.lo > -MD -MP -MF .deps/fflush.Tpo -c ../../../../gnulib/lib/fflush.c -fPIC > -DPIC -o .libs/fflush.o > ../../../../gnulib/lib/fflush.c:31:30: fatal error: unus

Re: Not distributing README-release automatically.

2017-03-14 Thread Jim Meyering
On Tue, Mar 14, 2017 at 10:34 AM, Bruno Haible wrote: > Mathieu Lirzin wrote: >> Here is the patch: > > Given the code from gnulib-tool that you are removing, I think: > >> +EXTRA_DIST += top/GNUmakefile > > This should read > >EXTRA_DIST += $(top_srcdir)/GNUmakefile > >> +EXTRA_DIST += top/ma

Re: Not distributing README-release automatically.

2017-03-14 Thread Mathieu Lirzin
Hi, Bruno Haible writes: > Mathieu Lirzin wrote: >> Here is the patch: > > Given the code from gnulib-tool that you are removing, I think: > >> +EXTRA_DIST += top/GNUmakefile > > This should read > >EXTRA_DIST += $(top_srcdir)/GNUmakefile > >> +EXTRA_DIST += top/maint.mk > > This should read

Re: Not distributing README-release automatically.

2017-03-14 Thread Jim Meyering
On Tue, Mar 14, 2017 at 11:28 AM, Mathieu Lirzin wrote: ... > Here is an updated patch with a rationale in the ChangeLog: > > Thanks for the review (to both of you). Thank you. I've pushed that.

Re: unused-parameter.h: not

2017-03-14 Thread Paul Eggert
Thanks for the report. This is due to my change of yesterday, which I'll try to fix today.

Re: z/OS and symlink()

2017-03-14 Thread Daniel Richard G.
Hi Bruno, On Tue, 2017 Feb 28 16:47+0100, Bruno Haible wrote: > > The relevant spec here is POSIX: > http://pubs.opengroup.org/onlinepubs/9699919799/functions/symlink.html > Line 64 of test-symlink.h:64 corresponds to the case > > [ENOENT] or [ENOTDIR] > The path2 argument contains at leas

Re: z/OS and symlink()

2017-03-14 Thread Paul Eggert
On 03/14/2017 12:53 PM, Daniel Richard G. wrote: Special-case the test for z/OS? That sounds like the right way to go, yes. I hope the special case is small and unobtrusive code.

vma-iter on AIX

2017-03-14 Thread Bruno Haible
Just found out that there is a /proc directory on AIX. But it cannot be used to implement the 'vma-iter' functionality. 2017-03-14 Bruno Haible vma-iter: Add comment about AIX. * lib/vma-iter.c: Add comment about why this module is not implemented on AIX. diff --git a

Re: unused-parameter.h: not

2017-03-14 Thread Paul Eggert
I installed the attached patch to Gnulib on Savannah; please give it a try. From 6100762d213cac9c23f4cf7328210e73c0dc98d2 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 14 Mar 2017 13:23:25 -0700 Subject: [PATCH] snippets: move unadjusted snippet sources to lib Problem reported by Michal