Re: [PATCH 11/12] utimes: detect utimes() correctly on OS/2 kLIBC

2015-05-28 Thread KO Myung-Hun
Hi/2. Paul Eggert wrote: > KO Myung-Hun wrote: >> +/* utimes() of OS/2 kLIBC does not work on an opened file */ >> +else if (close (fd) != 0) >> + result |= 1; > > This limitation of should be documented in > doc/posix-functions/utimes.texi, presumably as an OS/2 deficien

[PATCH] unlinkat: handle ignoring of ".." on Darwin 14

2015-05-28 Thread Pádraig Brady
* lib/unlinkat.c: unlinkat() has the same bug as unlink() on Mac OS X 10.10, where it ignores paths with a trailing "..", so handle in the same manner. * m4/unlinkat.m4: Comment on this Darwin issue. * doc/posix-functions/unlink.texi: Update the latest version where the issue was seen. * doc/posix-

Re: [PATCH 06/12] gnulib-tool: fall back into copy if symbolic link is not supported

2015-05-28 Thread KO Myung-Hun
Hi/2. Paul Eggert wrote: > KO Myung-Hun wrote: > >> +# Check if symbolic link is supported >> +have_symlink_support=false >> +rm -f symlink$$.file symlink$$ >> +if (echo >symlink$$.file) 2>/dev/null; then >> + if ln -s symlink$$.file symlink$$ 2>/dev/null; then >> +have_symlink_support=true

[PATCH] linkat: avoid OS X 10.10 trailing slash with symlink bug

2015-05-28 Thread Pádraig Brady
On Darwin 14.3.0 linkat(,"path1",,"dangling_symlink/",) causes the symlink to be dereferenced, and if it points to a non existent file, that file will be created as a hard link to "path1". This fixes a test failure in test-linkat.c. * m4/linkat.m4 (gl_FUNC_LINKAT): Augment the test with this case.

Re: [PATCH 06/12] gnulib-tool: fall back into copy if symbolic link is not supported

2015-05-28 Thread Paul Eggert
Yes, that looks good.