Re: [bug-libunistring] [PATCH v4] unistr: New modules for backward iteration in string.

2014-09-19 Thread Daiki Ueno
Ben Pfaff writes: > New module 'unistr/u8-mb-prev-uc'. > New module 'unistr/u16-mb-prev-uc'. > New module 'unistr/u32-mb-prev-uc'. Thanks, looks good to me. Some nit-picking below. * _GL_UNUSED_PARAMETER of u32_mb_prev_uc seems to be a leftover, as the argument is actually used in the implem

Re: [bug-libunistring] [PATCH v4] unistr: New modules for backward iteration in string.

2014-09-19 Thread Ben Pfaff
On Fri, Sep 19, 2014 at 04:55:24PM +0900, Daiki Ueno wrote: > Ben Pfaff writes: > > > New module 'unistr/u8-mb-prev-uc'. > > New module 'unistr/u16-mb-prev-uc'. > > New module 'unistr/u32-mb-prev-uc'. > > Thanks, looks good to me. Some nit-picking below. > > * _GL_UNUSED_PARAMETER of u32_mb_pr