Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-06 Thread Dylan Cali
On Fri, Sep 5, 2014 at 10:51 AM, Paul Eggert wrote: > Thanks, it looks like some declarations are missing in the corresponding .h > file, or are missing attributes that they should have. Is that something > you could write a patch for? Hi Paul, Attached is a patch for the attribute and declarat

Re: [PATCH v2] gnulib-tool: Download PO files

2014-09-06 Thread Mathieu Anquetin
Thanks for applying. Best regards, Mathieu Le 6 sept. 2014 02:18, "Ben Pfaff" a écrit : > On Thu, Sep 04, 2014 at 05:41:08PM +0200, Mathieu Anquetin wrote: > > On Thu, Sep 4, 2014 at 5:12 PM, Ben Pfaff wrote: > > > On Thu, Sep 04, 2014 at 08:54:47AM +0200, Mathieu Anquetin wrote: > > >> These t

Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-06 Thread Paul Eggert
Dylan Cali wrote: --- a/lib/gl_avltree_list.h +++ b/lib/gl_avltree_list.h @@ -24,6 +24,7 @@ extern "C" { #endif +extern void gl_avltree_list_check_invariants (gl_list_t list); On second thought this doesn't look wise, as the function is not expected to be exported to ordinary clients, onl

Re: compile warnings when including avltree-list and gcc-warnings is enabled

2014-09-06 Thread Dylan Cali
On Sat, Sep 6, 2014 at 7:30 PM, Paul Eggert wrote: > On second thought this doesn't look wise, as the function is not expected to > be exported to ordinary clients, only to the test cases. So let's leave the > .h file alone, and put a declaration in the .c file instead. > > I suppose a pragma is

[PATCH] users.txt: add cmogstored

2014-09-06 Thread Eric Wong
cmogstored has used gnulib since the beginning in 2012 to support GNU/Linux, FreeBSD, and GNU/kFreeBSD. cmogstored is currently included in the FreeBSD ports collection, but developed primarily on GNU/Linux. Signed-off-by: Eric Wong --- users.txt | 1 + 1 file changed, 1 insertion(+) diff --gi