fallback _GL_ATTRIBUTE_* definitions in intl.m4

2014-07-16 Thread Daiki Ueno
Hi, There are growing number of uses of _GL_ATTRIBUTE_* in Gnulib source files, which are also shared with libintl. Since libintl can be copied into non-Gnulib projects, we have to add fallback definitions to the libintl source. However, this might cause divergence between Gnulib and gettext in

Re: Fix libunistring in MS-Windows locales

2014-07-16 Thread Daiki Ueno
Eli Zaretskii writes: >> Date: Tue, 15 Jul 2014 12:20:44 -0700 >> From: Paul Eggert >> >> Thanks, I installed that, with minor changes to indentation and suchlike. > > Thank you. Sorry for not looking at it timely. Do you need a new libunistring release with this change? I don't even know if

Re: Fix libunistring in MS-Windows locales

2014-07-16 Thread Eli Zaretskii
> From: Daiki Ueno > Cc: Paul Eggert , bug-gnulib@gnu.org > Date: Wed, 16 Jul 2014 19:02:03 +0900 > > Do you need a new libunistring release with this change? I think it would be good, yes. > I don't even know if Guile is still using the packaged libunistring. It does, at least as of its late

[PATCH] parse_long_options: after --help, avoid fallthrough into --version

2014-07-16 Thread Bernhard Voelker
Does anyone know of a tool using parse_long_options() which would rely on printing the --version text right after the usage text for the --help option? Otherwise ... see patch below. Have a nice day, Berny >From f75f6dd2671231c880ee9cf040ccebaf7c58b6c0 Mon Sep 17 00:00:00 2001 From: Bernhard Voe

Re: [PATCH] parse_long_options: after --help, avoid fallthrough into --version

2014-07-16 Thread Eric Blake
On 07/16/2014 04:43 PM, Bernhard Voelker wrote: > Does anyone know of a tool using parse_long_options() which > would rely on printing the --version text right after the usage > text for the --help option? I'm guessing that the (*usage) callback is SUPPOSED to be marked with the noreturn attribute

Re: [PATCH] parse_long_options: after --help, avoid fallthrough into --version

2014-07-16 Thread Jim Meyering
On Wed, Jul 16, 2014 at 3:43 PM, Bernhard Voelker wrote: > Does anyone know of a tool using parse_long_options() which > would rely on printing the --version text right after the usage > text for the --help option? No. That would be a bug. ... > case 'h': >(*usage_func) (EX

Re: Fix libunistring in MS-Windows locales

2014-07-16 Thread Daiki Ueno
Eli Zaretskii writes: >> By the way, isn't there a minor race in gl_locale_name_thread, since it >> depends on a global variable found_lcid? > > Yes. (It is not a problem for Guile, since Guile built with threads > on Windows is severely broken, so the only way of having a useful > Guile on Wind