Re: [PATCH] gettext: update macros to version 0.19

2014-07-10 Thread Bernhard Voelker
On 07/10/2014 01:49 AM, Pádraig Brady wrote: [PATCH] build: sync with gnulib gettext 0.19 requirement puh, for me as openSUSE user this means that I have to build gettext on my hosts, as the latest release openSUSE-13.1 still uses 0.18.3.1 (and most probably won't upgrade), and 0.19.1 didn't ev

Re: gnulib "lock" module - test core dump

2014-07-10 Thread Assaf Gordon
Follow-up: On 07/09/2014 07:49 PM, Assaf Gordon wrote: While trying to test another gnulib module (localename), the unit tests failed with a coredump in "test-lock" (related to threading?) . <...> System is: Linux 3.13.0-29-generic x86_64 gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) "test-l

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
Follow-up: On 07/09/2014 08:29 PM, Assaf Gordon wrote: Relating to a coreutil patch I previously sent, I'm using gnulib's "localename" module. Compiling it triggers two warnings (and errors with -Werror) about functions being candidates for pure/const attributes. I couldn't trigger it directl

Re: [PATCH] Add missing include of windows.h in nl_langinfo.c

2014-07-10 Thread Eli Zaretskii
> Date: Wed, 09 Jul 2014 16:02:31 -0600 > From: Eric Blake > > On 07/09/2014 05:13 AM, Pavel Hrdina wrote: > > The commit fcfce839 improved localization of names for week days > > and months, but the author forget to include windows.h in order > > to use 'GetACP ()'. Without this header file buil

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Pádraig Brady
On 07/10/2014 01:39 AM, Assaf Gordon wrote: > Follow-up: > > On 07/09/2014 08:29 PM, Assaf Gordon wrote: >> >> Relating to a coreutil patch I previously sent, I'm using gnulib's >> "localename" module. >> Compiling it triggers two warnings (and errors with -Werror) about functions >> being candi

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
On 07/10/2014 12:20 PM, Pádraig Brady wrote: On 07/10/2014 01:39 AM, Assaf Gordon wrote: make all-recursive make[1]: Entering directory `/home/gordon/projects/gnulib/testdir30793/build' Making all in gllib make[2]: Entering directory `/home/gordon/projects/gnulib/testdir30793/build/gllib' mak

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Pádraig Brady
On 07/10/2014 06:16 PM, Assaf Gordon wrote: > On 07/10/2014 12:20 PM, Pádraig Brady wrote: >> On 07/10/2014 01:39 AM, Assaf Gordon wrote: >>> >>> make all-recursive >>> make[1]: Entering directory >>> `/home/gordon/projects/gnulib/testdir30793/build' >>> Making all in gllib >>> make[2]: Entering

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
On 07/10/2014 01:58 PM, Pádraig Brady wrote: Oh I see now. That was more apparent from your initial patch: http://lists.gnu.org/archive/html/bug-gnulib/2014-07/msg00038.html (which I didn't get due to recent GNU mailing list issues). I'll apply that. Regarding the patch I sent, I think the "

Re: "localename" functions suggest pure/const attribute

2014-07-10 Thread Pádraig Brady
On 07/10/2014 07:32 PM, Assaf Gordon wrote: > On 07/10/2014 01:58 PM, Pádraig Brady wrote: >> >> Oh I see now. That was more apparent from your initial patch: >> http://lists.gnu.org/archive/html/bug-gnulib/2014-07/msg00038.html >> (which I didn't get due to recent GNU mailing list issues). >> >> I

Re: [PATCH] announce-gen: avoid perl warnings

2014-07-10 Thread Pádraig Brady
On 07/10/2014 12:26 AM, Assaf Gordon wrote: > Hello, > > When running "./build-aux/announce-gen" without any parameters, there are > three "use of uninitialized value" warnings: > > $ ./build-aux/announce-gen > announce-gen: release type not specified > announce-gen: package name not specifi

"localename" functions suggest pure/const attribute

2014-07-10 Thread Assaf Gordon
Hello, Relating to a coreutil patch I previously sent, I'm using gnulib's "localename" module. Compiling it triggers two warnings (and errors with -Werror) about functions being candidates for pure/const attributes. I couldn't trigger it directly with gnulib, but it's reproducible with "coreu

Re: [PATCH] Sync up error.c with glibc

2014-07-10 Thread Siddhesh Poyarekar
Hi Paul, I wasn't subscribed to the list (I am now), so I only saw your response when I checked the archive today to see if my patch went through. I had posted the ChangeLog without the heading (since the date almost always changes on that), so here it is with one. Siddhesh 2014-07-10 Siddhesh

[PATCH] maint.mk: less syntax-check noise when SIGPIPE is ignored

2014-07-10 Thread Eric Blake
For a project with enough files, such as libvirt, vc-list-files can produce so much input that it can lead to SIGPIPE to earlier parts of a pipeline when later parts do a quick filter. Also, many buildbot environments (annoyingly) ignore SIGPIPE, which causes a number of tools to be rather chatty

Re: bug#17833: coreutils 8.22 df

2014-07-10 Thread Pádraig Brady
Apologies for resend. GNU mailers were having issues yesterday... On 06/25/2014 01:24 PM, Gabor Z. Papp wrote: > * Pádraig Brady : > > | > $ cat /etc/mtab > | > /dev/md0 / ext3 rw,errors=remount-ro 0 0 > | > proc /proc proc rw,relatime 0 0 > | > sysfs /sys sysfs rw,relatime 0 0 > | > tmpfs /dev

Re: [PATCH] gettext: update macros to version 0.19

2014-07-10 Thread Paul Eggert
Pádraig Brady wrote: Other have often expressed disdain for non readily available distro requiremnts like this. Should we consider reverting this until gettext-0.19 packages are easily available? The tradition in coreutils has been to use the latest stable version of the tools, and to not worr

Re: [PATCH] Add missing include of windows.h in nl_langinfo.c

2014-07-10 Thread Eric Blake
On 07/10/2014 09:21 AM, Eli Zaretskii wrote: >> Date: Wed, 09 Jul 2014 16:02:31 -0600 >> From: Eric Blake >> >>> Signed-off-by: Pavel Hrdina >>> --- >>> lib/nl_langinfo.c | 1 + >>> 1 file changed, 1 insertion(+) >> >> ACK, fix pushed. > > I believe this commit caused redundant inclusion of he

Re: [PATCH] Define macros for glibc

2014-07-10 Thread Paul Eggert
Thanks, that also looks good except it also needs a first ChangeLog line. Please install after fixing that.

Re: [PATCH] gettext: update macros to version 0.19

2014-07-10 Thread Paul Eggert
On 07/09/2014 04:49 PM, Pádraig Brady wrote: So I'm proposing the attached update for coreutils Looks good to me; thanks.

Re: gnulib "lock" module - test core dump

2014-07-10 Thread Paul Eggert
Thanks, it seems to be a compiler bug on Ubuntu: "#pragma weak" doesn't work, and this breaks gnulib's glthread module. For what it's worth I filed a bug report here: https://bugs.launchpad.net/ubuntu/+source/gcc-defaults/+bug/1340250 Are you expert enough in Ubuntuese to suggest a workaround