[PATCH] Add missing include of windows.h in nl_langinfo.c

2014-07-09 Thread Pavel Hrdina
The commit fcfce839 improved localization of names for week days and months, but the author forget to include windows.h in order to use 'GetACP ()'. Without this header file build using mingw fails with this error message: ../../../gnulib/lib/nl_langinfo.c: In function 'ctype_codeset': ../../../gn

Re: [PATCH] gettext: update macros to version 0.19

2014-07-09 Thread Pádraig Brady
On 06/11/2014 10:11 AM, Daiki Ueno wrote: > gettext-0.19 (and 0.19.1) has been released a while ago, this is the > update of the M4 macros. There's no difference between 0.19 and 0.19.1. Note this upgrades the gettext requirement for coreutils at least: $ git clone --depth=1 git://git.sv.gnu.o

Re: bug#17833: coreutils 8.22 df

2014-07-09 Thread Pádraig Brady
On 06/25/2014 01:24 PM, Gabor Z. Papp wrote: > * Pádraig Brady : > > | > $ cat /etc/mtab > | > /dev/md0 / ext3 rw,errors=remount-ro 0 0 > | > proc /proc proc rw,relatime 0 0 > | > sysfs /sys sysfs rw,relatime 0 0 > | > tmpfs /dev tmpfs rw,relatime,size=4k,mode=755 0 0 > | > devpts /dev/pts devpts

Re: [PATCH] Add missing include of windows.h in nl_langinfo.c

2014-07-09 Thread Eric Blake
On 07/09/2014 05:13 AM, Pavel Hrdina wrote: > The commit fcfce839 improved localization of names for week days > and months, but the author forget to include windows.h in order > to use 'GetACP ()'. Without this header file build using mingw > fails with this error message: > > ../../../gnulib/lib

Re: [PATCH] gettext: update macros to version 0.19

2014-07-09 Thread Daiki Ueno
Pádraig Brady writes: > make[2]: Entering directory `/home/padraig/git/coreutils/po' > *** error: gettext infrastructure mismatch: using a Makefile.in.in from > gettext version 0.18 but the autoconf macros are from gettext version 0.19 > make[2]: *** [check-macro-version] Error 1 > > I can

[PATCH] Sync up error.c with glibc

2014-07-09 Thread Siddhesh Poyarekar
Hi, This is a partial sync-up of error.c with glibc. The following changes went in: - Get rid of the INTUSE macro - Remove unused macro ALLOCA_LIMIT - Fix a potential buffer overflow in error_tail (sourceware bz #15672) - Fix a potential NULL dereference in strcmp There is a second part to this

Re: [PATCH] gettext: update macros to version 0.19

2014-07-09 Thread Pádraig Brady
On 07/09/2014 11:52 PM, Daiki Ueno wrote: > Pádraig Brady writes: > >> make[2]: Entering directory `/home/padraig/git/coreutils/po' >> *** error: gettext infrastructure mismatch: using a Makefile.in.in from >> gettext version 0.18 but the autoconf macros are from gettext version 0.19 >> ma

Re: [PATCH] gettext: update macros to version 0.19

2014-07-09 Thread Pádraig Brady
On 07/09/2014 08:55 PM, Paul Eggert wrote: > Pádraig Brady wrote: >> Other have often expressed disdain for non readily available >> distro requiremnts like this. Should we consider reverting >> this until gettext-0.19 packages are easily available? > > The tradition in coreutils has been to use t

Re: [PATCH] Sync up error.c with glibc

2014-07-09 Thread Paul Eggert
Siddhesh Poyarekar wrote: Does this look OK for gnulib? Sure, all it should need is a ChangeLog entry.

[PATCH] Define macros for glibc

2014-07-09 Thread Siddhesh Poyarekar
hi, This is the second patch as promised. This patch helps build error.c without warnings on glibc. I intend to merge the remaining differences into the glibc version of error.c Siddhesh * lib/error.c [_LIBC]: Define default macros for glibc. (print_errno_message) [defi

Re: bug#17833: coreutils 8.22 df

2014-07-09 Thread Pádraig Brady
On 07/09/2014 10:18 AM, Pádraig Brady wrote: > Apologies for resend. GNU mailers were having issues yesterday... > > On 06/25/2014 01:24 PM, Gabor Z. Papp wrote: >> * Pádraig Brady : >> >> | > $ cat /etc/mtab >> | > /dev/md0 / ext3 rw,errors=remount-ro 0 0 >> | > proc /proc proc rw,relatime 0 0 >

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #2465

2014-07-09 Thread Pádraig Brady
On 07/08/2014 03:38 PM, Eric Blake wrote: > [adding bug-gnulib] > > On 07/08/2014 08:05 AM, Guido Günther wrote: >> On Tue, Jul 08, 2014 at 03:49:02PM +0200, Jenkins CI wrote: >>> 0.43 prohibit_empty_lines_at_EOF >>> prohibit_error_without_use >>> grep: write error >>> grep: write error >>> /bin/s

Re: [PATCH] Sync up error.c with glibc

2014-07-09 Thread Paul Eggert
Thanks, that looks good, except that the Gnulib ChangeLog practice us to have a first ChangeLog line of the form "packagename: phrase" (see the ChangeLog file for examples). Please install after fixing that. I've added you to the gnulib group.

Re: [PATCH] gettext: update macros to version 0.19

2014-07-09 Thread Daiki Ueno
Pádraig Brady writes: > I'm not sure that removing the gettext dependencies is OK because > they're used to provide @LIB_INTL@ which was added to support solaris 2.[67] > http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=41dca647 Thanks for the pointer, I missed it. > they're used to pr

[PATCH] announce-gen: avoid perl warnings

2014-07-09 Thread Assaf Gordon
Hello, When running "./build-aux/announce-gen" without any parameters, there are three "use of uninitialized value" warnings: $ ./build-aux/announce-gen announce-gen: release type not specified announce-gen: package name not specified announce-gen: previous version string not specified anno

gnulib "lock" module - test core dump

2014-07-09 Thread Assaf Gordon
Hello, While trying to test another gnulib module (localename), the unit tests failed with a coredump in "test-lock" (related to threading?) . I'm not trying to use threads, but it prevents the 'localename' test from completing. If this is some artifact on my system, I apologize for the noise.