Re: error.c triggers -Wformat-extra-args

2014-06-26 Thread Paul Eggert
Daniel E. Macks wrote: if (file_name != NULL) fprintf (stderr, "%s:%d: ", file_name, line_number) else fprintf (stderr, " "); Isn't that bigger and slower than the code it would replace?

Define DEBUG by default in mktime.c

2014-06-26 Thread Siddhesh Poyarekar
Hi, The DEBUG macro in mktime.c is not defined, but the checks on that macro are as if it is. Instead of commenting out the definition of DEBUG, define it to 0 by default and adjust the comment to reflect that debugging needs the macro to be set to 1. Siddhesh * lib/mktime.c: Define DEB

Re: Define DEBUG by default in mktime.c

2014-06-26 Thread Eric Blake
On 06/26/2014 12:02 PM, Siddhesh Poyarekar wrote: > Hi, > > The DEBUG macro in mktime.c is not defined, but the checks on that > macro are as if it is. Instead of commenting out the definition of > DEBUG, define it to 0 by default and adjust the comment to reflect > that debugging needs the macro