Re: work in progress: [PATCH 0/2+] open_memstream

Eric Blake wrote: > The libvirt project would be very interested in using open_memstream, > since it is now part of POSIX 2008. Hi, I realize this thread for open_memstream support in gnulib is now several years old. Just wondering why it was never completed/merged into gnulib... I assume it's

Re: work in progress: [PATCH 0/2+] open_memstream

On 02/07/2013 02:54 AM, Eric Wong wrote: > Eric Blake wrote: >> The libvirt project would be very interested in using open_memstream, >> since it is now part of POSIX 2008. > > Hi, I realize this thread for open_memstream support in gnulib is now > several years old. Just wondering why it was ne

Re: PATCH: numerous warnings from gnulib header files.

On 02/06/2013 11:14 PM, Paul Eggert wrote: > In > on 02/06/2013 12:13 AM, John Darrington wrote: > >> ./SOURCE/gl/xalloc.h:176: error: no previous prototype for 'x2nrealloc' > > I looked into this, and apparently it's a bug in G

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

The substance of the change seems fine. It needs a proper ChangeLog entry. See the glibc wiki for full instructions on posting patches. > + struct stat64 st; > + int r = fd >= 0 ? fstat64(fd, &st) : stat64(name, &st); Put space before paren in those calls. It's shorter and more common to inver

Re: work in progress: [PATCH 0/2+] open_memstream

Eric Blake wrote: > open_memstream still sounds like a nice project for anyone interested in > implementing, though. Thanks for the reply, I've also been able to cope without it. Hopefully somebody has spare cycles pick this up (or more platforms can just support it natively).

Re: secure_getenv is broken on FreeBSD.

onsdag den 6 februari 2013 klockan 22:31 skrev Paul Eggert detta: > On 02/06/2013 05:10 PM, Mats Erik Andersson wrote: > > Does not suffice! Same error as before > > I assume you tried it by hand? Yes. Checking the sequence once more: * Inetutils with gnulib-7517e2 builds on FreeBSD-9.0 s

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

Roland McGrath wrote: > The substance of the change seems fine. It needs a proper ChangeLog entry. > See the glibc wiki for full instructions on posting patches. > > > + struct stat64 st; > > + int r = fd >= 0 ? fstat64(fd, &st) : stat64(name, &st); > > Put space before paren in those calls.

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

The patch itself now looks fine to me. The log entry is inadequate. It needs to mention each file and function touched and say what was done there. "Update caller." is sufficient text for a function to which the only change was trivial argument reordering or whatnot. But in most of these cases,

Re: secure_getenv is broken on FreeBSD.

On 02/07/2013 02:28 PM, Mats Erik Andersson wrote: > * Inetutils with gnulib-f65962 is broken on FreeBSD-9.0 > since "tempname" is making "secure_getenv" mandatory, > against my will! Why against your will? Isn't it better for tempname to avoid insecure usage? But I do see that we can

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

Roland McGrath wrote: > The patch itself now looks fine to me. The log entry is inadequate. > It needs to mention each file and function touched and say what was > done there. "Update caller." is sufficient text for a function to > which the only change was trivial argument reordering or whatnot

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

That looks fine. > * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs): > Pass fd to __internal_statvfs instead of calling fstat64. > * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64): > Pass fd to __internal_statvfs64 instead of calling fstat64. In a case like this, it'

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

Roland McGrath wrote: > That looks fine. > > > * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs): > > Pass fd to __internal_statvfs instead of calling fstat64. > > * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64): > > Pass fd to __internal_statvfs64 instead of calling fstat64

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

> Roland McGrath wrote: > > That looks fine. > > > > > * sysdeps/unix/sysv/linux/fstatvfs.c (fstatvfs): > > > Pass fd to __internal_statvfs instead of calling fstat64. > > > * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64): > > > Pass fd to __internal_statvfs64 instead of calling f

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

Roland McGrath wrote: > Oh, I didn't notice they weren't identical. You're right that it shouldn't > use plain "Likewise." then. But you could write: > > * sysdeps/unix/sysv/linux/fstatvfs64.c (__fstatvfs64): > Likewise for __internal_statvfs64. > > > I'm not fan of signing into we

Re: secure_getenv is broken on FreeBSD.

On 02/07/2013 02:28 PM, Mats Erik Andersson wrote: > ./unistd.h:548: error: expected '=', ',', ';', 'asm' or > '__attribute__' before 'extern' Most likely this has to do with something before the declaration in question, not being properly terminated or something like that. It