Re: How to test if I've got openpty?

2013-01-31 Thread Reuben Thomas
On 30 January 2013 17:02, Reuben Thomas wrote: > On 30 January 2013 15:25, Reuben Thomas wrote: > >> I've included the openpty module in a project, and I see that it doesn't >> work on all platforms. I assumed that I should test HAVE_OPENPTY to see if >> I got it, but HAVE_OPENPTY is undefined i

Re: How to test if I've got openpty?

2013-01-31 Thread Paul Eggert
On 01/31/13 05:09, Reuben Thomas wrote: > Looks to me as though the "fi" should come immediately after > "REPLACE_OPENPTY=1", not at the end of the stanza. Does that seem right? > Close, but not quite right, as the containing 'if' checks only that openpty has been declared, not that it exists.

Re: How to test if I've got openpty?

2013-01-31 Thread Reuben Thomas
On 31 January 2013 17:45, Paul Eggert wrote: > On 01/31/13 05:09, Reuben Thomas wrote: > > Looks to me as though the "fi" should come immediately after > "REPLACE_OPENPTY=1", not at the end of the stanza. Does that seem right? > > > > Close, but not quite right, as the containing 'if' > checks on

Re: How to test if I've got openpty?

2013-01-31 Thread Reuben Thomas
Once more with feeling. This time, slightly simplified code with the bogus "end" removed, and I've tested it, although only on GNU/Linux: if test $ac_cv_have_decl_openpty = yes; then ... [gl_cv_func_openpty_const=yes], [gl_cv_func_openpty_const=no]) ]) fi if test $gl_cv_func_

Re: How to test if I've got openpty?

2013-01-31 Thread Paul Eggert
On 01/31/13 12:32, Reuben Thomas wrote: > Once more with feeling. Thanks, that looks good; I pushed it into the master.

Re: How to test if I've got openpty?

2013-01-31 Thread Reuben Thomas
On 31 January 2013 21:56, Paul Eggert wrote: > On 01/31/13 12:32, Reuben Thomas wrote: > > Once more with feeling. > > Thanks, that looks good; I pushed it into the master. > Thanks very much! Onwards and upwards… -- http://rrt.sc3d.org

Re: Fwd: [patch #6107] Patch to add transparent decompression

2013-01-31 Thread Reuben Thomas
Ping! Any opinion on this (comment-only) patch? (Sorry about the trailing whitespace in the last added line, which I just noticed.) On 27 January 2013 23:44, Reuben Thomas wrote: > On 27 January 2013 19:47, Paul Eggert wrote: > >> On 01/27/2013 10:13 AM, Reuben Thomas wrote: >> > Perhaps it wo

Re: Test for regex module hangs

2013-01-31 Thread Reuben Thomas
By the way, until this bug is fixed, a reasonable workaround is to pass --with-included-regex to configure. On 30 January 2013 13:50, Reuben Thomas wrote: > When running the test for working re_compile_pattern, I get a hang; > attaching to the process gives me: > > (gdb) where > #0 __lll_lock_

Re: Test for regex module hangs

2013-01-31 Thread Eric Blake
On 01/31/2013 03:13 PM, Reuben Thomas wrote: > By the way, until this bug is fixed, a reasonable workaround is to pass > --with-included-regex to configure. > > > On 30 January 2013 13:50, Reuben Thomas wrote: > >> When running the test for working re_compile_pattern, I get a hang; >> attaching

Re: Test for regex module hangs

2013-01-31 Thread Eric Blake
On 01/31/2013 03:54 PM, Eric Blake wrote: > On 01/31/2013 03:13 PM, Reuben Thomas wrote: >> By the way, until this bug is fixed, a reasonable workaround is to pass >> --with-included-regex to configure. >> >> >> On 30 January 2013 13:50, Reuben Thomas wrote: >> >>> When running the test for workin

[PATCH] avoid stat/fstat in statvfs/fstatvfs

2013-01-31 Thread Eric Wong
It turns out this problem was not specific to eglibc or Debian. glibc has the same issue with stat() being called in statvfs() on Linux 2.6.36+ Eric Wong wrote: > Paul Eggert wrote: > > On 01/29/2013 06:44 PM, Eric Wong wrote: > > > eglibc on Debian is only configured to only use features availa

[PATCH 1/2] regex: fix off-by-one error in configure test

2013-01-31 Thread Paul Eggert
* m4/regex.m4 (gl_REGEX): Test should return 21, not 20. --- ChangeLog | 5 + m4/regex.m4 | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 74dad7e..51346e4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-01-31 Paul Eggert + +

[PATCH 2/2] regex-tests: new module

2013-01-31 Thread Paul Eggert
* modules/regex-tests, tests/test-regex.c: New files. --- ChangeLog | 3 + modules/regex-tests | 11 tests/test-regex.c | 185 3 files changed, 199 insertions(+) create mode 100644 modules/regex-tests create mode 100644 test