Re: xalloc: missing prototype

2012-12-07 Thread Akim Demaille
Hi Paul, Le 6 déc. 2012 à 18:48, Paul Eggert a écrit : > In file included from ../../../lib/mbschr.c:23:0: > ../../../lib/mbschr.c: At top level: > ../../../lib/mbuiter.h:201:181: warning: '__inline_memset_chk' is static but > used in inline function 'mbuiter_multi_copy' which is not static [en

Re: xalloc: missing prototype

2012-12-07 Thread Akim Demaille
Le 7 déc. 2012 à 01:18, Jim Meyering a écrit : > Hi Akim, > > I've turned off -Wcast-qual warning for coreutils, grep, diffutils, etc. > For us, that seems to be the best route, since we try hard not to > add new casts (so there's little risk of introducing new violations), > and since the few

Re: xalloc: missing prototype

2012-12-07 Thread Akim Demaille
Le 5 déc. 2012 à 17:19, Eric Blake a écrit : > What I have instead done in libvirt to allow compilation with older gcc > is the following: > ># Gnulib uses '#pragma GCC diagnostic push' to silence some ># warnings, but older gcc doesn't support this. >AC_CACHE_CHECK([whether pragma

Re: [sharutils-4.11.1] Compilation warnings

2012-12-07 Thread Paul Eggert
On 12/06/2012 08:53 PM, Bruce Korb wrote: > can GCC decide that the result of (x) is not really used and still complain? GCC is allowed to generate whatever warnings it likes. It can warn whenever you have a program that uses the letter 'a', say. But it is required to generate code that does what

Re: xalloc: missing prototype

2012-12-07 Thread Paul Eggert
On 12/07/2012 12:45 AM, Akim Demaille wrote: > I don't understand > why GCC does not accept that inline functions call static > functions that are inline too. The C Standard requires a diagnostic here, as the rule that you quoted is a constraint. So this is really more a question for the develop

Re: ASCII_ONLY?

2012-12-07 Thread Paul Eggert
On 12/06/12 21:44, Ben Pfaff wrote: > But I don't see any actual uses of this macro. What is the > intent? My guess is was to distinguish between hosts where the C locale supports only ASCII characters, and hosts where the C locale is UTF-8. If the macro isn't being used now, it should be safe t

[PATCH v2] mountlist: additional dummy FS names for Linux

2012-12-07 Thread Eric Wong
* lib/mountlist.c (ME_DUMMY_0): additional dummy FS names for Linux systems. - "devpts" PTY slave filesystem - "fusectl" control filesystem for FUSE - "mqueue" enumerates POSIX message queues - "rpc_pipefs" kernel <-> userspace bridge for NFS - "sysfs" is for exporting kernel objects

Re: [PATCH v2] mountlist: additional dummy FS names for Linux

2012-12-07 Thread Jim Meyering
Eric Wong wrote: > * lib/mountlist.c (ME_DUMMY_0): > additional dummy FS names for Linux systems. > - "devpts" PTY slave filesystem > - "fusectl" control filesystem for FUSE > - "mqueue" enumerates POSIX message queues > - "rpc_pipefs" kernel <-> userspace bridge for NFS > - "sysfs" is

Re: [PATCH v2] mountlist: additional dummy FS names for Linux

2012-12-07 Thread Eric Wong
Jim Meyering wrote: > Eric Wong wrote: > > * lib/mountlist.c (ME_DUMMY_0): > > additional dummy FS names for Linux systems. > > - "devpts" PTY slave filesystem > > - "fusectl" control filesystem for FUSE > > - "mqueue" enumerates POSIX message queues > > - "rpc_pipefs" kernel <-> userspa

Re: ASCII_ONLY?

2012-12-07 Thread Bruno Haible
Hi Ben, > gnulib has three definitions of ASCII_ONLY in files that #include > "vasnprintf.c": > > lib/unistdio/u16-vasnprintf.c:#define ASCII_ONLY 1 > lib/unistdio/u32-vasnprintf.c:#define ASCII_ONLY 1 > lib/unistdio/u8-vasnprintf.c:#define ASCII_ONLY 1 > > But I don't see any actual uses of thi

Re: ASCII_ONLY?

2012-12-07 Thread Paul Eggert
On 12/07/2012 06:40 PM, Bruno Haible wrote: > I would be grateful to you if you could commit the obvious fix. Done, thanks.

Re: ASCII_ONLY?

2012-12-07 Thread Ben Pfaff
Bruno Haible writes: >> gnulib has three definitions of ASCII_ONLY in files that #include >> "vasnprintf.c": >> >> lib/unistdio/u16-vasnprintf.c:#define ASCII_ONLY 1 >> lib/unistdio/u32-vasnprintf.c:#define ASCII_ONLY 1 >> lib/unistdio/u8-vasnprintf.c:#define ASCII_ONLY 1 >> >> But I don't see