Re: [PATCH 4/4] Add a test suite for the sethostname module

2011-12-06 Thread Ben Walton
Excerpts from Bruno Haible's message of Sun Dec 04 13:45:51 -0500 2011: Hi Bruno, > You have been misunderstanding how the C and C++ macro expansion > process works. The only place where a space before the open > parenthesis is not allowed is in the *definition* of a macro with > arguments, like

./lib/getopt.h:197: error: redefinition of `struct option'

2011-12-06 Thread Mark R Bannister
Hi, I'm banging my head against a wall here trying to port nss_db to Solaris 10. It includes a source file called makedb.c that requires argp.h and error.h. Incidentally it also requires a Berkeley database which I have in /opt/csw/bdb48/include/db.h. I thought the easiest thing was to use gnul

Re: ./lib/getopt.h:197: error: redefinition of `struct option'

2011-12-06 Thread Eric Blake
On 12/06/2011 04:58 AM, Mark R Bannister wrote: > Hi, > > I'm banging my head against a wall here trying to port nss_db to Solaris 10. > > It includes a source file called makedb.c that requires argp.h and error.h. > Incidentally it also requires a Berkeley database which I have in > /opt/csw/bd

Re: ./lib/getopt.h:197: error: redefinition of `struct option'

2011-12-06 Thread Mark R Bannister
On Tue 06/12/11 13:56 , Eric Blake ebl...@redhat.com sent: > There's your problem. You have to #include prior to any > other include files, if you want gnulib's getopt replacements to work. Thanks Eric, that worked. May I suggest that gnulib-tool is improved to check that a) config.h is being

restrictive umask vs gnupload

2011-12-06 Thread Jim Meyering
I use a umask of 077. That is rather irregular (022 is more common), but for a good reason. It might have saved me from exploit via at least one flaw (the automake "dist" abuse CVE). Anyhow, many tools fail to account for the possibility of a restrictive umask, and gnupload is one of them. If I'm

Re: restrictive umask vs gnupload

2011-12-06 Thread Bruce Korb
On 12/06/11 12:37, Jim Meyering wrote: I use a umask of 077. That is rather irregular Opinions, preferences, "get over it!" ;-) gnupload is responsible for delivering the files to GNU in a workable fashion regardless of your personal preferences. What it ought to really do is check for go+r

Re: restrictive umask vs gnupload

2011-12-06 Thread Eric Blake
On 12/06/2011 01:37 PM, Jim Meyering wrote: > I have a few ways to avoid that: > - change gnupload to set umask 022 > - change gnupload to run chmod go+r on each uploaded file (may not > always be appropriate?) > I'd prefer to change gnupload. Agreed. Either of the two changes I highli