Re: libidn 1.23

2011-11-27 Thread Bruno Haible
Simon Josefsson wrote: > This also came up for Libidn, it is using the latest gnulib. > > > * mingw with gcc > > > > Fails already in the gnulib tests: > > > > FAIL: test-binary-io.sh > > I have not seen this test fail before. I'm seeing this test failure only in the libidn and gsasl builds, not

[PATCH] mark functions with const and pure attributes

2011-11-27 Thread Jim Meyering
I began this months ago and then forgot about it. Luckily I'd marked a change in coreutils' configure.ac with FIXME, and that served as a reminder. I have just gone back to finish the job. This change adds the attributes only to those functions that are compiled via coreutils. There are certainly

Re: [PATCH] mark functions with const and pure attributes

2011-11-27 Thread Bruno Haible
Hi Jim, > --- a/lib/quotearg.c > +++ b/lib/quotearg.c > @@ -17,6 +17,11 @@ > > /* Written by Paul Eggert */ > > +/* Without this pragma, gcc 4.7.0 2024 mistakenly suggests that > + the quoting_options_from_style function might be candidate for > + attribute 'pure' */ > +# pragma GCC d

Re: [PATCH] getcwd-lgpl: fix m4 to match relaxed test for BSD

2011-11-27 Thread Bruno Haible
Hi Jim, Getting back to this issue from last Monday: > > If we fix Eric's typo, REPLACE_GETCWD will come out as 0 on OpenBSD and > > NetBSD. > > Do you know how that happens, given the corrected code? It's because of the details in m4/getcwd-abort-bug.m4. > The part that is surprising is that

getcwd on MSVC 9

2011-11-27 Thread Bruno Haible
On MSVC 9, a testdir for the 'getcwd' module yields these link errors: libgnu.a(getcwd.obj) : error LNK2019: reference to unresolved symbol "_rewinddir" in function "_rpl_getcwd". libgnu.a(getcwd.obj) : error LNK2019: reference to unresolved symbol "_readdir" in function "_rpl_getcwd". libgnu.a(

Re: warning options

2011-11-27 Thread Bruno Haible
Hi Paul, > > "gcc -Wall" produces a warning for > > > > int f () { return 0; } > > int main (void) { return f (1); } > > That's weird. It doesn't produce a warning for me, for either > GCC 4.6.1 (bundled with Fedora 15) or GCC 4.6.2 (which I built): > > $ cat t.c > int f () { return 0; } >

Re: [PATCH] mark functions with const and pure attributes

2011-11-27 Thread Jim Meyering
Bruno Haible wrote: >> --- a/lib/quotearg.c >> +++ b/lib/quotearg.c >> @@ -17,6 +17,11 @@ >> >> /* Written by Paul Eggert */ >> >> +/* Without this pragma, gcc 4.7.0 2024 mistakenly suggests that >> + the quoting_options_from_style function might be candidate for >> + attribute 'pure' */

Re: warning options

2011-11-27 Thread Paul Eggert
On 11/27/11 16:13, Bruno Haible wrote: > Why does this warning only appear on openSuSE 11.4 ?? Sorry, I don't know. > The name mangling of the symbol 'main' is the same, > regardless of whether it's defined to take 0 or 2 arguments. (We're in C here, > not in C++.) "main" is a special case and