Re: [PATCH] maint.mk: don't maintain a second build-aux variable.

2011-10-25 Thread Jim Meyering
[please configure your mail client to stop including both plain and html versions of each message] Gary V. Vaughan wrote: > To what advantage over factoring out the duplication entirely at the > source of the problem with the patch I submitted? Not breaking some project's existing set-up when th

Re: waitpid and warn_unused_result

2011-10-25 Thread Jim Meyering
Eric Blake wrote: > Any objections to making the gnulib apply the gcc > warn_unused_result attribute to waitpid(), even though glibc does not > (yet) do likewise? After all, if you fail to check for failures on > this syscall (particularly EINTR failures, where you should normally > repeat the wa

Re: [PATCH] maint.mk: don't maintain a second build-aux variable.

2011-10-25 Thread Gary V. Vaughan
Hi Jim, On 25 Oct 2011, at 00:37, Jim Meyering wrote: > Gary V. Vaughan wrote: >> >> _build-aux = libltdl/build-aux > > Wouldn't that break things for those who customize build_aux? Ah, I see what you mean now (will it break for clients who are customizing with build_aux already). No, I don't

Re: [PATCH] maint.mk: don't maintain a second build-aux variable.

2011-10-25 Thread Gary V. Vaughan
Hi Jim, Looks like our messages crossed, please disregard my last reply. On 25 Oct 2011, at 15:05, Jim Meyering wrote: > [please configure your mail client to stop including both plain > and html versions of each message] If you know of an option to do that on the iPad with iOS5 mobile mail I'll

Re: ENODATA

2011-10-25 Thread Bruno Haible
Hi Jim, > The gnulib update induced a new (coreutils-specific) syntax-check failure: > > src/system.h:# define ENODATA (-1) > make[3]: *** [sc_prohibit_always-defined_macros] Error 1 > > because gnulib now defines that symbol, so I have also removed > that definition from coreutils: > >

Re: ENODATA

2011-10-25 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> The gnulib update induced a new (coreutils-specific) syntax-check failure: >> >> src/system.h:# define ENODATA (-1) >> make[3]: *** [sc_prohibit_always-defined_macros] Error 1 >> >> because gnulib now defines that symbol, so I have also removed >> that de

Re: ENODATA

2011-10-25 Thread Jim Meyering
Jim Meyering wrote: > Bruno Haible wrote: > >> Hi Jim, >> >>> The gnulib update induced a new (coreutils-specific) syntax-check failure: >>> >>> src/system.h:# define ENODATA (-1) >>> make[3]: *** [sc_prohibit_always-defined_macros] Error 1 >>> >>> because gnulib now defines that symbol, s

sc_prohibit_stddef_without_use works incorrectly

2011-10-25 Thread Alfred M. Szmidt
The following syntax-check is broken, _stddef_syms_re = NULL|offsetof|ptrdiff_t|size_t|wchar_t # Prohibit the inclusion of stddef.h without an actual use. sc_prohibit_stddef_without_use: h='stddef.h'\ re='\<($(_stddef_sym

Re: sc_prohibit_stddef_without_use works incorrectly

2011-10-25 Thread Jim Meyering
Alfred M. Szmidt wrote: > The following syntax-check is broken, > >_stddef_syms_re = NULL|offsetof|ptrdiff_t|size_t|wchar_t ># Prohibit the inclusion of stddef.h without an actual use. >sc_prohibit_stddef_without_use: > h='stddef.h'

Re: sc_prohibit_stddef_without_use works incorrectly

2011-10-25 Thread Alfred M. Szmidt
Thanks Jim!

Re: [libvirt] [PATCH] build: use gnulib fdatasync

2011-10-25 Thread Eric Blake
[adding bug-gnulib] On 10/25/2011 03:44 AM, Jiri Denemark wrote: On Mon, Oct 24, 2011 at 16:44:49 -0600, Eric Blake wrote: Commit 1726a73 hacked around MacOS' lack of fdatasync, since gnulib did not have it at the time. But now that we use newer gnulib, we can avoid the hack. * bootstrap.conf

Re: Failed test on Solaris 8 Sparc

2011-10-25 Thread Dagobert Michelsen
Hi Simon, Am 21.04.2010 um 08:36 schrieb Simon Josefsson: > Dagobert Michelsen writes: >> Am 31.03.2009 um 12:23 schrieb Simon Josefsson: >>> Dagobert Michelsen writes: I am getting a test failure on Solaris 8 Sparc w/Sun Studio 11: >>> >>> Hi! Thanks for the report. The problem is actual

Re: [libvirt] [PATCH] build: use gnulib fdatasync

2011-10-25 Thread Pádraig Brady
On 10/25/2011 04:32 PM, Eric Blake wrote: > [adding bug-gnulib] > > On 10/25/2011 03:44 AM, Jiri Denemark wrote: >> On Mon, Oct 24, 2011 at 16:44:49 -0600, Eric Blake wrote: >>> Commit 1726a73 hacked around MacOS' lack of fdatasync, since >>> gnulib did not have it at the time. But now that we us

Re: [libvirt] [PATCH] build: use gnulib fdatasync

2011-10-25 Thread Daniel P. Berrange
On Tue, Oct 25, 2011 at 09:32:13AM -0600, Eric Blake wrote: > [adding bug-gnulib] > > On 10/25/2011 03:44 AM, Jiri Denemark wrote: > >On Mon, Oct 24, 2011 at 16:44:49 -0600, Eric Blake wrote: > >>Commit 1726a73 hacked around MacOS' lack of fdatasync, since > >>gnulib did not have it at the time.

Re: [libvirt] [PATCH] build: use gnulib fdatasync

2011-10-25 Thread Pádraig Brady
On 10/25/2011 04:50 PM, Daniel P. Berrange wrote: > On Tue, Oct 25, 2011 at 09:32:13AM -0600, Eric Blake wrote: >> [adding bug-gnulib] >> >> On 10/25/2011 03:44 AM, Jiri Denemark wrote: >>> On Mon, Oct 24, 2011 at 16:44:49 -0600, Eric Blake wrote: Commit 1726a73 hacked around MacOS' lack of fd

Re: [libvirt] [PATCH] build: use gnulib fdatasync

2011-10-25 Thread Daniel P. Berrange
On Tue, Oct 25, 2011 at 05:12:57PM +0100, Pádraig Brady wrote: > On 10/25/2011 04:50 PM, Daniel P. Berrange wrote: > > On Tue, Oct 25, 2011 at 09:32:13AM -0600, Eric Blake wrote: > >> [adding bug-gnulib] > >> > >> On 10/25/2011 03:44 AM, Jiri Denemark wrote: > >>> On Mon, Oct 24, 2011 at 16:44:49 -