Bruno Haible wrote:
> I've just stumbled again across these failures on FreeBSD 6.4.
>
>> FreeBSD 6.4:
>>
>> test-rename.h:342: assertion failed
>> Abort trap (core dumped)
>> FAIL: test-rename
>>
>> test-rename.h:342: assertion failed
>> Abort trap (core dumped)
>> FAIL: test-renameat
>
> Jim, you
On Mon, Sep 19, 2011 at 7:34 AM, Paul Eggert wrote:
> On 09/18/11 01:36, Bruno Haible wrote:
>
> This patch protects the dup2() calls in gnulib.
>
> This change has some problems with GNU Emacs, and I suspect there will
> be similar problems with printf, close, etc. so let's try to get see
> if w
Paul Eggert wrote:
> @@ -73,9 +79,6 @@ rpl_stat (char const *name, struct stat *st)
> #if REPLACE_FUNC_STAT_DIR
>/* The only known systems where REPLACE_FUNC_STAT_DIR is needed also
> have a constant PATH_MAX. */
> -# ifndef PATH_MAX
> -# error "Please port this replacement to your pla
Paul Eggert wrote:
> On 09/18/11 12:11, Jim Meyering wrote:
>> Since kFreeBSD also lacks /proc/self/fd support, this has the
>> drawback of making getcwd non-thread-safe, and making it possible
>> that getcwd will exit under some unusual conditions. But neither
>> of those matter to coreut
On 09/19/11 02:14, Bruno Haible wrote:
> The comment "The only known systems ..." is now out of place. How about moving
> it together with the 3 #ifndef/#error/#endif lines?
Yes, thanks, I did that.
Jim Meyering wrote:
> Martin von Gagern wrote:
> ...
> 5. sc_prohibit_always-defined_macros reports missing files:
>
> The sc_prohibit_always-defined_macros check will cause error messages
> about missing files to be emitted if elements from the gl_other_headers_
> list are not
On 09/18/2011 11:19 AM, Jim Meyering wrote:
Eric Blake wrote:
+ date: accept 'hence' as opposite of 'ago'
+ * lib/parse-datetime.y (relative_time_table): Add 'hence'.
+ * tests/test-parse-datetime.c (main): Enhance test.
+ Suggested by Jesse Wilson.
I like the addition,
On 09/18/2011 09:59 PM, Paul Eggert wrote:
* lib/utimens.c (fdutimens): Don't invoke dup2; it's not needed
to work around the Linux kernel bug.
* modules/utimens (Depends-on): Remove dup2.
---
ChangeLog |7 +++
lib/utimens.c | 13 -
modules/utimens |1 -
3 f
FYI, this syncs this change from coreutils' init.sh:
>From c37da522c67143c74f2a6ddc25dda4b87a0a5032 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 19 Sep 2011 19:27:53 +0200
Subject: [PATCH] tests: use printf, not echo in init.sh's warn_ function
* tests/init.sh (warn_): Use printf, not
Hello,
Building a full gnulib bootstrap failed on CentOS 5:
depbase=`echo test-sched.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1
-I. -I. -I.. -I./.. -I../gllib -I./../gllib -g -O2 -Wall -MT
test-sched.o -MD -MP -MF $depbase.Tp
On 09/19/11 10:11, Eric Blake wrote:
> it was only negative fds where the kernel/glibc issue was leaking through
Yes, more specifically, it was only the case where
fd == AT_FDCWD.
On 09/19/2011 12:40 PM, Tom G. Christensen wrote:
Hello,
Building a full gnulib bootstrap failed on CentOS 5:
depbase=`echo test-sched.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1 -I. -I.
-I.. -I./.. -I../gllib -I./../gllib -g -O2 -Wall -M
Hi Paul,
> This patch protects the dup2() calls in gnulib.
>
> ... I suspect there will be similar problems with printf, close, etc.
Yes, I suspect the idiom used in dup2.c will be used ca. 20 times in gnulib.
> I can't achieve this omission by invoking
> gnulib-tool --avoid=msvc-inval, becau
Hi Paul,
> I also have some qualms about C macros that expand to series of tokens
> with unbalanced braces.
The approach has the big advantage that you can step through the code in a
debugger, and that the entire block expands into a single statement.
(The original approach from gdb-7.2/gdb/excep
> The approach has the big advantage that you can step through the code in a
> debugger,
And that syntax coloring editors (like vim, emacs, kate) don't get confused.
> and that the entire block expands into a single statement.
I need to realize this promise:
2011-09-19 Bruno Haible
Bastien ROUCARIES wrote:
> why not
> #else
> # define TRY_MSVC_INVAL if (1)
> # define CATCH_MSVC_INVAL else do
> # define DONE_MSVC_INVAL while(0)
> #endif
This would be needed if we wanted the user to write
DONE_MSVC_INVAL;
instead of
DONE_MSVC_INVAL
But what's the point of that s
Eric Blake wrote:
> Thanks for the report. This is due to a bug in the glibc headers in use
> by CentOS 5, and we should be able to fix our replacement to
> work around that glibc bug (which has since been fixed in upstream glibc).
Yes. I'm applying this workaround.
2011-09-19 Bruno Haible
On 09/19/11 14:37, Bruno Haible wrote:
>DONE_MSVC_INVAL
>
> But what's the point of that semicolon?
I don't know what Bastien's point was, but one problem that I'm having
with those macros is that Emacs doesn't indent code properly when
those macros are used. For example, if I put the cursor
On 09/19/11 14:37, Bruno Haible wrote:
> Is this code (with a #if and two extra functions) really easier to understand
> than what we have in lib/dup2.c now?
I find it easier to understand, because I can safely ignore
the stuff that's inside the "#if MSVC ..." brackets.
On 09/19/11 14:15, Bruno H
On 09/19/2011 04:37 PM, Paul Eggert wrote:
For example, it's not reasonable to replace code like this:
return dup2 (a, b);
with code like this:
TRY_MSVC_INVAL
{
return dup2 (a, b);
}
CATCH_MSVC_INVAL
{
errno = EBADF;
return -1;
}
DONE_MSVC_I
On 09/19/11 14:15, Bruno Haible wrote:
> I hope you can choose among these three solutions.
How about a 4th solution? It's modeled on your b.2)
c) You store no additional file in Emacs' VCS. Just one addition to
configure.ac or aclocal.m4:
AH_VERBATIM([
#define TRY_MSVC
Paul Eggert wrote:
> Emacs doesn't indent code properly when
> those macros are used. For example, if I put the cursor at the start
> of the next line and type TAB, Emacs indents the next line by two more
> than it should. If I put a semicolon after DONE_MSVC_INVAL, Emacs
> indents properly.
Ind
22 matches
Mail list logo
