Re: Incorrect detection of member sa_len.

2011-04-10 Thread Ralf Wildenhues
Hello, * Mats E Andersson wrote on Sat, Apr 09, 2011 at 02:23:27PM CEST: > the m4 helper in `m4/getaddrinfo.m4` is incorrectly implementing > a test whether `struct sockaddr` contains a member `sa_len`. > > Any BSD system must include `` in order for the test > code to deliver a trustworthy answe

Re: [PATCH] maint: change "can not" to "cannot"

2011-04-10 Thread Jim Meyering
Paul Eggert wrote: > Thanks. I pushed another one too, which I caught with: > >word1=$1 >word2=$2 >shift >shift > >export LC_ALL=C >gawk ' > BEGIN { IGNORECASE = 1 } > /^[[:space:]]*'"$word2"'([^[:alnum:]_]|$)/ { >if (NR == nr1 + 1 && FILENAME == filename1

Re: [PATCH] maint: change "can not" to "cannot"

2011-04-10 Thread Jim Meyering
Jim Meyering wrote: > Here's perl-based gorp that's uncovered a few more. > The tricky part was to get the line numbers while in perl's > slurp-entire-file mode (-0777). > > git ls-files|xargs perl -0777 -n \ > -e 'while (/\b(a|then?|if|but|or|and|to)\s+\1\b/gms)' \ > -e '{$n=($` =~ tr/\n/\n/ +

Re: Incorrect detection of member sa_len.

2011-04-10 Thread Bruno Haible
Hello Ralf, > > Any BSD system must include `` in order for the test > > code to deliver a trustworthy answer. As always this header must > > precede `` on any BSD system. > > The test should be using AC_INCLUDES_DEFAULT, no? That takes care of > sys/types.h: > > AC_CHECK_MEMBERS([struct sockadd

restrict qualifier and C++.

2011-04-10 Thread Nikos Mavrogiannopoulos
Attached is a patch that fixes the time.h compilation under C++. regards, Nikos >From 6bdd56fbd4ecad4b00d3bbd76dd343a52622a876 Mon Sep 17 00:00:00 2001 From: Nikos Mavrogiannopoulos Date: Sun, 10 Apr 2011 09:51:58 +0200 Subject: [PATCH] Fix compilation issue under C++ due to restrict C qualifier.

Re: restrict qualifier and C++.

2011-04-10 Thread Paul Eggert
On 04/10/2011 12:53 AM, Nikos Mavrogiannopoulos wrote: > Attached is a patch that fixes the time.h compilation under C++. This shouldn't be needed, since gl_HEADER_TIME_H requires gl_HEADER_TIME_H_BODY, which requires AC_C_RESTRICT, which is supposed to arrange for 'restrict' to be #define'd to no

Re: restrict qualifier and C++.

2011-04-10 Thread Nikos Mavrogiannopoulos
On 04/10/2011 11:54 PM, Paul Eggert wrote: > On 04/10/2011 12:53 AM, Nikos Mavrogiannopoulos wrote: >> Attached is a patch that fixes the time.h compilation under C++. > > This shouldn't be needed, since gl_HEADER_TIME_H requires > gl_HEADER_TIME_H_BODY, which requires AC_C_RESTRICT, which > is su

Re: restrict qualifier and C++.

2011-04-10 Thread Paul Eggert
On 04/10/2011 03:07 PM, Nikos Mavrogiannopoulos wrote: > As I understand it AC_C_RESTRICT checks whether restrict > is supported by the C compiler. I'm using the C++ compiler. In that case, AC_C_RESTRICT should report that your C++ compiler does not support 'restrict' when compiling C code. What g

Re: removing stdint's dependency on wchar

2011-04-10 Thread Bruno Haible
This patch from 2011-02-18 introduces a regression on OSF/1: > 2011-02-18  Bruno Haible   > > stdint: Cut dependency to module 'wchar'. > * lib/stdint.in.h: Include wchar.h only when HAVE_WCHAR_H is 1. Also > include the necessary prerequisites. > * m4/stdint.m4 (g

Re: restrict qualifier and C++.

2011-04-10 Thread Bruno Haible
Nikos Mavrogiannopoulos wrote: > I'm using the C++ compiler. > (in gnutls, that has C and C++ components). Please, when reporting a bug, _always_ provide a "How to reproduce" recipe. In particular, you missed two occasions to tell which C compiler and which C++ compiler you are using. Paul Eggert

non-blocking I/O tests

2011-04-10 Thread Bruno Haible
Hi Eric, I was a bit suspicious whether non-blocking I/O on Woe32 sockets really work. So I set out to write a unit test for it. Sockets are a bit more complicated than pipes, so I started with the pipes. Find attached this unit test - for testing, not yet ready to be committed -. Can you please

Re: restrict qualifier and C++.

2011-04-10 Thread Nikos Mavrogiannopoulos
On 04/11/2011 12:56 AM, Paul Eggert wrote: > On 04/10/2011 03:07 PM, Nikos Mavrogiannopoulos wrote: >> As I understand it AC_C_RESTRICT checks whether restrict >> is supported by the C compiler. I'm using the C++ compiler. > > In that case, AC_C_RESTRICT should report that your C++ > compiler does