Re: bug#8230: touch dumps core on solaris 10

2011-03-12 Thread Bruno Haible
Paul Eggert wrote: > That sounds good, but why make Solaris 9 a special case? > Wouldn't it be simpler to do it for all platforms where gnulib > defines futimens or utimensat functions? The functions of the two cycles are available on the following platforms: Cycle #1: futimensAIX 7, Cygwin

wcswidth, mbswidth: add overflow check

2011-03-12 Thread Bruno Haible
Hi, On 2005-04-09, Jim noticed that mbswidth() can provoke integer overflow [1]. wcswidth() can do the same in gnulib, but the replacement in coreutils has a safety check against it. Let's do the same in gnulib: [1] http://lists.gnu.org/archive/html/bug-gnulib/2005-04/msg00022.html 2011-03-12

Support for options in valgrind-tests

2011-03-12 Thread Reuben Thomas
Another day, another nice surprise from gnulib: it supports valgrind, so I can remove my own code for that...only, no I can't, because I add options (I add --error-exitcode=1 --leak-check=full). So, two alternative suggestions: 1. Agree that these options are must-haves (rationale: one's code sho

warnings and -Werror

2011-03-12 Thread Reuben Thomas
The documentation for the warnings module says: "It allows to use ‘-Werror’ at ‘make distcheck’ time" but gives no clue as to how this is done; nor is -Werror mentioned in warnings.m4. Could we have a hint, please? (The documentation shows how to make the set of warnings chosen only apply to cert

Re: bug#8230: touch dumps core on solaris 10

2011-03-12 Thread Ben Walton
Excerpts from Bruno Haible's message of Sat Mar 12 07:11:51 -0500 2011: Hi Bruno, > I'm applying this patch: Thanks for saving me the legwork on this. The patch does correct the problem. I appreciate the quick turnaround on this. Thanks -Ben -- Ben Walton Systems Programmer - CHASS University