Re: source builds vs. RPMs (was: Re: gettext 0.18 grumbles)

2010-06-04 Thread Richard W.M. Jones
On Thu, Jun 03, 2010 at 10:04:28PM +0200, Bruno Haible wrote: > Let me repeat it: We have GNU standards that guarantee you that > ./configure > make > make install > must work everywhere. This *is* the "easy install" that anyone must be > able to use. > > Why did you choose to ignore the con

Re: gettext 0.18 grumbles

2010-06-04 Thread Richard W.M. Jones
On Thu, Jun 03, 2010 at 02:29:44PM -0600, Eric Blake wrote: > On 06/03/2010 12:59 PM, Jim Meyering wrote: > > Richard W.M. Jones wrote: > >> I just updated gnulib in libguestfs. This pulls in gettext 0.18 -- I > >> don't directly depend on the gettext module in gnulib, but doubtless > >> it's bein

Re: source builds vs. RPMs

2010-06-04 Thread Bruno Haible
Hi Richard, > > Why did you choose to ignore the contents of the INSTALL file and go > > searching for a distribution specific spec file instead? I'd like to > > know. The 'buildballs' project is attempting to address issues like this. > > I think it's fairly obvious why I'd want to build an RPM

Re: source builds vs. RPMs

2010-06-04 Thread Richard W.M. Jones
On Fri, Jun 04, 2010 at 11:05:56AM +0200, Bruno Haible wrote: > Where does the thinking come from that "there must be only one instance > of every package"? From Microsoft Windows? I've hardly ever used MS Windows, but I do know they have no packaging system to speak of and often install multiple,

./getopt.h:195: error: redefinition of 'struct option'

2010-06-04 Thread Richard W.M. Jones
make[4]: Entering directory `/home/rjones/d/libguestfs/gnulib/lib' CC xstrtol.lo In file included from xstrtol.h:23, from xstrtol.c:32: ./getopt.h:195: error: redefinition of 'struct option' In file included from xstrtol.h:23, from xstrtol.c:32: ./getopt.h:24

Re: ./getopt.h:195: error: redefinition of 'struct option'

2010-06-04 Thread Bruno Haible
Hi Richard, Last time we saw this error message, it was due to a wrong config.h. Richard W.M. Jones wrote: > make[4]: Entering directory `/home/rjones/d/libguestfs/gnulib/lib' > CC xstrtol.lo Can you show the complete command line? ("make V=1" will show it.) > In file included from xstrto

check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Peter Simons
Hi, the NEWS file of the GNU Autoconf Archive begins with a copyright header. As a result, the check-news target fails, because the output of "head ./NEWS" doesn't contain the release line that target is looking for. I have worked around the problem by patching maint.mk as follows: sed -i -e '

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Jim Meyering
Peter Simons wrote: > the NEWS file of the GNU Autoconf Archive begins with a copyright header. As a > result, the check-news target fails, because the output of "head ./NEWS" > doesn't contain the release line that target is looking for. > > I have worked around the problem by patching maint.mk as

Re: ./getopt.h:195: error: redefinition of 'struct option'

2010-06-04 Thread Richard W.M. Jones
On Fri, Jun 04, 2010 at 02:17:22PM +0200, Bruno Haible wrote: > Hi Richard, > > Last time we saw this error message, it was due to a wrong config.h. The results below are after 'rm config.h; ./configure ...; make clean' > Richard W.M. Jones wrote: > > make[4]: Entering directory `/home/rjones/d/

Re: ./getopt.h:195: error: redefinition of 'struct option'

2010-06-04 Thread Bruno Haible
Richard W.M. Jones wrote: > /bin/sh ../../libtool --tag=CC --mode=compile gcc -std=gnu99 > -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -g -O2 -MT xstrtol.lo -MD -MP -MF > $depbase.Tpo -c -o xstrtol.lo xstrtol.c &&\ This command line is line. > > 2) the contents of config.h > > At

Re: ./getopt.h:195: error: redefinition of 'struct option'

2010-06-04 Thread Richard W.M. Jones
On Fri, Jun 04, 2010 at 03:16:38PM +0200, Bruno Haible wrote: > The first one is fine. The second one should not be there. Yes, I see now that gnulib/lib/getopt.h is present on the machine which fails and absent on the other one. > Conclusion: You had a getopt.h that was necessary for one platfo

Re: ./getopt.h:195: error: redefinition of 'struct option'

2010-06-04 Thread Eric Blake
On 06/04/2010 08:05 AM, Richard W.M. Jones wrote: > > On Fri, Jun 04, 2010 at 03:16:38PM +0200, Bruno Haible wrote: >> The first one is fine. The second one should not be there. > > Yes, I see now that gnulib/lib/getopt.h is present on the machine > which fails and absent on the other one. > >>

Re: ./getopt.h:195: error: redefinition of 'struct option'

2010-06-04 Thread Richard W.M. Jones
Indeed 'make distclean' does fix this. Sorry for the noise .. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_st

havelib module: '+' in library names

2010-06-04 Thread Martin Lambers
Hello everyone, the havelib module cannot handle library names that contain the '+' character, such as libGraphicsMagick++.so. The attached patch fixes this for me, but I'm not sure if any special quoting or escaping of '+' is necessary. Martin diff --git a/m4/lib-link.m4 b/m4/lib-link.m4 i

Re: source builds vs. RPMs

2010-06-04 Thread Mike Frysinger
On Friday, June 04, 2010 05:05:56 Bruno Haible wrote: > Where does the thinking come from that it is bad to have something not > recognized by the package system? because it is bad. i rarely install packages onto my system anymore without a way of tracking them via my PM. if i do, i leverage DI

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Ralf Wildenhues
Hi Jim, Peter, * Jim Meyering wrote on Fri, Jun 04, 2010 at 02:40:20PM CEST: > > You may want to put the copyright at the end of NEWS. > Human readers prefer it that way, too ;-) > > Here's what I use: > > > Copyright (C)

Re: havelib module: '+' in library names

2010-06-04 Thread Eric Blake
On 06/04/2010 11:45 AM, Martin Lambers wrote: > Hello everyone, > > the havelib module cannot handle library names that contain the '+' > character, such as libGraphicsMagick++.so. > > The attached patch fixes this for me, but I'm not sure if any special > quoting or escaping of '+' is necessary.

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Karl Berry
A while ago, Karl encouraged GNU maintainers to just license files like Well, more precisely, I attempted to clarify rms' recommendation which has been the intention since the early days of GNU. I don't make policy decisions like this myself :). However, I don't see any particular problem wi

Re: check-news target fails if NEWS file starts with a copyright header

2010-06-04 Thread Jim Meyering
Karl Berry wrote: > A while ago, Karl encouraged GNU maintainers to just license files like > > Well, more precisely, I attempted to clarify rms' recommendation which > has been the intention since the early days of GNU. I don't make policy > decisions like this myself :). > > However, I don'

gettext: update to 0.18.1

2010-06-04 Thread Bruno Haible
gettext 0.18.1 was released today. This patch upgrades the gnulib module. The macros are already up-to-date (only iconv.m4 changed). 2010-06-04 Bruno Haible Update to GNU gettext 0.18.1. * modules/gettext (configure.ac): Require gettext infrastructure from version 0.18

Re: havelib module: '+' in library names

2010-06-04 Thread Bruno Haible
Hello Martin, > the havelib module cannot handle library names that contain the '+' > character, such as libGraphicsMagick++.so. > > The attached patch fixes this for me Thanks, I'm applying it with a minor tweak: Leave the '-' the last character. While for m4_translit and sed it does not matte

Re: havelib module: '+' in library names

2010-06-04 Thread Eric Blake
On 06/04/2010 07:29 PM, Bruno Haible wrote: > Hello Martin, > >> the havelib module cannot handle library names that contain the '+' >> character, such as libGraphicsMagick++.so. >> >> The attached patch fixes this for me > > Thanks, I'm applying it with a minor tweak: Leave the '-' the last > c

Re: havelib module: '+' in library names

2010-06-04 Thread Bruno Haible
Eric Blake wrote: > we might as well fix poor quoting and use preferred macro spellings: > > m4_pushdef([Name],m4_translit([[$1]],[./-+], [])) > m4_pushdef([NAME],m4_translit([[$1]],[abcdefghijklmnopqrstuvwxyz./-+], > [ABCDEFGHIJKLMNOPQRSTUVWXYZ])) OK for m4_

Re: strcoll on Solaris

2010-06-04 Thread Bruno Haible
Eric Blake wrote: > And in the meantime, now that we've confirmed that it is a Solaris > strcoll() bug, it would be nice to code a gnulib workaround. As expected, this code reproduces it: === #include #include #include #includ

Re: ‘libunistring’ module errors

2010-06-04 Thread Ralf Wildenhues
[ adding bug-automake ] Hi Bruno, * Bruno Haible wrote on Thu, Jun 03, 2010 at 02:01:29PM CEST: > > The reason is that 'aclocal' has generated an aclocal.m4 file that does not > include m4/libunistring.m4. I thought that 'aclocal' was using autom4te with > --trace options, implying that any AC_D