Fwd: [bug #29380] Failes tests in GNULib for GNU grep 2.6.2 on Solaris

2010-03-31 Thread Paolo Bonzini
URL: Summary: Failes tests in GNULib for GNU grep 2.6.2 on Solaris Project: grep Submitted by: dagobert Submitted on: Di 30 Mär 2010 11:09:35 GMT Category: None Sever

redundant redeclaration of '_gl_cxxalias_dummy'

2010-03-31 Thread Simon Josefsson
Building GnuTLS fails because of: ./../gl/sys/time.h:350: error: redundant redeclaration of '_gl_cxxalias_dummy' [-Wredundant-decls] ./../gl/string.h:1103: note: previous declaration of '_gl_cxxalias_dummy' was here ./../gl/sys/time.h:353: error: redundant redeclaration of '_gl_cxxalias_dummy'

[PATCH] sys_time: avoid compiler warnings

2010-03-31 Thread Eric Blake
sys/time uses #if/#else/#endif, and is therefore not subject to the gcc optimization. The #pragma GCC system_header must occur up front. * lib/sys_time.in.h (includes): Ensure gcc pragma is unconditional, fixing regression from 2010-03-29. Reported by Simon Josefsson. Signed-off-by: Eric Blake

Re: [PATCH 3/3] Macro _prohibit_regexp replaced by _sc_search_regep and rules adapted to use the new macro.

2010-03-31 Thread Jim Meyering
Jim Meyering wrote: > Eric Blake wrote: > >> On 03/28/2010 08:54 AM, Jose E. Marchesi wrote: >>> From 24ab183f237468f2aa59d2424dc416f61c183671 Mon Sep 17 00:00:00 2001 >>> From: Jose E. Marchesi >>> Date: Sun, 28 Mar 2010 15:42:03 +0200 >>> Subject: [PATCH 3/3] Macro _prohibit_regexp replaced

Re: [PATCH 3/3] Macro _prohibit_regexp replaced by _sc_search_regep and rules adapted to use the new macro.

2010-03-31 Thread Jose E . Marchesi
Hi Jim. Jose, here are your two patches, with updated log messages, followed by 6 more patches, some clean-up, some fixes, that I tested yesterday or Monday -- I think it was with grep and coreutils. I'll test again today or tomorrow, then squash each of the 6 into whiche

Re: [PATCH 3/3] Macro _prohibit_regexp replaced by _sc_search_regep and rules adapted to use the new macro.

2010-03-31 Thread Eric Blake
On 03/31/2010 01:23 PM, Jose E. Marchesi wrote: > Regarding the unaligned backslashes: > > Subject: [PATCH 4/8] avoid long lines; align backslashes > [...] > + || { msg='halt not defined' $(_sc_say_and_exit) }; > \ > +

Re: [PATCH 3/3] Macro _prohibit_regexp replaced by _sc_search_regep and rules adapted to use the new macro.

2010-03-31 Thread Jose E . Marchesi
It may also be a factor of tabs vs. spaces. Since3 you used tabs, but the diff indents your line by one space, then lines that had a single-width leading tab after the last non-whitespace all the sudden appear off by 7, compared to all leading multi-width tabs which merely get

[PATCH] maint.mk: check for [ as well as test

2010-03-31 Thread Eric Blake
A word on the regex: \<\[ never matches, so the match instead looks for a leading space in that case. Although configure.ac should generally use test instead of [ (because the latter has to be spelled [[ because of m4 processing), libvirt had a case of the latter that would have been detected with

Re: [PATCH] gnumakefile: don't squelch _version output

2010-03-31 Thread Eric Blake
On 03/30/2010 05:40 PM, Eric Blake wrote: > Borrowing from a trick I discovered on the libvirt list. > > * top/GNUmakefile (GNUmakefile): Create one-shot dependency rather > than using $(shell) to run _version target. > (_autoreconf): Run verbosely, by default. > > Signed-off-by: Eric Blake > --