Re: lib-ignore: link error with Sun C++ compiler

2010-03-28 Thread Bruno Haible
> * Bruno Haible wrote on Sat, Mar 20, 2010 at 11:52:25PM CET: > > lib-ignore: Determine different options for different compilers. > > * m4/lib-ignore.m4 (gl_IGNORE_UNUSED_LIBRARIES): Set a variable which > > depends on the current language (C/C++/Fortran). Don't set LDFLAGS. > > A

Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

2010-03-28 Thread Bruno Haible
Hi Eric, > >> -#ifndef _GL_CTYPE_H > >> - > >> #if __GNUC__ >= 3 > >> @PRAGMA_SYSTEM_HEADER@ > >> #endif > >> > >> +#ifndef _GL_CTYPE_H > >> + > >> /* Include the original . */ > >> /* The include_next requires a split double-inclusion guard. */ > >> #...@include_next@ @NEXT_CTYPE_H@ > >

Re: [PATCH] build: sync primary and tests-related gnulib module lists

2010-03-28 Thread Bruno Haible
Jim Meyering wrote: > * bootstrap.conf (gnulib_modules): Synchronize the primary list > of modules with the list used by tests, so that we don't have > a repeat of the wctob-vs-Solaris 8 build failure. You should now be able to revert this. The bug is fixed in gnulib since yesterday. Bruno

Re: portable openpty, forkpty

2010-03-28 Thread Bruno Haible
Hi Simon, Thanks for testing. > The forkpty code builds fine as a part of InetUtils on Mac OS X. I > tried the gnulib self-checks for forkpty, but they failed: > > Making check in gltests > make check-recursive > make check-TESTS > PASS: test-alignof > PASS: test-errno > PASS: test-fcntl-h > P

sys_ioctl, sys_select: fix link errors

2010-03-28 Thread Bruno Haible
On mingw, I get link errors: g++ -mno-cygwin-L/usr/local/mingw/lib -o test-sys_ioctl-c++.exe test-sys_ioctl-c++.o ../gllib/libgnu.a test-sys_ioctl-c++.o:test-sys_ioctl-c++.cc:(.data+0x4): undefined reference to `_ioctl' collect2: ld returned 1 exit status make[4]: *** [test-sys_ioctl-c++.

Re: #defines in unistd.h

2010-03-28 Thread Bruno Haible
Hi John, Thanks for this report. > The current gnulib unistd.in.h file includes the following section: > > #if @GNULIB_GETHOSTNAME@ > /* Get all possible declarations of gethostname(). */ > # if @UNISTD_H_HAVE_WINSOCK2_H@ > # if !defined _GL_SYS_SOCKET_H > # undef socket > # de

Re: C++ libtool build error?

2010-03-28 Thread Bruno Haible
Eric Blake wrote on 2010-03-17: > > Allow the user to disable C++ code and tests. > > * m4/ansi-c++.m4 (gl_CXX_CHOICE): New macro. > > (gl_PROG_ANSI_CXX): Require it. > > This is a nice patch, but would it be possible to take it one step > further, and allow the developer to populate a

[PATCH 1/3] Macro _header_without_use renamed to _sc_header_without_use in maint.mk

2010-03-28 Thread Jose E . Marchesi
>From 94828fa78a7a03dad4cbbd88f3b5f4f9ccf22776 Mon Sep 17 00:00:00 2001 From: Jose E. Marchesi Date: Sun, 28 Mar 2010 13:28:34 +0200 Subject: [PATCH 1/3] Macro _header_without_use renamed to _sc_header_without_use in maint.mk --- ChangeLog| 27 +++ top/maint.mk |

[PATCH 2/3] Catch function calls with zero or more blank characters before the argument list in syntax check rules.

2010-03-28 Thread Jose E . Marchesi
>From baf55461a6b01978ba02327f790f4fd544b1342f Mon Sep 17 00:00:00 2001 From: Jose E. Marchesi Date: Sun, 28 Mar 2010 13:35:24 +0200 Subject: [PATCH 2/3] Catch function calls with zero or more blank characters before the argument list in syntax check rules. --- ChangeLog| 11 +++

[PATCH 3/3] Macro _prohibit_regexp replaced by _sc_search_regep and rules adapted to use the new macro.

2010-03-28 Thread Jose E . Marchesi
>From 24ab183f237468f2aa59d2424dc416f61c183671 Mon Sep 17 00:00:00 2001 From: Jose E. Marchesi Date: Sun, 28 Mar 2010 15:42:03 +0200 Subject: [PATCH 3/3] Macro _prohibit_regexp replaced by _sc_search_regep and rules adapted to use the new macro. --- ChangeLog| 40 +++ top/maint.mk |

using a gnulib dir from more than one place (was: [PATCH] build: avoid link failure on systems using gnulib's fcntl but not open)

2010-03-28 Thread Ralf Wildenhues
Hello Bruno, * Bruno Haible wrote on Sun, Mar 28, 2010 at 01:39:24AM CET: > +Comment: > +This module should not be used as a dependency from a test module, > +otherwise when this module occurs as a tests-related module, it will > +have side effects on the compilation of the main modules in lib/.

extra test module categories

2010-03-28 Thread Bruno Haible
Jim Meyering suggested: > > Rather than lumping them all into one "-extratests" category > > that is tied to the module file name, have you considered > > adding new module attributes? > > > > Then, we could give any module one or more attributes, > > and eventually exclude based on those attribu

Re: using a gnulib dir from more than one place

2010-03-28 Thread Bruno Haible
Ralf, > would it be possible > to generalize gnulib or gnulib-tool so that a developer can state "I > would like to use bits of gnulib from several places in a package > hierarchy. Place i needs module set m_i, please dump the union of all > m_i into the "lib" and "m4" directories, and tell me wh

Re: extra test module categories

2010-03-28 Thread Bruno Haible
And this makes it possible to declare part of the tests of a module as c++-test or longrunning-test or similar. 2010-03-28 Bruno Haible gnulib-tool: Allow 'foo-tests' module even if there is no module 'foo'. * gnulib-tool (func_exists_module): New function, extracted from

Re: C++ libtool build error?

2010-03-28 Thread Bruno Haible
Simon Josefsson wrote on 2010-03-17: > > - The C++ tests of the modules 'string', 'stdlib', etc. > > - The tests that ask for the superuser password ('idpriv-drop', > > 'idpriv-droptemp'). > > - The long-running tests of the 'havelib' module (currently still in > > gettext). > > I ag

Re: [PATCH] build: avoid link failure on systems using gnulib's fcntl but not open

2010-03-28 Thread Simon Josefsson
Bruno Haible writes: > Simon, is it ok to remove the GNULIB_GC_CAMELLIA macro? I see it nowhere > used in gnulib. Is it used in one of your packages? I don't recall -- but please remove it, and if I notice any problems I'll follow with a proper solution. /Simon

[PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE

2010-03-28 Thread Jim Meyering
I expect to push this tiny patch by Javier (Cc'd). Thanks, Javier! Without it, grep's --include=GLOB doesn't work. >From efd2b17d1431399233caa5e5b55c831a3459f66a Mon Sep 17 00:00:00 2001 From: Javier Villavicencio Date: Sun, 28 Mar 2010 20:42:01 +0200 Subject: [PATCH] exclude: fix the case of gl

read() and write() for MinGW

2010-03-28 Thread Neil Jerram
I'd like to contribute a gnulib module to handle the fact that, on MinGW, you have to use recv() to read data from a socket, instead of read(). Similarly, for writing, send() is needed instead of write(). Conceptually this is extremely simple, and I've found that gnulib already contains useful bi

Re: [PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE

2010-03-28 Thread Javier Villavicencio
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 On 03/28/2010 03:44 PM, Jim Meyering wrote: > I expect to push this tiny patch by Javier (Cc'd). > Thanks, Javier! > > Without it, grep's --include=GLOB doesn't work. > >>From efd2b17d1431399233caa5e5b55c831a3459f66a Mon Sep 17 00:00:00 2001 > F

Re: read() and write() for MinGW

2010-03-28 Thread Bruno Haible
Hi Neil, > I'd like to contribute a gnulib module to handle the fact that, on > MinGW, you have to use recv() to read data from a socket, instead of > read(). > > Similarly, for writing, send() is needed instead of write(). Gnulib already solves this problem, by wrapping the Win32 SOCKET in a fi

Re: sys_ioctl, sys_select: fix link errors

2010-03-28 Thread Ludovic Courtès
Hi Bruno, Bruno Haible writes: > 2010-03-28 Bruno Haible > > Fix link errors on mingw. > * lib/sys_ioctl.in.h (ioctl): Fix declaration idiom. > * modules/sys_ioctl-tests (Makefile.am): Link test-sys_ioctl-c++ with > $(LIBSOCKET). > * modules/sys_select-tests (Mak

Re: sys_ioctl, sys_select: fix link errors

2010-03-28 Thread Bruno Haible
Hi Ludo, > > * lib/sys_ioctl.in.h (ioctl): Fix declaration idiom. > > This patch appears to break Inetutils bootstrapping: > > http://hydra.nixos.org/build/335490 Thanks for the quick report. This should fix it. The fix is modeled after the gettimeofday, forkpty, openpty wrappers by Eric.

Re: [PATCH] exclude: fix the case of globs vs. EXCLUDE_INCLUDE

2010-03-28 Thread Jim Meyering
Javier Villavicencio wrote: > I think you may have mixed up the two patches I reported against grep Think again ;-) > bug 29358, so, to clarify: > That above is actually the patch that made most sense to me against the > EXCLUDE_INCLUDE logic, as in: excluded_file_pattern_p should return > !exclu

Re: lib-ignore: link error with Sun C++ compiler

2010-03-28 Thread Jim Meyering
Bruno Haible wrote: >> * Bruno Haible wrote on Sat, Mar 20, 2010 at 11:52:25PM CET: >> >lib-ignore: Determine different options for different compilers. >> >* m4/lib-ignore.m4 (gl_IGNORE_UNUSED_LIBRARIES): Set a variable which >> >depends on the current language (C/C++/Fortran). Don't s

Re: Remove fts-lgpl?

2010-03-28 Thread Jim Meyering
Bruno Haible wrote: > Eric applied this patch from Ralf Wildenhues on 2010-03-02: >> Remove fts-lgpl module. >> >> * modules/fts-lgpl: Remove. >> * MODULES.html.sh (func_all_modules): Adjust. >> * check-module (find_included_lib_files): Adjust. >> * m4/fts.m4 (gl_FUNC_FTS_LGPL):