Re: MKDIR_P discovered by configure but not substituted in the Makefile

2010-02-22 Thread Simon Josefsson
Eric Blake writes: > According to James Youngman on 2/20/2010 5:01 PM: >> $ for p in automake autoconf ; do $p --version; done >> automake (GNU automake) 1.9.6 > > There's your problem. It's time for an upgrade, particularly since all > released versions of automake except 1.10.3 and 1.11.1 have

Re: MKDIR_P discovered by configure but not substituted in the Makefile

2010-02-22 Thread Eric Blake
According to Simon Josefsson on 2/22/2010 1:15 AM: > Gnulib's DEPENDENCIES says automake 1.9.6 is fine. I think Bruno's > workaround is better than incrementing the required minimum version, if > this problem is the only reason why automake > 1.9.6 would be required > by gnulib. Yes, I approve of

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread Pádraig Brady
On 21/02/10 13:43, jema...@gnu.org wrote: Hi. Just another little patch to avoid some of the sc_* rules to freeze if the filtering of VC_LIST_EXCEPT gives an empty string (for example, 'make sc_error_exit_success' freezes if there are not source files in ${srcdir}/). I found this problem due t

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread Jim Meyering
Pádraig Brady wrote: ... > Would it be better to just add /dev/null as a parameter to grep? > I.E. like: > > @grep -nE 'error \(EXIT_SUCCESS,' \ > $$($(VC_LIST_EXCEPT) /dev/null | grep -E '\.[chly]$$')&&\ > { echo '$(ME): found error (EXIT_S

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread Eric Blake
According to Pádraig Brady on 2/22/2010 6:40 AM: > On 21/02/10 13:43, jema...@gnu.org wrote: >> >> Hi. >> >> Just another little patch to avoid some of the sc_* rules to freeze if >> the filtering of VC_LIST_EXCEPT gives an empty string (for example, >> 'make sc_error_exit_success' freezes if there

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread jemarch
Would it be better to just add /dev/null as a parameter to grep? I.E. like: @grep -nE 'error \(EXIT_SUCCESS,'\ $$($(VC_LIST_EXCEPT) /dev/null | grep -E '\.[chly]$$')&& \ { echo '$(ME): found error (EXIT_SUCCESS' 1>&2; exit 1

Re: portability of 'printf' command

2010-02-22 Thread Thomas Dickey
On Sun, 21 Feb 2010, Bob Friesenhahn wrote: On Sun, 21 Feb 2010, Bruno Haible wrote: Is someone aware of a platform that does not have a /usr/bin/printf or /bin/printf program? I am not able to find any. However, the behavior of printf surely changes over time as standards move forward.

Re: portability of 'printf' command

2010-02-22 Thread Thomas Dickey
On Sun, 21 Feb 2010, Bob Friesenhahn wrote: On Sun, 21 Feb 2010, Thomas Dickey wrote: I am not able to find any. However, the behavior of printf surely changes over time as standards move forward. SunOS didn't have one (I don't see it in the manpages, at any rate). I did check SunOS 5.6 (S

Problem on system without gettimeofday

2010-02-22 Thread Michael Goffioul
Hi, I'm trying to compile octave (which uses gnulib) with MSVC, but got a problem related to a recent change introduced in the gnulib source tree, namely http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=de4d0a383be20eb6cbeb09ecbd66a5514779b914 I think that because of the outer "if

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread Pádraig Brady
On 22/02/10 15:08, jema...@gnu.org wrote: Would it be better to just add /dev/null as a parameter to grep? I.E. like: @grep -nE 'error \(EXIT_SUCCESS,' \ $$($(VC_LIST_EXCEPT) /dev/null | grep -E '\.[chly]$$')&& \

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread Jim Meyering
jema...@gnu.org wrote: ... > I suggest to use the following solution that works properly in all > cases while avoiding the code duplication (in the spirit of > _prohibit_regexp): Good idea. > define _sc_maybe_matching_files > dummy=; : so we do not need a semicolon before each use;

Re: Problem on system without gettimeofday

2010-02-22 Thread Eric Blake
According to Michael Goffioul on 2/21/2010 4:09 PM: > I think that because of the outer "if test $ac_cv_func_gettimeofday = > yes; then", > REPLACE_GETTIMEOFDAY can only be set to 1 on systems that already > provide an implementation of it. Correct. But a platform that lacks gettimeofday altogeth

Re: gnulib bootstrap and git submodules

2010-02-22 Thread Eric Blake
According to Eric Blake on 2/17/2010 1:20 PM: > Here's my first cut at it. > > From: Eric Blake > Date: Wed, 17 Feb 2010 11:42:16 -0700 > Subject: [PATCH] bootstrap: use GNULIB_SRCDIR to reduce disk usage I was about to push this as-is, but noticed that libvirt stores the submodule as ".gnulib",

Re: [patch] Avoid some of the sc_ rules to freeze

2010-02-22 Thread jemarch
> define _sc_maybe_matching_files > dummy=; : so we do not need a semicolon before each use; \ > test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; }; \ > if test -n "$$matching"; then matching='yes'; fi\ > files=$$($(VC_LIST_EXCEPT) | grep

new module 'c++defs'

2010-02-22 Thread John W. Eaton
On 22-Feb-2010, Bruno Haible wrote: | Here come the proposed changes to allow C++ developers to choose among | the default mode with many | #define func rpl_func | macro definitions and a "namespace mode", which is more in line with the | way C++ programs are built. | | I handled all header fil

popen binary mode patch

2010-02-22 Thread Bruce Korb
This patch adds "binary mode" handling for popen() on platforms where the native popen() will not. This is a problem especially on platforms where fopen() will ignore the 'b' but popen() will not. Hence, the test for "does fopen() accept a 'b'" won't apply to popen(). GNU libc ought to just ignore

Re: popen binary mode patch

2010-02-22 Thread Eric Blake
According to Bruce Korb on 2/22/2010 11:00 AM: > This patch adds "binary mode" handling for popen() on platforms where > the native popen() will not. This is a problem especially on > platforms where fopen() will ignore the 'b' but popen() will not. > Hence, the test for "does fopen() accept a 'b'

Re: popen binary mode patch

2010-02-22 Thread Bruce Korb
Eric Blake wrote: > Thinking aloud here - do we even need a configure check? Or would it just > be better to depend on the binary-io module, and use #if O_BINARY to > decide whether to strip 'b' before calling the real popen, and vs. letting > the underlying popen handle 'b'. As far as I know, al

Re: License of lib-ignore module

2010-02-22 Thread Jim Meyering
Martin Lambers wrote: > the license of lib-ignore is listed as 'GPL'. Is this intended? > > The module consists only of lib-ignore.m4, and that file carries an > 'unlimited' license note, like most other m4 files. Also, gnulib-tool > does not replace that with a GPL note when copying the file. Tha

Re: popen binary mode patch

2010-02-22 Thread Eric Blake
According to Bruce Korb on 2/22/2010 12:25 PM: > As far as I know, I don't know. :) The only thing I know for certain > is that ``popen (cmd, "rb")'' fails on my box and I know that > ``fopen (file, "rb")'' works. POSIX requires fopen(,"rb") to be identical to fopen(,"r"); while C99 requires bot

License of lib-ignore module

2010-02-22 Thread Martin Lambers
Hi, the license of lib-ignore is listed as 'GPL'. Is this intended? The module consists only of lib-ignore.m4, and that file carries an 'unlimited' license note, like most other m4 files. Also, gnulib-tool does not replace that with a GPL note when copying the file. Martin

Re: gnulib module install

2010-02-22 Thread Matěj Týč
On Sun, 2010-02-21 at 23:43 +0100, Bruno Haible wrote: > Hi, > > Matěj Týč wrote: > > What I don't like about the second solution is the necessity of having > > gnulib-tool available. ... > > ... should be performed manually from the gnulib git. > > You surely can imagine that the difficulty of t

Re: [patch] fix "broken pipe" message from lseek test

2010-02-22 Thread Eric Blake
According to Bruno Haible on 2/20/2010 7:56 PM: >> test `echo hi | { ./conftest$ac_exeext; echo $?; cat > /dev/null; }` = 1 > > I like this too, in this case. Then I will be committing this: -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net From 03b453

Re: popen binary mode patch

2010-02-22 Thread Bruce Korb
Eric Blake wrote: > POSIX requires fopen(,"rb") to be identical to fopen(,"r"); while C99 > requires both to exist but allows them to have different behavior (as a > concession to windows). However, there is no standard for popen(,"rb"). > >>> rather than changing gnulib's popen module. >> It's y

Re: gnulib bootstrap and git submodules

2010-02-22 Thread Eric Blake
According to Eric Blake on 2/22/2010 9:28 AM: > According to Eric Blake on 2/17/2010 1:20 PM: >> Here's my first cut at it. >> >> From: Eric Blake >> Date: Wed, 17 Feb 2010 11:42:16 -0700 >> Subject: [PATCH] bootstrap: use GNULIB_SRCDIR to reduce disk usage > > I was about to push this as-is, but

Re: new module 'c++defs'

2010-02-22 Thread Bruno Haible
John W. Eaton wrote: > ../libgnu/stdio.h:1087: error: previous declaration of 'int > _gl_cxxalias_dummy' with 'C++' linkage > ../libgnu/signal.h:246: error: conflicts with new declaration with 'C' > linkage Thanks for reporting this. I'll handle it through the patch below. But this error al

Re: License of lib-ignore module

2010-02-22 Thread Bruno Haible
Jim Meyering wrote: > > The module consists only of lib-ignore.m4 > I'll confirm with Paul that it's ok to relax to LGPLv2+ There's no need to disturb Paul for this, because it would be a no-op. See . Bruno

Re: popen binary mode patch

2010-02-22 Thread Eric Blake
According to Bruce Korb on 2/22/2010 3:50 PM: >> The question, though, is whether cygwin's extension is useful enough to >> push on all platforms. Gnulib tends to favor glibc extensions rather than >> cygwin extensions. In other words, it is hard to justify replacing a >> glibc function that is p

Re: gnulib module install

2010-02-22 Thread Bruno Haible
Hello Matěj, (how do you pronounce your name? like Matyesh?) > The script solution you have proposed does the job, but I hate when the > autogen.sh file has more than, let's say, ten lines. Well, the autogen.sh script has more to do if you omit more files from version control. An autogen.sh scr

bootstrap differences

2010-02-22 Thread Eric Blake
Should any of these bootstrap differences be synchronized? Both coreutils and gnulib had some improvements over the other: $ diff -u coreutils/bootstrap coreutils/gnulib/build-aux/bootstrap --- coreutils/bootstrap 2010-01-01 08:29:35.453125000 -0700 +++ coreutils/gnulib/build-aux/bootstrap

Re: new module 'c++defs'

2010-02-22 Thread John W. Eaton
On 23-Feb-2010, Bruno Haible wrote: | John W. Eaton wrote: | > ../libgnu/stdio.h:1087: error: previous declaration of 'int _gl_cxxalias_dummy' with 'C++' linkage | > ../libgnu/signal.h:246: error: conflicts with new declaration with 'C' linkage | | Thanks for reporting this. I'll handle it

Re: Problem on system without gettimeofday

2010-02-22 Thread Michael Goffioul
On Mon, Feb 22, 2010 at 4:05 PM, Eric Blake wrote: > According to Michael Goffioul on 2/21/2010 4:09 PM: >> I think that because of the outer "if test $ac_cv_func_gettimeofday = >> yes; then", >> REPLACE_GETTIMEOFDAY can only be set to 1 on systems that already >> provide an implementation of it.

Re: Problem on system without gettimeofday

2010-02-22 Thread Michael Goffioul
On Tue, Feb 23, 2010 at 7:15 AM, Michael Goffioul wrote: > Thanks. I tried the patch and gettimeofday is not compiled in. However, Sorry, I meant "is *now* compiled in". Michael.