Re: visibility.m4

2009-11-02 Thread Paolo Bonzini
On 10/31/2009 05:34 PM, Mike Gran wrote: Hello- If I use visibility.m4 on a platform with a recent GCC (4.x) on Cygwin, the visibility.m4 correctly discovers that gcc can compile with -fvisibility="hidden". But, on Cygwin (and probably most non-ELF) gcc does not actualy implement the visibility

Re: Explicit interpreter paths considered harmful

2009-11-02 Thread Simon Josefsson
l...@gnu.org (Ludovic Courtès) writes: > diff --git a/build-aux/pmccabe2html b/build-aux/pmccabe2html > index 27bb8f3..4fe4c64 100755 > --- a/build-aux/pmccabe2html > +++ b/build-aux/pmccabe2html > @@ -1,4 +1,5 @@ > -#!/usr/bin/awk -f > +#!/bin/sh > +exec awk -f "$0" "$@" > # pmccabe2html - pmcca

Re: test-utimens.h:105: assertion failed

2009-11-02 Thread Simon Josefsson
Eric Blake writes: > According to Simon Josefsson on 10/30/2009 2:32 AM: >> A (f)utimens test fail on Ubuntu 8.04 LTS: > > Thanks for the report. Which kernel and which version of glibc? Is it a > machine I might have access to, like the gcc compile farm? Send me your SSH public key and prefer

Re: Build + test problems on OpenSolaris (aka Solaris 11)

2009-11-02 Thread Simon Josefsson
The GnuTLS team received the bug report below, but it appears to be a gnulib issue. The problem indicate a sub-optimal approach in gnulib's inet_ntop module. It causes link failures due to missing -lnsl on Solaris. The m4/inet_ntop.m4 file reads: dnl The AC_SEARCH_LIBS call is a hack to persu

Re: more warnings patrol

2009-11-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/30/2009 6:10 PM: > I'm committing this, to silence some unused variables, and to make > inttostr.c quiet even on older gcc. And looking in config.log, I found these. - -- Don't work too hard, make some time for fun as we

Re: Explicit interpreter paths considered harmful

2009-11-02 Thread Eric Blake
Jim Meyering meyering.net> writes: > Rather than putting #!/usr/bin/perl on the first line, > start with a variant of what's recommended by "man perlrun" that > invokes the first "perl" program from your shell's search path. We should change the test to match. I also ran into a failure on cygwi

EAI_NODATA used in test-getaddrinfo.c

2009-11-02 Thread Jim Meyering
On Freebsd8-rc2 I saw this: test-getaddrinfo.c: In function 'simple': test-getaddrinfo.c:95: error: 'EAI_NODATA' undeclared (first use in this function) lib/netdb.h was not generated. Here's one way to fix it, but I haven't dug enough yet to know if that's appropriate: diff --git a/tests/t

4 test failures on freebsd8-rc2

2009-11-02 Thread Jim Meyering
FYI, I haven't looked at all, yet... == GNU coreutils 8.0.79-71c2f8: gnulib-tests/test-suite.log == 4 of 178 tests failed. (2 tests were not run). .. contents:: :depth: 2

Re: EAI_NODATA used in test-getaddrinfo.c

2009-11-02 Thread Bruno Haible
Jim Meyering wrote: > On Freebsd8-rc2 I saw this: > > test-getaddrinfo.c: In function 'simple': > test-getaddrinfo.c:95: error: 'EAI_NODATA' undeclared (first use in this > function) > > lib/netdb.h was not generated. > > Here's one way to fix it, but > I haven't dug enough yet to know if t

mkostemps

2009-11-02 Thread Eric Blake
Now that glibc 2.11 offers mkostemps, we should too. Any objections to this patch series? Eric Blake (3): tempname: resync from glibc This patch conflicts with coreutils' local override of tempname.c, so I'm also working on a coreutils followup patch to fix things once coreutils imports t

Re: Build + test problems on OpenSolaris (aka Solaris 11)

2009-11-02 Thread Bruno Haible
Simon Josefsson wrote: > The problem indicate a sub-optimal approach in gnulib's inet_ntop > module. It causes link failures due to missing -lnsl on Solaris. Indeed, Paul Eggert was already aware of it; see his ChangeLog entry in [1]. [1] http://lists.gnu.org/archive/html/bug-gnulib/2009-04/msg0

Re: Solaris and inet_pton

2009-11-02 Thread Bruno Haible
> 2009-11-02 Simon Josefsson > Bruno Haible > > * m4/inet_ntop.m4 (gl_INET_NTOP): Define also INET_NTOP_LIB. > * modules/inet_ntop (Link): New section. > Reported by Boyan Kasarov . The same problem exists also for the inet_pton module. I'm integrating Paul's an

Re: test-utimens.h:105: assertion failed

2009-11-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 11/2/2009 4:04 AM: >>> I can't reproduce on current debian testing, so it is likely an old bug. >> The Linux man pages are explicit that older kernels had a bug where >> UTIME_OMIT with a non-zero seconds field failed wi

Re: 4 test failures on freebsd8-rc2

2009-11-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/2/2009 2:18 PM: > test-linkat.c:240: assertion failed ... > test-utimens.h:126: assertion failed These two failures look similar, in that they are both instances of the BSD kernel mistakenly succeeding when handed a sym

Re: more warnings patrol

2009-11-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/30/2009 6:52 PM: >> How about moving this declaration to a new file mktime-internal.h? > > And share it between the mktime and timegm modules. Yes, that sounds nice. Done. - -- Don't work too hard, make some time for f

Re: EAI_NODATA used in test-getaddrinfo.c

2009-11-02 Thread Simon Josefsson
Bruno Haible writes: > Jim Meyering wrote: >> On Freebsd8-rc2 I saw this: >> >> test-getaddrinfo.c: In function 'simple': >> test-getaddrinfo.c:95: error: 'EAI_NODATA' undeclared (first use in this >> function) >> >> lib/netdb.h was not generated. >> >> Here's one way to fix it, but >> I

Re: Build + test problems on OpenSolaris (aka Solaris 11)

2009-11-02 Thread Simon Josefsson
Bruno Haible writes: >> How about this patch? Not tested on Solaris systems, but posted for >> review of my general idea. > > It's the right approach. But the name of the variable is not well chosen: > There are several functions defined in libnsl, therefore several modules > may want to define

Re: EAI_NODATA used in test-getaddrinfo.c

2009-11-02 Thread Jim Meyering
Simon Josefsson wrote: > Bruno Haible writes: > >> Jim Meyering wrote: >>> On Freebsd8-rc2 I saw this: >>> >>> test-getaddrinfo.c: In function 'simple': >>> test-getaddrinfo.c:95: error: 'EAI_NODATA' undeclared (first use in this >>> function) >>> >>> lib/netdb.h was not generated. >>> >>> H