Re: [PATCH] poll: remove declarations of unused variables

Paolo Bonzini wrote: > Jim Meyering wrote: >> Ok to apply this? > > Sure. I pushed Dan's change: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=03ba7406f5e0 >> /* Tell gcc not to warn about the (nfd < 0) tests, below. */ >> #if (__GNUC__ == 4 && 3 <= __GNUC_MINOR__) || 4

Re: poll: avoiding more warnings

Jim Meyering wrote: > After the used-uninitialized bug Dan Berrange found > in the windows-only part of poll.c, we've been motivated > to enable more warnings when building libvirt's subset > of gnulib, even (or rather especially) when cross-compiling > for mingw. > > To that end, there are a few

gnulib update broke printf-args.c on IRIX 6.5

Hi, I recently updated gnulib in the nagios-plugins source tree to fix issues with regex on HP-UX; unfortunately the update broke our IRIX 6.5 build. You can see the full log here: http://tinderbox.opsera.com/cgi-bin/gunzip.cgi?tree=nagiosplug&full-log=1232079870.10640 The interesting parts are

Re: Problems with gl_VSNPRINTF_ZEROSIZE_C99 under Sun C++ compiler

Albert Chin wrote: > When gl_VSNPRINTF_ZEROSIZE_C99 is run under the Sun C++ compiler on a > recent Solaris release, it fails because of: > static char buf[8] = "DEADBEEF"; > > The compiler complains with: > Error: Cannot use const char[9] to initialize char[8]. > > So, just replace `8' with

[PATCH] strerror: avoid warnings about discarding "const"

I'd like to push this today. Speak now if you object ;-) >From 7d9de4da85365b7b66d697f0b11ce93e416c7fd7 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 16 Jan 2009 12:09:48 +0100 Subject: [PATCH] strerror: avoid warnings about discarding "const" * lib/strerror.c (rpl_strerror): Instead of

Re: Problems with gl_VSNPRINTF_ZEROSIZE_C99 under Sun C++ compiler

Pádraig Brady wrote: > C99 states that the NUL is only copied if there's place, > whereas this will generate an error for c++ (not just Sun's compiler). Thanks for explaining. I was confused about when this special rule holds. > In any case, since we don't actually care what size the buf is I fi

Re: [PATCH] strerror: avoid warnings about discarding "const"

Hi Jim, > Speak now if you object ;-) > + char const *m = NULL; I would prefer an identifier that is a little more verbose. Such as 'msg' instead of 'm'? Bruno

Re: [PATCH] strerror: avoid warnings about discarding "const"

Bruno Haible wrote: > Hi Jim, > >> Speak now if you object ;-) >> + char const *m = NULL; > > I would prefer an identifier that is a little more verbose. Such as 'msg' > instead of 'm'? Ha! I used "msg" initially, but there's already an "mesg" local at the end, so I opted for shorter, to avoid

Re: [PATCH] strerror: avoid warnings about discarding "const"

Jim Meyering wrote: > case EINPROGRESS: > - return "Operation now in progress"; > + m = "Operation now in progress"; > case EALREADY: > - return "Operation already in progress"; > + m = "Operation already in progress"; You have to insert a 'break;' statement after eve

Re: [PATCH] strerror: avoid warnings about discarding "const"

Jim Meyering wrote: > there's already an "mesg" local at the end Indeed! But still, I find 'msg' better instead of 'm'. Bruno

Re: [PATCH] strerror: avoid warnings about discarding "const"

Bruno Haible wrote: > Jim Meyering wrote: >> case EINPROGRESS: >> - return "Operation now in progress"; >> + m = "Operation now in progress"; >> case EALREADY: >> - return "Operation already in progress"; >> + m = "Operation already in progress"; > > You have to inse

Re: lib/arpa_inet.in.h under C++

Albert Chin writes: > lib/arpa_inet.in.h needs the usual: > #ifdef __cplusplus > extern "C" { > #endif > > ... > > #ifdef __cplusplus > } > #endif > > to work under C++. Patch attached. Thanks, pushed. I didn't find copyright papers for you, but I believe this patch is short enoug

Re: support for universal binaries on MacOS X (5/6)

Hi Jim, Sorry for the delay. > I've reworked those patches accordingly, > but didn't test on a MacOS X system. > Since your name is on them, I'll wait until > you acknowledge before pushing. > > > From 6bfdd76f3f2e3b03be407dcfab7a231259d23d15 Mon Sep 17 00:00:00 2001 > From: Bruno Haible > Dat

Re: [PATCH] strerror: avoid warnings about discarding "const"

Bruno Haible wrote: > Jim Meyering wrote: >> there's already an "mesg" local at the end > > Indeed! But still, I find 'msg' better instead of 'm'. Ok. I've changed back to "msg", and changed the offending "mesg" to "msg_buf": >From bf3eb7707a54db920ff080ccc996382dc73e64ad Mon Sep 17 00:00:00 2

Re: gnulib update broke clisp

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paolo Bonzini on 1/15/2009 3:46 PM: >> AC_REQUIRE([AC_CONFIG_AUX_DIR($1)]) >> ?? >> I get this: >> warning: AC_CONFIG_AUX_DIR(../../../src/build-aux) is m4_require'd but >> not m4_defun'd > > AC_REQUIRE does not accept arguments. Or, mor

Re: gnulib update broke printf-args.c on IRIX 6.5

On Fri, Jan 16, 2009 at 05:03:00AM -0500, Thomas Guyot-Sionnest wrote: > I recently updated gnulib in the nagios-plugins source tree to fix > issues with regex on HP-UX; unfortunately the update broke our IRIX > 6.5 build. See this thread: http://lists.gnu.org/archive/html/bug-gnulib/2009-01/msg

Re: gnulib update broke clisp

On Thu, Jan 15, 2009 at 8:09 PM, Eric Blake wrote: > AC_REQUIRE([AC_CONFIG_AUX_DIR], [AC_CONFIG_AUX_DIR([$1])]) This did the trick. Thanks! -- Sam Steingold

Re: Build fail - Intrepid

It seems like two bugs in gcc: > > case BUILT_IN_VA_ARG_PACK: > > /* All valid uses of __builtin_va_arg_pack () are removed during > > inlining. */ > > error ("%Kinvalid use of %<__builtin_va_arg_pack ()%>", exp); > > return const0_rtx; The first bug is that one us