Bruno Haible <[EMAIL PROTECTED]> wrote:
> Eric Blake wrote:
>> + /* POSIX states that sigprocmask and signal are both
>> + async-signal-safe.
>
> Going through the list of async-signal-safe functions, gnulib overrides
> quite a few. I propose to add comments so that this is reme
Hi Eric,
I noticed that the coreutils "make check" is failing due to
gnulib's new sigaction test. The buildbot shows it, too:
http://buildbot.proulx.com:9000/amd64 gnu-linux/builds/8679/step-test/0
---
FAIL: test-sigaction.log (exit: 134)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 6/22/2008 1:58 PM:
| I don't understand the "Due to autoconf conventions". We are not using
| HAVE_SIGACTION as a #define in config.h. We are using it as a shell
variable.
| This shell variable is not set by either AC_REPL
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 6/22/2008 2:06 PM:
| In the context of lib/fatal-signal.c, I find that SA_RESETHAND is not
| appropriate: If a fatal signal handler cleanup is interrupted by another
| fatal signal, it is better to start the cleanup a seco
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 6/21/2008 4:31 PM:
| Done as follows, as part of committing sigaction. It turns out that since
| mingw lacks struct sigaction, this only makes sense when using
| sigaction(). I named the helper file sig-handler.h.
I was a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 6/23/2008 2:12 AM:
| 83ASSERT (old_sa.sa_flags == 0);
|
| And the value of old_sa.sa_flags is 0x400,
| which happens to be SA_RESTORER.
Ah. An extension flag, not defined by POSIX. In short, gnulib can't mak
Hi Eric,
* Eric Blake wrote on Mon, Jun 23, 2008 at 02:26:16PM CEST:
> --- a/tests/test-sigaction.c
> +++ b/tests/test-sigaction.c
> +/* Define a mask of flags required by POSIX. Some implementations
> + provide other flags as extensions, such as SA_RESTORER, that we
> + must ignore in this
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 6/23/2008 6:36 AM:
|> +#define SA_MASK (SA_NOCLDSTOP | SA_ONSTACK | SA_RESETHAND | SA_RESTART \
|> + SA_SIGINFO | SA_NOCLDWAIT | SA_NODEFER)
|
| For safety, don't you want to stay outside the reserved SA_* na
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 6/23/2008 6:42 AM:
| According to Ralf Wildenhues on 6/23/2008 6:36 AM:
| |> +#define SA_MASK (SA_NOCLDSTOP | SA_ONSTACK | SA_RESETHAND |
| SA_RESTART\
| |> + SA_SIGINFO | SA_NOCLDWAIT | SA_NODEFER)
| |
| | For s
On m4, I'm currently playing with multiple branches, each of which has imported
a different set of gnulib modules via 'gnulib-tool --import'. I'm finding it
very difficult to track which modules have been imported to which branches by
using a 'git diff' of the various versions of gnulib-cache.m
Eric Blake wrote:
> it was failing to compile on mingw. Checking in this:
To keep the *.m4 macros in sync with the code, I'm committing this:
2008-06-23 Bruno Haible <[EMAIL PROTECTED]>
* m4/signalblocking.m4 (gl_PREREQ_SIG_HANDLER_H): Remove macro.
(gl_PREREQ_SIGPROCMASK): D
Eric Blake asked:
> Should the open-safer module depend on open?
Yes, I think fcntl-safer should depend on 'open'.
Jim, your opinion?
Bruno
Eric Blake wrote:
> The task of tracking changes to gnulib-cache.m4 would be a lot easier if
> modules were listed on a separate line, as in the proposed patch; then there
> is
> no longer any line-wrapping of the gl_MODULES portion of the file, and the
> added or deleted modules diff independe
On Sat, Jun 21, 2008 at 06:10:28PM +0200, Bruno Haible wrote:
> Michael must be using a locale in ASCII encoding; if it were a Latin1
> encoding,
> the output would have contained a cedilla, not a question mark.
I did not have the en_US.UTF8 locale installed. After installing it the
problem disa
14 matches
Mail list logo
