case-insensitive hash of strings

2007-08-21 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 A couple of questions. First, in hash-pjw.c, should we be using unsigned char instead of char to iterate through the NUL-terminated string? Second, would it be worth adding a case-insensitive version of hash_pjw, so that strings can be hashed to the

Re: case-insensitive hash of strings

2007-08-21 Thread Bruno Haible
Eric, > A couple of questions. First, in hash-pjw.c, should we be using unsigned > char instead of char to iterate through the NUL-terminated string? I believe it should usually have no effect on the average number of collisions (= average length of a non-empty hash bucket), but I would be more

Re: getline.h

2007-08-21 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 8/19/2007 2:18 PM: > Eric Blake <[EMAIL PROTECTED]> wrote: >> I could go either way, although I'm leaning toward doing it now; > > I agree. Doing it now is fine. How about this for the patch, then? Simon, this is your m