Ben Pfaff <[EMAIL PROTECTED]> writes:
> The issue at hand, as I understand it, is not even the general
> behavior of signals. It is the behavior of fatal signals. That
> is, a the program terminates without ever returning from the
> signal handler. This is much simpler than the general problem
Hello Paul,
Some nits below.
* Paul Eggert wrote on Thu, Jul 06, 2006 at 01:44:03AM CEST:
>
> Index: lib/getusershell.c
> ===
> RCS file: /cvsroot/gnulib/gnulib/lib/getusershell.c,v
> retrieving revision 1.22
> diff -p -u -r1.22 getu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 7/6/2006 1:48 AM:
> Hello Paul,
>
> Some nits below.
>
> * Paul Eggert wrote on Thu, Jul 06, 2006 at 01:44:03AM CEST:
>> Index: lib/getusershell.c
>> ===
Ralf Wildenhues wrote:
> > - while ((c = getc (stream)) != EOF && ISSPACE (c))
> > + while ((c = getc (stream)) != EOF && isspace (c))
>
> missing cast to unsigned char (c is int).
getc returns either EOF or a value in the range 0..UCHAR_MAX. The
assignment to 'int c' doesn't change this value.
Paul Eggert wrote:
> memcasecmp.c assumes UCHAR_MAX <= INT_MAX, which is not portable in
> general
Huh? On a system where 'unsigned char' and 'int' have the same number
of bits, the getc() and fgetc() result EOF would be ambiguous: it could
be EOF or it could be a casted 'unsigned char' value. It
Eric Blake <[EMAIL PROTECTED]> writes:
> Both patches installed, as proposed.
Thanks!
>> However, I'm not sure this is the Right Thing. Why doesn't it work to
>> include winsock2.h under cygwin? I.e., what's in your config.log when
>> the above happen?
>
> On cygwin, you have a choice for sock
* Paul Eggert wrote on Tue, Jul 04, 2006 at 09:43:44AM CEST:
> "Mark D. Baushke" <[EMAIL PROTECTED]> writes:
>
> > -lib_SOURCES += cycle-check.c cycle-check.h dev-ino.h
> > +lib_SOURCES += cycle-check.c cycle-check.h dev-ino.h same-inode.h
>
> Thanks for catching that; I installed it.
This shoul
* Bruno Haible wrote on Tue, Jul 04, 2006 at 06:55:08PM CEST:
> Eric Blake wrote:
> > Meanwhile, is it worth patching autoconf/lib/autoheader.m4 to complain when
> > $2 of AH_VERBATIM is empty, so this mistake is less likely to occur in the
> > future?
>
> This would be welcome. Something like thi
* Bruno Haible wrote on Thu, Jul 06, 2006 at 02:51:10PM CEST:
> Paul Eggert wrote:
>
> > * m4/getusershell.m4 (gl_PREREQ_GETUSERSHELL): Remove; no longer needed.
> > All uses removed.
> > * m4/strtol.m4 (gl_PREREQ_STRTOL): Likewise.
> > * m4/strtoul.m4 (gl_PREREQ_STRTOUL): Likewise
Hello Eric, Bruno,
* Eric Blake wrote on Thu, Jul 06, 2006 at 02:25:38PM CEST:
> According to Ralf Wildenhues on 7/6/2006 1:48 AM:
> > * Paul Eggert wrote on Thu, Jul 06, 2006 at 01:44:03AM CEST:
> >> - while ((c = getc (stream)) != EOF && ISSPACE (c))
> >> + while ((c = getc (stream)) != EOF &
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> * Paul Eggert wrote on Tue, Jul 04, 2006 at 09:43:44AM CEST:
> > "Mark D. Baushke" <[EMAIL PROTECTED]> writes:
> >
> > > -lib_SOURCES += cycle-check.c cycle-check.h dev-ino.h
> > > +lib_SOURCES += cycle-c
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> But I wonder a bit whether some code makes use of this
> "feature" that
>AH_VERBATIM([key], [some code])
>dnl ...
>AH_VERBATIM([key], []) # no code
>
> happens to not output the code. Thoughts?
It might, but can't you use $# to distinguis
Hello Mark, everyone,
* Mark D. Baushke wrote on Thu, Jul 06, 2006 at 07:31:43PM CEST:
> Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> > * Paul Eggert wrote on Tue, Jul 04, 2006 at 09:43:44AM CEST:
> > > "Mark D. Baushke" <[EMAIL PROTECTED]> writes:
> > >
> > > > -lib_SOURCES += cycle-check.c cyc
* quoting myself:
> * modules/same-inode: New module, comprising same-inode.h.
> * modules/cycle-check: Depend on it, don't list same-inode.h.
> * modules/mkdir-p, modules/same: Likewise.
Never mind this patch. It needs either a bunch of m4/ updates to list
same-inode.h in AC_LI
Ralf Wildenhues <[EMAIL PROTECTED]> wrote:
> * quoting myself:
>> * modules/same-inode: New module, comprising same-inode.h.
>> * modules/cycle-check: Depend on it, don't list same-inode.h.
>> * modules/mkdir-p, modules/same: Likewise.
>
> Never mind this patch. It needs either a bu
Bruno Haible <[EMAIL PROTECTED]> writes:
> On a system where 'unsigned char' and 'int' have the same number of
> bits, the getc() and fgetc() result EOF would be ambiguous: it could
> be EOF or it could be a casted 'unsigned char' value. It sounds very
> improbable that such a system exists, now o
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> * modules/getusershell: Add gl_FUNC_GETUSERSHELL to
> configure.ac.
Thanks; I checked that in.
One of the cheapest (ahem) ways to catch a number of gnulib bugs is to
create one tree with all modules and all tests in it. If it works, that
is. So I started doing this manually, again. Here's some fallout on
the way to make
path/to/gnulib-tool --with-tests $l --dir=foo --megatest
work.
I found a few other glitches related to the AC_HEADER_STDC changes
while propagating them into coreutils, and installed the following
further patches. Some of the problems predate the recent changes.
For example, the code wasn't portable to (theoretical?) C99
implementations that have an isblank f
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> 4) Documentation should not be copied into the source tree (bug in
>getdate module; I'm inferring from other modules here) or the
>gnulib-tool should 'mkdir doc' to avoid a cp failure. OK?
My kneejerk reaction is I'd rather that gnulib-tool c
"Derek R. Price" <[EMAIL PROTECTED]> writes:
> Thanks, Bruno. I've attached a patch that replaces all the references
> to AC_HEADER_DIRENT with calls to AC_CHECK_HEADERS_ONCE([dirent.h
> ndir.h]) and makes the accompanying changes in lib/*. This patch does
> simplify, though not quite as much as
Paul Eggert <[EMAIL PROTECTED]> writes:
> Ralf Wildenhues <[EMAIL PROTECTED]> writes:
>
>> 4) Documentation should not be copied into the source tree (bug in
>>getdate module; I'm inferring from other modules here) or the
>>gnulib-tool should 'mkdir doc' to avoid a cp failure. OK?
>
> My
Simon Josefsson <[EMAIL PROTECTED]> writes:
> I'll see if I can fix the crc module, it is probably the same 64-bit
> problem as in the md4 or md5 module a while ago.
Nope, I think the self-test was created with an old buggy crc.c
implementation. I've changed the test vector to be what the curren
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 7/6/2006 2:51 PM:
>
> 1) $destdir may not contain slashes: gnulib-tool does `mkdir "$destdir"'
>to create it, and `cd "$destdir"; $cmds; cd ..' to enter/exit.
That also could run into problems if CDPATH is defined
Paul Eggert <[EMAIL PROTECTED]> writes:
> Ben Pfaff <[EMAIL PROTECTED]> writes:
>
>> The issue at hand, as I understand it, is not even the general
>> behavior of signals. It is the behavior of fatal signals. That
>> is, a the program terminates without ever returning from the
>> signal handler.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Jim Hyslop reported needing the attached patch to compile getaddrinfo.c
in MSVC6.
2006-07-06 Jim Hyslop <[EMAIL PROTECTED]>
* lib/getaddrinfo.c: Changes to compile under MSVC6: changed
'#if WIN32_NATIVE' to '#ifdef' & moved WSAAPI m
Hello Eric,
* Eric Blake wrote on Fri, Jul 07, 2006 at 03:12:21AM CEST:
> According to Ralf Wildenhues on 7/6/2006 2:51 PM:
> >
> > 1) $destdir may not contain slashes: gnulib-tool does `mkdir "$destdir"'
> >to create it, and `cd "$destdir"; $cmds; cd ..' to enter/exit.
>
> That also could r
Simon Josefsson <[EMAIL PROTECTED]> wrote:
> Shishi actually do @include getdate.texi in its manual, so please
> don't install this part.
And GNU tar does the same.
Regards,
Sergey
28 matches
Mail list logo
