Re: warning in lchown.c

2010-03-20 Thread Eric Blake
On 03/20/2010 08:05 AM, Bruno Haible wrote: > Hi Jim or Eric, > > On MacOS X, with "gcc -Wall", I'm seeing this warning: > > gcc -DHAVE_CONFIG_H -I. -I.. -Wall -g -O2 -MT lchown.o -MD -MP -MF > .deps/lchown.Tpo -c -o lchown.o lchown.c > lchown.c: In function 'rpl_lchown': > lchown.c:73:

Re: warning in lchown.c

2010-03-20 Thread Bruno Haible
Jim Meyering wrote: > Instead of adding more #ifdefs, how about just moving that > "struct stat st;" line down a few lines so it's within > the existing #if CHOWN_CHANGE_TIME_BUG block: It looks a little uglier to me, because the variable 'st' is also used in the third #if block at the end, and th

Re: warning in lchown.c

2010-03-20 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim or Eric, > > On MacOS X, with "gcc -Wall", I'm seeing this warning: > > gcc -DHAVE_CONFIG_H -I. -I.. -Wall -g -O2 -MT lchown.o -MD -MP -MF > .deps/lchown.Tpo -c -o lchown.o lchown.c > lchown.c: In function 'rpl_lchown': > lchown.c:73: warning: unused variable

warning in lchown.c

2010-03-20 Thread Bruno Haible
Hi Jim or Eric, On MacOS X, with "gcc -Wall", I'm seeing this warning: gcc -DHAVE_CONFIG_H -I. -I.. -Wall -g -O2 -MT lchown.o -MD -MP -MF .deps/lchown.Tpo -c -o lchown.o lchown.c lchown.c: In function 'rpl_lchown': lchown.c:73: warning: unused variable 'st' Is it ok to apply this as a