Re: vasnprintf.c: Remove some compiler warnings.

2015-03-03 Thread Paul Eggert
On 03/02/2015 09:20 PM, Werner LEMBERG wrote: Looks OK to me. Thanks for checking it; I installed it.

Re: vasnprintf.c: Remove some compiler warnings.

2015-03-02 Thread Werner LEMBERG
> Generally speaking the compiler warnings you're talking about cause > false alarms so often that they're more trouble than they're worth. > For example, if P and Q are pointers into the same array and P <= Q, > it's quite normal to compute Q-P and store the result into a size_t > variable. No q

Re: vasnprintf.c: Remove some compiler warnings.

2015-03-02 Thread Paul Eggert
Generally speaking the compiler warnings you're talking about cause false alarms so often that they're more trouble than they're worth. For example, if P and Q are pointers into the same array and P <= Q, it's quite normal to compute Q-P and store the result into a size_t variable. Although I'

vasnprintf.c: Remove some compiler warnings.

2015-03-01 Thread Werner LEMBERG
The attached patch fixes some casts. Note that clang 3.5.0 produces a bunch of other sensible warnings (among not so sensible ones) where fixes aren't really necessary IMHO due to the obviousness in the code. vasnprintf.c:1874:38: warning: implicit conversion changes signedness: 'int'