Re: utimens: new shadowing warning

2009-12-31 Thread Eric Blake
Eric Blake byu.net> writes: > I just spotted a larger logic problem - on Linux kernels between 2.6.19 and > 2.6.22 (when utimensat existed, but rejected AT_SYMLINK_NOFOLLOW)(, we are now > calling lstat twice when only once is necessary. Therefore, I think the best > course of action is to r

Re: utimens: new shadowing warning

2009-12-31 Thread Eric Blake
Jim Meyering meyering.net> writes: > utimens.c: In function 'lutimens': > utimens.c:425: error: declaration of 'st' shadows a previous local [- Wshadow] > utimens.c:404: error: shadowed declaration is here [-Wshadow] > > This patch is nearly minimal, but perhaps not ideal. Thanks for the

utimens: new shadowing warning

2009-12-31 Thread Jim Meyering
Hi Eric, Without this patch, coreutils no longer builds when configured with --enable-gcc-warnings: utimens.c: In function 'lutimens': utimens.c:425: error: declaration of 'st' shadows a previous local [-Wshadow] utimens.c:404: error: shadowed declaration is here [-Wshadow] This patch is n