Jim Meyering wrote:
> My impression is that the traditional style makes it so the initialization
> and AC_SUBST *textually* bracket all uses of the variable. When they
> do not (as induced by your patch), it's less valuable, and perhaps even
> obtuse, since the other assignment is in a separate au
Bruno Haible wrote:
> Jim Meyering wrote:
>> your patch was already moving the AC_SUBST use,
>> which was technically unnecessarily.
>
> Huh? There is a 'case' statement in gl_GETHRXTIME. If the user had
> set LIB_GETHRXTIME as an environment variable and the first alternative
> of the 'case' state
Jim Meyering wrote:
> your patch was already moving the AC_SUBST use,
> which was technically unnecessarily.
Huh? There is a 'case' statement in gl_GETHRXTIME. If the user had
set LIB_GETHRXTIME as an environment variable and the first alternative
of the 'case' statement was chosen, the value prop
Bruno Haible wrote:
>> > Likewise with LIB_GETHRXTIME. How about this proposed fix?
>>
>> Good catch.
>
> Patch applied.
>
>> However, please make these two lines adjacent:
>> (pulling the AC_SUBST "up")
>> ...
>> I nearly moved the AC_SUBST lines in the changes I made recently,
>> but opted not to
Hi Jim,
> > Likewise with LIB_GETHRXTIME. How about this proposed fix?
>
> Good catch.
Patch applied.
> However, please make these two lines adjacent:
> (pulling the AC_SUBST "up")
> ...
> I nearly moved the AC_SUBST lines in the changes I made recently,
> but opted not to: I didn't want to mix
