Re: unlink test failure on MacOS X

2010-03-20 Thread Bruno Haible
Jim Meyering wrote: > > + (umask 077 && mkdir "$tmp") > > +}; then > > + mkdir "$tmp/subdir" > > + export tmp > > + AC_RUN_IFELSE( > > + [AC_LANG_SOURCE([[ > > +#include > > +#include > > +

Re: unlink test failure on MacOS X

2010-03-20 Thread Jim Meyering
Bruno Haible wrote: > The workaround below impacts only MacOS platforms. I'm applying it. > It also fixes the 'unlinkat' test failure. > > 2010-03-20 Bruno Haible > > Work around unlink() bug on MacOS X 10.5.6. > * lib/unlink.c (rpl_unlink): If UNLINK_PARENT_BUG is defined, fail when

Re: unlink test failure on MacOS X

2010-03-20 Thread Bruno Haible
Hi Eric, > > This prints > > -1 21 [EISDIR] > > on Linux, but > > 0 0 > > on MacOS X. > > Which version of MacOS X? What does uname state? What file system? For me, it happens on MacOS X 10.5.6. I could only test HFS+. > I cannot reproduce it on the machine I have access to, tested on an nfs

Re: unlink test failure on MacOS X

2010-03-17 Thread Eric Blake
On 03/14/2010 06:16 PM, Bruno Haible wrote: > The reason is that unlink("..") returns 0 without having done any side effects > on the file system. Likewise for unlink("../.."). > > Test program: > = foo.c > #include > #include > #include > int ma

Re: unlink test failure on MacOS X

2010-03-15 Thread Eric Blake
On 03/14/2010 06:16 PM, Bruno Haible wrote: > Hi Jim, Eric, > > On MacOS X 10.5, the unlink() and unlinkat() tests fail: > > test-unlink.h:49: assertion failed > /bin/sh: line 1: 17670 Abort trap EXEEXT='' srcdir='.' > ${dir}$tst > FAIL: test-unlink Thanks for investigating.

Re: unlink test failure on MacOS X

2010-03-15 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, Eric, > > On MacOS X 10.5, the unlink() and unlinkat() tests fail: > > test-unlink.h:49: assertion failed > /bin/sh: line 1: 17670 Abort trap EXEEXT='' srcdir='.' > ${dir}$tst > FAIL: test-unlink > > test-unlink.h:49: assertion failed > /bin/sh:

unlink test failure on MacOS X

2010-03-14 Thread Bruno Haible
Hi Jim, Eric, On MacOS X 10.5, the unlink() and unlinkat() tests fail: test-unlink.h:49: assertion failed /bin/sh: line 1: 17670 Abort trap EXEEXT='' srcdir='.' ${dir}$tst FAIL: test-unlink test-unlink.h:49: assertion failed /bin/sh: line 1: 63034 Abort trap E