Re: uchar-c23: Speed up mbrtoc32 on Solaris 11.4

2024-05-26 Thread Bruno Haible
Collin Funk wrote: > I'm not sure how long this would have taken to get caught without CI. I run the testdirs on various platforms occasionally. Without the CI, I would have noticed within a few months. The real question is: How could we have detected this without the test-mcel.c test? Our unit t

Re: uchar-c23: Speed up mbrtoc32 on Solaris 11.4

2024-05-25 Thread Collin Funk
On 5/25/24 3:15 AM, Bruno Haible wrote: > The Solaris 11.4 test run on GitHub is taking 4 hours, whereas it's only > 1 hour (at most) on the other platforms. > > In order to investigate this, I attached a time stamp to each output line: > > $make 2>&1 | gawk '{ print strftime("%H:%M:%S"), $0; f

uchar-c23: Speed up mbrtoc32 on Solaris 11.4

2024-05-25 Thread Bruno Haible
e code is invoking iconv_open (even twice), and that calls dlopen, which does lots of filesystem and mmap() calls. The function 'get_converters' was meant to cache its result, but didn't. This patch fixes it and brings the execution times down to ca. 4 seconds. 2024-05-25 Bruno