Eric Blake writes:
> I'm applying this:
Tested and works fine for me, thanks!
/Simon
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 11/17/2009 12:07 PM:
>> -compare - t-xalloc-die.tmp <<\EOF || { (exit 1); exit 1; }
>> +cat $tmperr | tr -d '\015' > ${tmperr}2
>
> Useless use of cat. Also, check for errors. Try:
>
> tr -d '\015' < $tmperr > ${tmperr}2
Eric Blake wrote:
...
> test ! -s $tmpout || { (exit 1); exit 1; }
>
> Hmm, I'm really starting to like the idea of a common init script, so we can
> just do "Exit 1" instead of "{ (exit 1); exit 1; }".
Exactly.
The next question is whether to automatically create a temporary directory
for each te
Simon Josefsson josefsson.org> writes:
>
> I noticed an EOL problem on mingw and pushed the fix below.
You beat me to it; I noticed the same, but didn't have quite as large a patch.
>
> -tmpfiles="t-xalloc-die.tmp"
> +tmpout=t-xalloc-die.tmp-stderr
> +tmperr=t-xalloc-die.tmp-stdout
> +tmpfile
I noticed an EOL problem on mingw and pushed the fix below.
/Simon
>From 3e00f5fce5b904dc642aff88abbcf75867263e0a Mon Sep 17 00:00:00 2001
From: Simon Josefsson
Date: Tue, 17 Nov 2009 19:58:12 +0100
Subject: [PATCH] tests/test-xalloc-die.sh: Deal with EOL differences, and more.
---
ChangeLog
