Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-24 Thread Richard W.M. Jones
I see two patches that went into gnulib overnight. I have now tried compiling hivex with gnulib at commit 34881aff4043, and that seems to have fixed the problem, thanks all. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtuali

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-24 Thread Richard W.M. Jones
On Thu, Jan 24, 2019 at 01:38:28AM +0300, Dmitry V. Levin wrote: > On Wed, Jan 23, 2019 at 10:24:26PM +, Richard W.M. Jones wrote: > > On Thu, Jan 24, 2019 at 01:09:52AM +0300, Dmitry V. Levin wrote: > > > On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > > > > On Thu, Jan 2

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
> (2) threadlib.m4 defines LIBMULTITHREAD in a way that is meant to defeat > -Wl,--as-needed. But it does not work, due to the reordering of > options done by libtool. Let me take out the code that does not work. 2019-01-23 Bruno Haible threadlib: Revert commit from 2018-06-2

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
Let me summarize the issue. (1) The distro sets LDFLAGS="-Wl,--as-needed". So, libraries that not are not required through at least 1 symbol are not linked in. (2) threadlib.m4 defines LIBMULTITHREAD in a way that is meant to defeat -Wl,--as-needed. But it does not work, due to the reorder

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
Dmitry V. Levin wrote: > According to the log, it was libtool that broke a valid command > > /bin/sh ../../libtool --tag=CC --preserve-dup-deps --mode=link gcc -O2 -g > -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 > -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Dmitry V. Levin
On Wed, Jan 23, 2019 at 10:24:26PM +, Richard W.M. Jones wrote: > On Thu, Jan 24, 2019 at 01:09:52AM +0300, Dmitry V. Levin wrote: > > On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > > > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > > > > Hi, > > > >

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
On Thu, Jan 24, 2019 at 01:09:52AM +0300, Dmitry V. Levin wrote: > On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > > > Hi, > > > > > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > >

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Dmitry V. Levin
On Wed, Jan 23, 2019 at 09:14:30PM +, Richard W.M. Jones wrote: > On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > > Hi, > > > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > > > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > > [...] >

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
On Thu, Jan 24, 2019 at 12:03:21AM +0300, Dmitry V. Levin wrote: > Hi, > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > [...] > > I checked the history of the Fedora package which adds these flags, and > > i

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Michael Hudson-Doyle
On Thu, 24 Jan 2019 at 10:03, Dmitry V. Levin wrote: > Hi, > > On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > [...] > > I checked the history of the Fedora package which adds these flags, and > > it seems lik

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Dmitry V. Levin
Hi, On Wed, Jan 23, 2019 at 08:45:06PM +, Richard W.M. Jones wrote: > On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: [...] > I checked the history of the Fedora package which adds these flags, and > it seems like --as-needed was added for: > > https://fedoraproject.org/wiki/Cha

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
On Wed, Jan 23, 2019 at 09:01:19PM +0100, Bruno Haible wrote: > Hi Rich, > > > I cannot reproduce this locally, hence my bug report is rather devoid > > of details. However, it's 100% reproducible in Koji (the Fedora > > Rawhide build system) on *all* architectures except armv7: > > > > FAIL: te

Re: test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Bruno Haible
Hi Rich, > I cannot reproduce this locally, hence my bug report is rather devoid > of details. However, it's 100% reproducible in Koji (the Fedora > Rawhide build system) on *all* architectures except armv7: > > FAIL: test-rwlock1 > == > Unexpected outcome 3 > FAIL: test-thread_c

test-rwlock1 failing on latest Fedora Rawhide

2019-01-23 Thread Richard W.M. Jones
I cannot reproduce this locally, hence my bug report is rather devoid of details. However, it's 100% reproducible in Koji (the Fedora Rawhide build system) on *all* architectures except armv7: FAIL: test-rwlock1 == Unexpected outcome 3 FAIL: test-thread_create The full log is h